upstream/mercurial-mirror Files · tests/test-mactext.t

wireprotov2: implement commands as a generator of objects...

wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

Pulkit Goyal - - Load All Authors

File last commit:

r36040:adec6374 default


                r39595:07b58266

default

Download file

             test-mactext.t
        
                    38 lines
            
             | 1.0 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-mactext.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: unify test-mactext

              r12458
            
        $ cat > unix2mac.py <<EOF

        > import sys

        > 

        > for path in sys.argv[1:]:

        Pulkit Goyal
    
py3: replace file() with open() in test-mactext.t...

              r36040
            
        >     data = open(path, 'rb').read()

        >     data = data.replace(b'\n', b'\r')

        >     open(path, 'wb').write(data)

        Matt Mackall
    
tests: unify test-mactext

              r12458
            
        > EOF

        $ cat > print.py <<EOF

        > import sys

        > print(sys.stdin.read().replace('\n', '<LF>').replace('\r', '<CR>').replace('\0', '<NUL>'))

        > EOF

        $ hg init

        $ echo '[hooks]' >> .hg/hgrc

        $ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

        $ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

        $ cat .hg/hgrc

        [hooks]

        pretxncommit.cr = python:hgext.win32text.forbidcr

        pretxnchangegroup.cr = python:hgext.win32text.forbidcr

        Mads Kiilerich
    
tests: cleanup of echo statements left over from test conversion

              r15243
            
        Matt Mackall
    
tests: unify test-mactext

              r12458
            
        $ echo hello > f

        $ hg add f

        $ hg ci -m 1

        Mads Kiilerich
    
tests: cleanup of echo statements left over from test conversion

              r15243
            
        Augie Fackler
    
cleanup: use $PYTHON to run python in many more tests...

              r32940
            
        $ $PYTHON unix2mac.py f

        Matt Mackall
    
tests: unify test-mactext

              r12458
            
        $ hg ci -m 2

        Martin Geisler
    
win32text: lowercase warning message

              r16932
            
        attempt to commit or push text file(s) using CR line endings

        Matt Mackall
    
tests: unify test-mactext

              r12458
            
        in dea860dc51ec: f

        transaction abort!

        rollback completed

        abort: pretxncommit.cr hook failed

        [255]

        Augie Fackler
    
cleanup: use $PYTHON to run python in many more tests...

              r32940
            
        $ hg cat f | $PYTHON print.py

        Matt Mackall
    
tests: unify test-mactext

              r12458
            
        hello<LF>

        Augie Fackler
    
cleanup: use $PYTHON to run python in many more tests...

              r32940
            
        $ cat f | $PYTHON print.py

        Matt Mackall
    
tests: unify test-mactext

              r12458
            
        hello<CR>

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: unify test-mactext	r12458
		$ cat > unix2mac.py <<EOF
		> import sys
		>
		> for path in sys.argv[1:]:
Pulkit Goyal py3: replace file() with open() in test-mactext.t...	r36040	> data = open(path, 'rb').read()
		> data = data.replace(b'\n', b'\r')
		> open(path, 'wb').write(data)
Matt Mackall tests: unify test-mactext	r12458	> EOF
		$ cat > print.py <<EOF
		> import sys
		> print(sys.stdin.read().replace('\n', '<LF>').replace('\r', '<CR>').replace('\0', '<NUL>'))
		> EOF
		$ hg init
		$ echo '[hooks]' >> .hg/hgrc
		$ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc
		$ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc
		$ cat .hg/hgrc
		[hooks]
		pretxncommit.cr = python:hgext.win32text.forbidcr
		pretxnchangegroup.cr = python:hgext.win32text.forbidcr
Mads Kiilerich tests: cleanup of echo statements left over from test conversion	r15243
Matt Mackall tests: unify test-mactext	r12458	$ echo hello > f
		$ hg add f
		$ hg ci -m 1
Mads Kiilerich tests: cleanup of echo statements left over from test conversion	r15243
Augie Fackler cleanup: use $PYTHON to run python in many more tests...	r32940	$ $PYTHON unix2mac.py f
Matt Mackall tests: unify test-mactext	r12458	$ hg ci -m 2
Martin Geisler win32text: lowercase warning message	r16932	attempt to commit or push text file(s) using CR line endings
Matt Mackall tests: unify test-mactext	r12458	in dea860dc51ec: f
		transaction abort!
		rollback completed
		abort: pretxncommit.cr hook failed
		[255]
Augie Fackler cleanup: use $PYTHON to run python in many more tests...	r32940	$ hg cat f \| $PYTHON print.py
Matt Mackall tests: unify test-mactext	r12458	hello<LF>
Augie Fackler cleanup: use $PYTHON to run python in many more tests...	r32940	$ cat f \| $PYTHON print.py
Matt Mackall tests: unify test-mactext	r12458	hello<CR>