##// END OF EJS Templates
wireprotov2: implement commands as a generator of objects...
wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

File last commit:

r33262:8e6f4939 default
r39595:07b58266 default
Show More
test-push-cgi.t
95 lines | 2.7 KiB | text/troff | Tads3Lexer
Matt Mackall
tests: replace exit 80 with #require
r22046 #require no-msys # MSYS will translate web paths as if they were file paths
Mads Kiilerich
tests: introduce 'hghave msys' to skip tests that would fail because of msys
r15567
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 This is a test of the push wire protocol over CGI-based hgweb.
initialize repository
$ hg init r
$ cd r
$ echo a > a
$ hg ci -A -m "0"
adding a
$ echo '[web]' > .hg/hgrc
$ echo 'allow_push = *' >> .hg/hgrc
$ echo 'push_ssl = false' >> .hg/hgrc
create hgweb invocation script
$ cat >hgweb.cgi <<HGWEB
> import cgitb
> cgitb.enable()
> from mercurial import demandimport; demandimport.enable()
> from mercurial.hgweb import hgweb
> from mercurial.hgweb import wsgicgi
> application = hgweb('.', 'test repository')
> wsgicgi.launch(application)
> HGWEB
$ chmod 755 hgweb.cgi
test preparation
$ . "$TESTDIR/cgienv"
$ REQUEST_METHOD="POST"; export REQUEST_METHOD
$ CONTENT_TYPE="application/octet-stream"; export CONTENT_TYPE
Pierre-Yves David
test: enforce bundle1 in 'test-push-cgi.t'...
r26865 $ hg bundle --type v1 --all bundle.hg
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 1 changesets found
$ CONTENT_LENGTH=279; export CONTENT_LENGTH;
Mads Kiilerich
wireproto: clarify cryptic 'remote: unsynced changes' error message on push...
r18957 expect failure because heads doesn't match (formerly known as 'unsynced changes')
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397
$ QUERY_STRING="cmd=unbundle&heads=0000000000000000000000000000000000000000"; export QUERY_STRING
Augie Fackler
tests: replace yet more calls to `python` with $PYTHON...
r33262 $ $PYTHON hgweb.cgi <bundle.hg >page1 2>&1
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 $ cat page1
Status: 200 Script output follows\r (esc)
Content-Type: application/mercurial-0.1\r (esc)
Mads Kiilerich
wireproto: clarify cryptic 'remote: unsynced changes' error message on push...
r18957 Content-Length: 64\r (esc)
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 \r (esc)
0
Mads Kiilerich
wireproto: clarify cryptic 'remote: unsynced changes' error message on push...
r18957 repository changed while preparing changes - please try again
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397
successful force push
$ QUERY_STRING="cmd=unbundle&heads=666f726365"; export QUERY_STRING
Augie Fackler
tests: replace yet more calls to `python` with $PYTHON...
r33262 $ $PYTHON hgweb.cgi <bundle.hg >page2 2>&1
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 $ cat page2
Status: 200 Script output follows\r (esc)
Content-Type: application/mercurial-0.1\r (esc)
Mads Kiilerich
hgweb: use Content-Length for pushres...
r18346 Content-Length: 102\r (esc)
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 \r (esc)
1
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 1 files
Steven Brown
tests: new test cases for the unbundlehash capability
r13946 successful push, list of heads
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397
$ QUERY_STRING="cmd=unbundle&heads=f7b1eb17ad24730a1651fccd46c43826d1bbc2ac"; export QUERY_STRING
Augie Fackler
tests: replace yet more calls to `python` with $PYTHON...
r33262 $ $PYTHON hgweb.cgi <bundle.hg >page3 2>&1
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 $ cat page3
Status: 200 Script output follows\r (esc)
Content-Type: application/mercurial-0.1\r (esc)
Mads Kiilerich
hgweb: use Content-Length for pushres...
r18346 Content-Length: 102\r (esc)
Steven Brown
tests: push wire protocol over CGI-based hgweb
r13397 \r (esc)
1
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 1 files
Steven Brown
tests: new test cases for the unbundlehash capability
r13946
successful push, SHA1 hash of heads (unbundlehash capability)
$ QUERY_STRING="cmd=unbundle&heads=686173686564 5a785a5f9e0d433b88ed862b206b011b0c3a9d13"; export QUERY_STRING
Augie Fackler
tests: replace yet more calls to `python` with $PYTHON...
r33262 $ $PYTHON hgweb.cgi <bundle.hg >page4 2>&1
Steven Brown
tests: new test cases for the unbundlehash capability
r13946 $ cat page4
Status: 200 Script output follows\r (esc)
Content-Type: application/mercurial-0.1\r (esc)
Mads Kiilerich
hgweb: use Content-Length for pushres...
r18346 Content-Length: 102\r (esc)
Steven Brown
tests: new test cases for the unbundlehash capability
r13946 \r (esc)
1
adding changesets
adding manifests
adding file changes
added 0 changesets with 0 changes to 1 files
Mads Kiilerich
tests: add missing trailing 'cd ..'...
r16913
$ cd ..