##// END OF EJS Templates
wireprotov2: implement commands as a generator of objects...
wireprotov2: implement commands as a generator of objects Previously, wire protocol version 2 inherited version 1's model of having separate types to represent the results of different wire protocol commands. As I implemented more powerful commands in future commits, I found I was using a common pattern of returning a special type to hold a generator. This meant the command function required a closure to do most of the work. That made logic flow more difficult to follow. I also noticed that many commands were effectively a sequence of objects to be CBOR encoded. I think it makes sense to define version 2 commands as generators. This way, commands can simply emit the data structures they wish to send to the client. This eliminates the need for a closure in command functions and removes encoding from the bodies of commands. As part of this commit, the handling of response objects has been moved into the serverreactor class. This puts the reactor in the driver's seat with regards to CBOR encoding and error handling. Having error handling in the function that emits frames is particularly important because exceptions in that function can lead to things getting in a bad state: I'm fairly certain that uncaught exceptions in the frame generator were causing deadlocks. I also introduced a dedicated error type for explicit error reporting in command handlers. This will be used in subsequent commits. There's still a bit of work to be done here, especially around formalizing the error handling "protocol." I've added yet another TODO to track this so we don't forget. Test output changed because we're using generators and no longer know we are at the end of the data until we hit the end of the generator. This means we can't emit the end-of-stream flag until we've exhausted the generator. Hence the introduction of 0-sized end-of-stream frames. Differential Revision: https://phab.mercurial-scm.org/D4472

File last commit:

r37153:ecac0006 default
r39595:07b58266 default
Show More
test-requires.t
73 lines | 2.3 KiB | text/troff | Tads3Lexer
Martin Geisler
tests: remove redundant mkdir...
r13956 $ hg init t
Nicolas Dumazet
tests: unify test-requires
r12116 $ cd t
$ echo a > a
$ hg add a
Martin Geisler
tests: remove unneeded -d flags...
r12156 $ hg commit -m test
Nicolas Dumazet
tests: unify test-requires
r12116 $ rm .hg/requires
$ hg tip
Gregory Szorc
revlog: tweak wording and logic for flags validation...
r32391 abort: unknown version (2) in revlog 00changelog.i!
Matt Mackall
tests: add exit codes to unified tests
r12316 [255]
Nicolas Dumazet
tests: unify test-requires
r12116 $ echo indoor-pool > .hg/requires
$ hg tip
Mads Kiilerich
repo: rephrase the "missing requirement" error message...
r20820 abort: repository requires features unknown to this Mercurial: indoor-pool!
Matt Mackall
urls: bulk-change primary website URLs
r26421 (see https://mercurial-scm.org/wiki/MissingRequirement for more information)
Matt Mackall
tests: add exit codes to unified tests
r12316 [255]
Pierre-Yves David
requirements: show all missing features in the error message....
r14746 $ echo outdoor-pool >> .hg/requires
$ hg tip
Mads Kiilerich
repo: rephrase the "missing requirement" error message...
r20820 abort: repository requires features unknown to this Mercurial: indoor-pool outdoor-pool!
Matt Mackall
urls: bulk-change primary website URLs
r26421 (see https://mercurial-scm.org/wiki/MissingRequirement for more information)
Pierre-Yves David
requirements: show all missing features in the error message....
r14746 [255]
FUJIWARA Katsunori
localrepo: make supported features manageable in each repositories individually...
r19778 $ cd ..
Test checking between features supported locally and ones required in
another repository of push/pull/clone on localhost:
$ mkdir supported-locally
$ cd supported-locally
$ hg init supported
$ echo a > supported/a
$ hg -R supported commit -Am '#0 at supported'
adding a
$ echo 'featuresetup-test' >> supported/.hg/requires
$ cat > $TESTTMP/supported-locally/supportlocally.py <<EOF
Augie Fackler
tests: update test-requires to pass our import checker
r33987 > from __future__ import absolute_import
> from mercurial import extensions, localrepo
FUJIWARA Katsunori
localrepo: make supported features manageable in each repositories individually...
r19778 > def featuresetup(ui, supported):
> for name, module in extensions.extensions(ui):
> if __name__ == module.__name__:
> # support specific feature locally
Martin von Zweigbergk
cleanup: use set literals...
r32291 > supported |= {'featuresetup-test'}
FUJIWARA Katsunori
localrepo: make supported features manageable in each repositories individually...
r19778 > return
> def uisetup(ui):
Gregory Szorc
localrepo: move featuresetupfuncs out of localrepository class (API)...
r37153 > localrepo.featuresetupfuncs.add(featuresetup)
FUJIWARA Katsunori
localrepo: make supported features manageable in each repositories individually...
r19778 > EOF
$ cat > supported/.hg/hgrc <<EOF
> [extensions]
> # enable extension locally
> supportlocally = $TESTTMP/supported-locally/supportlocally.py
> EOF
$ hg -R supported status
$ hg init push-dst
$ hg -R supported push push-dst
pushing to push-dst
abort: required features are not supported in the destination: featuresetup-test
[255]
$ hg init pull-src
$ hg -R pull-src pull supported
pulling from supported
abort: required features are not supported in the destination: featuresetup-test
[255]
$ hg clone supported clone-dst
Mads Kiilerich
repo: rephrase the "missing requirement" error message...
r20820 abort: repository requires features unknown to this Mercurial: featuresetup-test!
Matt Mackall
urls: bulk-change primary website URLs
r26421 (see https://mercurial-scm.org/wiki/MissingRequirement for more information)
FUJIWARA Katsunori
localrepo: make supported features manageable in each repositories individually...
r19778 [255]
$ hg clone --pull supported clone-dst
abort: required features are not supported in the destination: featuresetup-test
[255]
Mads Kiilerich
tests: add missing trailing 'cd ..'...
r16913
$ cd ..