##// END OF EJS Templates
windows: quote the specified string only when it has to be quoted...
windows: quote the specified string only when it has to be quoted Before this patch, "windows.shellquote" (as used as "util.shellquote") always quotes specified strings with double quotation marks, for external process invocation. But some problematic applications can't work correctly, when command line arguments are quoted: see issue4463 for detail. On the other hand, quoting itself is needed to specify arguments containing whitespaces and/or some special characters exactly. This patch makes "windows.shellquote" examine the specified string and quote it only when it may have to be quoted for safety.

File last commit:

r23682:1642eb42 default
r23682:1642eb42 default
Show More
test-extdiff.t
302 lines | 7.8 KiB | text/troff | Tads3Lexer
Adrian Buehlmann
tests: unify test-extdiff
r12304 $ echo "[extensions]" >> $HGRCPATH
$ echo "extdiff=" >> $HGRCPATH
$ hg init a
$ cd a
$ echo a > a
$ echo b > b
$ hg add
adding a
adding b
Should diff cloned directories:
$ hg extdiff -o -r $opt
Only in a: a
Only in a: b
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
Yuya Nishihara
tests: write hgrc of more than two lines by using shell heredoc...
r23172 $ cat <<EOF >> $HGRCPATH
> [extdiff]
> cmd.falabala = echo
> opts.falabala = diffing
> cmd.edspace = echo
> opts.edspace = "name <user@example.com>"
> EOF
Adrian Buehlmann
tests: unify test-extdiff
r12304
$ hg falabala
diffing a.000000000000 a
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
$ hg help falabala
hg falabala [OPTION]... [FILE]...
use 'echo' to diff repository (or selected files)
Show differences between revisions for the specified files, using the
'echo' program.
When two revision arguments are given, then changes are shown between
those revisions. If only one revision is specified then that revision is
compared to the working directory, and, when no revisions are specified,
the working directory files are compared to its parent.
Matt Mackall
help: fold repeatable option message into option table header...
r22117 options ([+] can be repeated):
Adrian Buehlmann
tests: unify test-extdiff
r12304
Matt Mackall
help: use RST to format option lists
r15145 -o --option OPT [+] pass option to comparison program
-r --rev REV [+] revision
-c --change REV change made by revision
-I --include PATTERN [+] include names matching the given patterns
-X --exclude PATTERN [+] exclude names matching the given patterns
Adrian Buehlmann
tests: unify test-extdiff
r12304
Matt Mackall
help: tweak --verbose command help hint...
r22110 (some details hidden, use --verbose to show complete help)
Adrian Buehlmann
tests: unify test-extdiff
r12304
$ hg ci -d '0 0' -mtest1
$ echo b >> a
$ hg ci -d '1 0' -mtest2
Should diff cloned files directly:
$ hg falabala -r 0:1
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 diffing */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
Test diff during merge:
$ hg update -C 0
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ echo c >> c
$ hg add c
$ hg ci -m "new branch" -d '1 0'
created new head
$ hg merge 1
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
(branch merge, don't forget to commit)
Should diff cloned file against wc file:
Erik Zielke
tests: removed test names in tests...
r12587 $ hg falabala
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 diffing */extdiff.*/a.2a13a4d2da36/a */a/a (glob)
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
Test --change option:
$ hg ci -d '2 0' -mtest3
$ hg falabala -c 1
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 diffing */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
Check diff are made from the first parent:
$ hg falabala -c 3 || echo "diff-like tools yield a non-zero exit code"
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 diffing */extdiff.*/a.2a13a4d2da36/a a.46c0e4daeb72/a (glob)
Adrian Buehlmann
tests: unify test-extdiff
r12304 diff-like tools yield a non-zero exit code
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 issue4463: usage of command line configuration without additional quoting
$ cat <<EOF >> $HGRCPATH
> [extdiff]
> cmd.4463a = echo
> opts.4463a = a-naked 'single quoted' "double quoted"
> 4463b = echo b-naked 'single quoted' "double quoted"
> echo =
> EOF
$ hg update -q -C 0
$ echo a >> a
#if windows
$ hg --debug 4463a | grep '^running'
FUJIWARA Katsunori
windows: quote the specified string only when it has to be quoted...
r23682 running 'echo a-naked \'single quoted\' "double quoted" *\\a *\\a' in */extdiff.* (glob)
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 $ hg --debug 4463b | grep '^running'
FUJIWARA Katsunori
windows: quote the specified string only when it has to be quoted...
r23682 running 'echo b-naked \'single quoted\' "double quoted" *\\a *\\a' in */extdiff.* (glob)
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 $ hg --debug echo | grep '^running'
FUJIWARA Katsunori
windows: quote the specified string only when it has to be quoted...
r23682 running '*echo* *\\a *\\a' in */extdiff.* (glob)
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 #else
$ hg --debug 4463a | grep '^running'
running '\'echo\' a-naked \'single quoted\' "double quoted" \'*/a\' \'$TESTTMP/a/a\'' in */extdiff.* (glob)
$ hg --debug 4463b | grep '^running'
running 'echo b-naked \'single quoted\' "double quoted" \'*/a\' \'$TESTTMP/a/a\'' in */extdiff.* (glob)
$ hg --debug echo | grep '^running'
running "'*echo*' '*/a' '$TESTTMP/a/a'" in */extdiff.* (glob)
#endif
(getting options from other than extdiff section)
$ cat <<EOF >> $HGRCPATH
> [extdiff]
> # using diff-tools diffargs
> 4463b2 = echo
> # using merge-tools diffargs
> 4463b3 = echo
> # no diffargs
> 4463b4 = echo
> [diff-tools]
> 4463b2.diffargs = b2-naked 'single quoted' "double quoted"
> [merge-tools]
> 4463b3.diffargs = b3-naked 'single quoted' "double quoted"
> EOF
#if windows
$ hg --debug 4463b2 | grep '^running'
FUJIWARA Katsunori
windows: quote the specified string only when it has to be quoted...
r23682 running 'echo b2-naked \'single quoted\' "double quoted" *\\a *\\a' in */extdiff.* (glob)
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 $ hg --debug 4463b3 | grep '^running'
FUJIWARA Katsunori
windows: quote the specified string only when it has to be quoted...
r23682 running 'echo b3-naked \'single quoted\' "double quoted" *\\a *\\a' in */extdiff.* (glob)
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 $ hg --debug 4463b4 | grep '^running'
FUJIWARA Katsunori
windows: quote the specified string only when it has to be quoted...
r23682 running 'echo *\\a *\\a' in */extdiff.* (glob)
$ hg --debug 4463b4 --option b4-naked --option 'being quoted' | grep '^running'
running 'echo b4-naked "being quoted" *\\a *\\a' in */extdiff.* (glob)
$ hg --debug extdiff -p echo --option echo-naked --option 'being quoted' | grep '^running'
running 'echo echo-naked "being quoted" *\\a *\\a' in */extdiff.* (glob)
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 #else
$ hg --debug 4463b2 | grep '^running'
running 'echo b2-naked \'single quoted\' "double quoted" \'*/a\' \'$TESTTMP/a/a\'' in */extdiff.* (glob)
$ hg --debug 4463b3 | grep '^running'
running 'echo b3-naked \'single quoted\' "double quoted" \'*/a\' \'$TESTTMP/a/a\'' in */extdiff.* (glob)
$ hg --debug 4463b4 | grep '^running'
running "echo '*/a' '$TESTTMP/a/a'" in */extdiff.* (glob)
$ hg --debug 4463b4 --option 'being quoted' | grep '^running'
running "echo 'being quoted' '*/a' '$TESTTMP/a/a'" in */extdiff.* (glob)
$ hg --debug extdiff -p echo --option 'being quoted' | grep '^running'
running "'echo' 'being quoted' '*/a' '$TESTTMP/a/a'" in */extdiff.* (glob)
#endif
Mads Kiilerich
tests: convert some 'hghave execbit' to #if...
r16899 #if execbit
Adrian Buehlmann
tests: unify test-extdiff
r12304 Test extdiff of multiple files in tmp dir:
$ hg update -C 0 > /dev/null
$ echo changed > a
$ echo changed > b
$ chmod +x b
Diff in working directory, before:
$ hg diff --git
diff --git a/a b/a
--- a/a
+++ b/a
@@ -1,1 +1,1 @@
-a
+changed
diff --git a/b b/b
old mode 100644
new mode 100755
--- a/b
+++ b/b
@@ -1,1 +1,1 @@
-b
+changed
Edit with extdiff -p:
Prepare custom diff/edit tool:
$ cat > 'diff tool.py' << EOT
> #!/usr/bin/env python
> import time
> time.sleep(1) # avoid unchanged-timestamp problems
> file('a/a', 'ab').write('edited\n')
> file('a/b', 'ab').write('edited\n')
> EOT
$ chmod +x 'diff tool.py'
Matt Mackall
tests: fix a bunch of pointless #s in unified tests
r12328 will change to /tmp/extdiff.TMP and populate directories a.TMP and a
and start tool
Adrian Buehlmann
tests: unify test-extdiff
r12304 $ hg extdiff -p "`pwd`/diff tool.py"
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
Diff in working directory, after:
$ hg diff --git
diff --git a/a b/a
--- a/a
+++ b/a
@@ -1,1 +1,2 @@
-a
+changed
+edited
diff --git a/b b/b
old mode 100644
new mode 100755
--- a/b
+++ b/b
@@ -1,1 +1,2 @@
-b
+changed
+edited
Test extdiff with --option:
$ hg extdiff -p echo -o this -c 1
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 this */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
$ hg falabala -o this -c 1
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 diffing this */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
Adrian Buehlmann
tests: unify test-extdiff
r12304
Michael Fyles
extdiff: quote user-supplied options passed to shell...
r23138 Test extdiff's handling of options with spaces in them:
$ hg edspace -c 1
name <user@example.com> */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
[1]
$ hg extdiff -p echo -o "name <user@example.com>" -c 1
name <user@example.com> */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
[1]
David Wolever
Updating hgext.extdiff to use revsets
r13660 Test with revsets:
$ hg extdif -p echo -c "rev(1)"
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
Matt Mackall
tests: add exit codes to unified tests
r12316 [1]
David Wolever
Updating hgext.extdiff to use revsets
r13660
$ hg extdif -p echo -r "0::1"
Patrick Mezard
test-extdiff: fix 5c0e1222e7c0 temporary dir output
r13762 */extdiff.*/a.8a5febb7f867/a a.34eed99112ab/a (glob)
David Wolever
Updating hgext.extdiff to use revsets
r13660 [1]
Thomas Arendsen Hein
merge with stable
r14024
Matt Harbison
extdiff: allow a preconfigured merge-tool to be invoked...
r23150 Fallback to merge-tools.tool.executable|regkey
$ mkdir dir
$ cat > 'dir/tool.sh' << EOF
> #!/bin/sh
> echo "** custom diff **"
> EOF
$ chmod +x dir/tool.sh
$ tool=`pwd`/dir/tool.sh
$ hg --debug tl --config extdiff.tl= --config merge-tools.tl.executable=$tool
making snapshot of 2 files from rev * (glob)
a
b
making snapshot of 2 files from working directory
a
b
FUJIWARA Katsunori
extdiff: avoid unexpected quoting arguments for external tools (issue4463)...
r23680 running "'$TESTTMP/a/dir/tool.sh' 'a.*' 'a'" in */extdiff.* (glob)
Matt Harbison
extdiff: allow a preconfigured merge-tool to be invoked...
r23150 ** custom diff **
cleaning up temp directory
[1]
Patrick Mezard
extdiff: fix broken symlinks handling (issue1909)
r14021 $ cd ..
Adrian Buehlmann
tests: unify test-extdiff
r12304
Mads Kiilerich
tests: convert some 'hghave execbit' to #if...
r16899 #endif
#if symlink
Thomas Arendsen Hein
merge with stable
r14024 Test symlinks handling (issue1909)
Patrick Mezard
extdiff: fix broken symlinks handling (issue1909)
r14021 $ hg init testsymlinks
$ cd testsymlinks
$ echo a > a
$ hg ci -Am adda
adding a
$ echo a >> a
$ ln -s missing linka
$ hg add linka
$ hg falabala -r 0 --traceback
diffing testsymlinks.07f494440405 testsymlinks
[1]
$ cd ..
Mads Kiilerich
tests: convert some 'hghave execbit' to #if...
r16899
#endif