upstream/mercurial-mirror Files · contrib/python-hook-examples.py

interfaces: make the `peer` mixin not a Protocol to fix Python 3.10 failures...

interfaces: make the `peer` mixin not a Protocol to fix Python 3.10 failures I can't find any documentation on this, but it appears that Protocol class attributes don't get inherited in subclasses that explicitly subclass a Protocol until Python 3.11, which caused a ton of failures in CI on macOS and Windows (which both test using Python 3.9). The problem started with 1df97507c6b8, and typically manifested as most tests failing to access `ui` on various `peer` classes. Here's a short proof of concept: from __future__ import annotations from typing import ( Protocol, ) class peer(Protocol): limitedarguments: bool = False def __init__(self, arg1, arg2, remotehidden: bool = False) -> None: self.arg1 = arg1 self.arg2 = arg2 class subclass(peer): def __init__(self, arg1, arg2): super(subclass, self).__init__(arg1, arg2, False) sub = subclass(1, 2) print("sub.arg1 is %r" % sub.arg1) When run with Python 3.8.10, 3.9.13, and 3.10.11, the result is: $ py -3.8 prot-test.py Traceback (most recent call last): File "prot-test.py", line 20, in <module> print("sub.arg1 is %r" % sub.arg1) AttributeError: 'subclass' object has no attribute 'arg1' On Python 3.11.9, 3.12.7, and 3.13.0, the result is: $ py -3.11 ../prot-test.py sub.arg1 is 1 Explicitly adding annotations to `peer` like `limitedarguments` didn't help.

Gregory Szorc - - Load All Authors

File last commit:

r49730:6000f5b2 default


                r53403:199b0e62

default

Download file

             python-hook-examples.py
        
                    26 lines
            
             | 594 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / contrib / python-hook-examples.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Alexander Solovyov
    
diffstat hook example

              r7917
            
      '''

        Benoit Boissinot
    
Change wording in example hook

              r7918
            
      Examples of useful python hooks for Mercurial.

        Alexander Solovyov
    
diffstat hook example

              r7917
            
      '''

        Pulkit Goyal
    
contrib: python-hook-examples use absolute_import

              r28562
            
      from mercurial import (

          patch,

          util,

      )

        Alexander Solovyov
    
diffstat hook example

              r7917
            
        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
        Alexander Solovyov
    
diffstat hook example

              r7917
            
      def diffstat(ui, repo, **kwargs):

        Augie Fackler
    
formating: upgrade to black 20.8b1...

              r46554
            
          """Example usage:

        Alexander Solovyov
    
diffstat hook example

              r7917
            
          [hooks]

          commit.diffstat = python:/path/to/this/file.py:diffstat

          changegroup.diffstat = python:/path/to/this/file.py:diffstat

        Augie Fackler
    
formating: upgrade to black 20.8b1...

              r46554
            
          """

        Alexander Solovyov
    
diffstat hook example

              r7917
            
          if kwargs.get('parent2'):

              return

          node = kwargs['node']

        Matt Mackall
    
misc: replace .parents()[0] with p1()

              r13878
            
          first = repo[node].p1().node()

        Alexander Solovyov
    
diffstat hook example

              r7917
            
          if 'url' in kwargs:

        Martin von Zweigbergk
    
repo: don't look up context for tip node if it's not needed...

              r39931
            
              last = repo.changelog.tip()

        Alexander Solovyov
    
diffstat hook example

              r7917
            
          else:

              last = node

          diff = patch.diff(repo, first, last)

          ui.write(patch.diffstat(util.iterlines(diff)))

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Alexander Solovyov diffstat hook example	r7917	'''
Benoit Boissinot Change wording in example hook	r7918	Examples of useful python hooks for Mercurial.
Alexander Solovyov diffstat hook example	r7917	'''
Pulkit Goyal contrib: python-hook-examples use absolute_import	r28562	from mercurial import (
		patch,
		util,
		)
Alexander Solovyov diffstat hook example	r7917
Augie Fackler formatting: blacken the codebase...	r43346
Alexander Solovyov diffstat hook example	r7917	def diffstat(ui, repo, **kwargs):
Augie Fackler formating: upgrade to black 20.8b1...	r46554	"""Example usage:
Alexander Solovyov diffstat hook example	r7917
		[hooks]
		commit.diffstat = python:/path/to/this/file.py:diffstat
		changegroup.diffstat = python:/path/to/this/file.py:diffstat
Augie Fackler formating: upgrade to black 20.8b1...	r46554	"""
Alexander Solovyov diffstat hook example	r7917	if kwargs.get('parent2'):
		return
		node = kwargs['node']
Matt Mackall misc: replace .parents()[0] with p1()	r13878	first = repo[node].p1().node()
Alexander Solovyov diffstat hook example	r7917	if 'url' in kwargs:
Martin von Zweigbergk repo: don't look up context for tip node if it's not needed...	r39931	last = repo.changelog.tip()
Alexander Solovyov diffstat hook example	r7917	else:
		last = node
		diff = patch.diff(repo, first, last)
		ui.write(patch.diffstat(util.iterlines(diff)))