upstream/mercurial-mirror Files · mercurial/__init__.py

interfaces: make the `peer` mixin not a Protocol to fix Python 3.10 failures...

interfaces: make the `peer` mixin not a Protocol to fix Python 3.10 failures I can't find any documentation on this, but it appears that Protocol class attributes don't get inherited in subclasses that explicitly subclass a Protocol until Python 3.11, which caused a ton of failures in CI on macOS and Windows (which both test using Python 3.9). The problem started with 1df97507c6b8, and typically manifested as most tests failing to access `ui` on various `peer` classes. Here's a short proof of concept: from __future__ import annotations from typing import ( Protocol, ) class peer(Protocol): limitedarguments: bool = False def __init__(self, arg1, arg2, remotehidden: bool = False) -> None: self.arg1 = arg1 self.arg2 = arg2 class subclass(peer): def __init__(self, arg1, arg2): super(subclass, self).__init__(arg1, arg2, False) sub = subclass(1, 2) print("sub.arg1 is %r" % sub.arg1) When run with Python 3.8.10, 3.9.13, and 3.10.11, the result is: $ py -3.8 prot-test.py Traceback (most recent call last): File "prot-test.py", line 20, in <module> print("sub.arg1 is %r" % sub.arg1) AttributeError: 'subclass' object has no attribute 'arg1' On Python 3.11.9, 3.12.7, and 3.13.0, the result is: $ py -3.11 ../prot-test.py sub.arg1 is 1 Explicitly adding annotations to `peer` like `limitedarguments` didn't help.

Matt Harbison - - Load All Authors

File last commit:

r52756:f4733654 default


                r53403:199b0e62

default

Download file

             __init__.py
        
                    13 lines
            
             | 412 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / __init__.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Gregory Szorc
    
mercurial: implement import hook for handling C/Python modules...

              r27220
            
      # __init__.py - Startup and module loading logic for Mercurial.

      #

      # Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

        Matt Harbison
    
typing: add `from __future__ import annotations` to most files...

              r52756
            
      from __future__ import annotations

        Gregory Szorc
    
mercurial: implement import hook for handling C/Python modules...

              r27220
            
        Siddharth Agarwal
    
demandimport: move to separate package...

              r32420
            
      # Allow 'from mercurial import demandimport' to keep working.

      import hgdemandimport

        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
        Siddharth Agarwal
    
demandimport: move to separate package...

              r32420
            
      demandimport = hgdemandimport

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Gregory Szorc mercurial: implement import hook for handling C/Python modules...	r27220	# __init__.py - Startup and module loading logic for Mercurial.
		#
		# Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>
		#
		# This software may be used and distributed according to the terms of the
		# GNU General Public License version 2 or any later version.

Matt Harbison typing: add `from __future__ import annotations` to most files...	r52756	from __future__ import annotations
Gregory Szorc mercurial: implement import hook for handling C/Python modules...	r27220
Siddharth Agarwal demandimport: move to separate package...	r32420	# Allow 'from mercurial import demandimport' to keep working.
		import hgdemandimport
Augie Fackler formatting: blacken the codebase...	r43346
Siddharth Agarwal demandimport: move to separate package...	r32420	demandimport = hgdemandimport