##// END OF EJS Templates
dirstateguard: use mktemp-like functionality to generate the backup filenames...
dirstateguard: use mktemp-like functionality to generate the backup filenames Previously these were generated with names like: `dirstate.backup.commit.<memory address of dirstateguard>` This could cause problems if two hg commands ran at the same time that used the same memory address, (which is apparently not uncommon if chg is involved), as memory addresses are not unique across processes. This issue was reported in the post-review comments on http://phab.mercurial-scm.org/D9952. Differential Revision: https://phab.mercurial-scm.org/D10504

File last commit:

r47777:222a42ac stable
r47777:222a42ac stable
Show More
dirstateguard.py
97 lines | 3.1 KiB | text/x-python | PythonLexer
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 # dirstateguard.py - class to allow restoring dirstate after failure
#
Raphaël Gomès
contributor: change mentions of mpm to olivia...
r47575 # Copyright 2005-2007 Olivia Mackall <olivia@selenic.com>
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 #
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
Kyle Lippincott
dirstateguard: use mktemp-like functionality to generate the backup filenames...
r47777 import os
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 from .i18n import _
from . import (
error,
Martin von Zweigbergk
narrow: call narrowspec.{save,restore,clear}backup directly...
r38905 narrowspec,
Kyle Lippincott
dirstateguard: use mktemp-like functionality to generate the backup filenames...
r47777 requirements,
Martin von Zweigbergk
util: add base class for transactional context managers...
r33790 util,
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 )
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345
Martin von Zweigbergk
util: add base class for transactional context managers...
r33790 class dirstateguard(util.transactional):
Augie Fackler
formating: upgrade to black 20.8b1...
r46554 """Restore dirstate at unexpected failure.
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488
At the construction, this class does:
- write current ``repo.dirstate`` out, and
- save ``.hg/dirstate`` into the backup file
This restores ``.hg/dirstate`` from backup file, if ``release()``
is invoked before ``close()``.
This just removes the backup file at ``close()`` before ``release()``.
Augie Fackler
formating: upgrade to black 20.8b1...
r46554 """
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488
def __init__(self, repo, name):
self._repo = repo
self._active = False
self._closed = False
Kyle Lippincott
dirstateguard: use mktemp-like functionality to generate the backup filenames...
r47777
def getname(prefix):
fd, fname = repo.vfs.mkstemp(prefix=prefix)
os.close(fd)
return fname
self._backupname = getname(b'dirstate.backup.%s.' % name)
Adam Simpkins
dirstate: update backup functions to take full backup filename...
r33440 repo.dirstate.savebackup(repo.currenttransaction(), self._backupname)
Kyle Lippincott
dirstateguard: use mktemp-like functionality to generate the backup filenames...
r47777 # Don't make this the empty string, things may join it with stuff and
# blindly try to unlink it, which could be bad.
self._narrowspecbackupname = None
if requirements.NARROW_REQUIREMENT in repo.requirements:
self._narrowspecbackupname = getname(
b'narrowspec.backup.%s.' % name
)
narrowspec.savewcbackup(repo, self._narrowspecbackupname)
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 self._active = True
def __del__(self):
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345 if self._active: # still active
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 # this may occur, even if this class is used correctly:
# for example, releasing other resources like transaction
# may raise exception before ``dirstateguard.release`` in
# ``release(tr, ....)``.
self._abort()
def close(self):
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345 if not self._active: # already inactivated
msg = (
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b"can't close already inactivated backup: %s")
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345 % self._backupname
)
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 raise error.Abort(msg)
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345 self._repo.dirstate.clearbackup(
self._repo.currenttransaction(), self._backupname
)
Kyle Lippincott
dirstateguard: use mktemp-like functionality to generate the backup filenames...
r47777 if self._narrowspecbackupname:
narrowspec.clearwcbackup(self._repo, self._narrowspecbackupname)
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 self._active = False
self._closed = True
def _abort(self):
Kyle Lippincott
dirstateguard: use mktemp-like functionality to generate the backup filenames...
r47777 if self._narrowspecbackupname:
narrowspec.restorewcbackup(self._repo, self._narrowspecbackupname)
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345 self._repo.dirstate.restorebackup(
self._repo.currenttransaction(), self._backupname
)
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 self._active = False
def release(self):
if not self._closed:
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345 if not self._active: # already inactivated
msg = (
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b"can't release already inactivated backup: %s")
Augie Fackler
style: run a patched black on a subset of mercurial...
r43345 % self._backupname
)
Augie Fackler
dirstateguard: move to new module so I can break some layering violations...
r30488 raise error.Abort(msg)
self._abort()