##// END OF EJS Templates
committablectx: move status-related methods closer together...
committablectx: move status-related methods closer together The modified()/added()/removed()/deleted() clearly belong very close to status(). I separated them in committablectx by the new p[12]copies() methods. This brings the close again. Sorry about the churn. Differential Revision: https://phab.mercurial-scm.org/D5996

File last commit:

r41916:1040d54e default
r41955:2ba96fca default
Show More
uncommit.py
256 lines | 8.7 KiB | text/x-python | PythonLexer
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # uncommit - undo the actions of a commit
#
# Copyright 2011 Peter Arrenbrecht <peter.arrenbrecht@gmail.com>
# Logilab SA <contact@logilab.fr>
# Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Patrick Mezard <patrick@mezard.eu>
# Copyright 2016 Facebook, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
"""uncommit part or all of a local changeset (EXPERIMENTAL)
This command undoes the effect of a local commit, returning the affected
files to their uncommitted state. This means that files modified, added or
removed in the changeset will be left unchanged, and so will remain modified,
added and removed in the working directory.
"""
from __future__ import absolute_import
from mercurial.i18n import _
from mercurial import (
Pulkit Goyal
uncommit: don't allow bare uncommit on dirty working directory...
r34285 cmdutil,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 commands,
context,
Martin von Zweigbergk
unamend: import "copies" module as "copiesmod" to avoid shadowing...
r41370 copies as copiesmod,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 error,
node,
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 obsutil,
Pulkit Goyal
py3: handle keyword arguments in hgext/uncommit.py...
r35005 pycompat,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 registrar,
Pulkit Goyal
rewriteutil: use precheck() in uncommit and amend commands...
r35244 rewriteutil,
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 scmutil,
)
cmdtable = {}
command = registrar.command(cmdtable)
Boris Feld
configitems: register the 'experimental.uncommitondirtywdir' config
r34759 configtable = {}
configitem = registrar.configitem(configtable)
configitem('experimental', 'uncommitondirtywdir',
default=False,
)
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 configitem('experimental', 'uncommit.keep',
default=False,
)
Boris Feld
configitems: register the 'experimental.uncommitondirtywdir' config
r34759
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified.
testedwith = 'ships-with-hg-core'
Martin von Zweigbergk
uncommit: simplify condition for keeping commit...
r36992 def _commitfiltered(repo, ctx, match, keepcommit):
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 """Recommit ctx with changed files not in match. Return the new
node identifier, or None if nothing changed.
"""
base = ctx.p1()
# ctx
initialfiles = set(ctx.files())
exclude = set(f for f in initialfiles if match(f))
# No files matched commit, so nothing excluded
if not exclude:
return None
# return the p1 so that we don't create an obsmarker later
Martin von Zweigbergk
uncommit: simplify condition for keeping commit...
r36992 if not keepcommit:
Martin von Zweigbergk
cleanup: use p1() and p2() instead of parents()[0] and parents()[1]...
r41442 return ctx.p1().node()
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Martin von Zweigbergk
uncommit: inform user if the commit is empty after uncommit...
r41911 files = (initialfiles - exclude)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 # Filter copies
Martin von Zweigbergk
unamend: import "copies" module as "copiesmod" to avoid shadowing...
r41370 copied = copiesmod.pathcopies(base, ctx)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 copied = dict((dst, src) for dst, src in copied.iteritems()
if dst in files)
def filectxfn(repo, memctx, path, contentctx=ctx, redirect=()):
if path not in contentctx:
return None
fctx = contentctx[path]
Martin von Zweigbergk
memfilectx: make changectx argument mandatory in constructor (API)...
r35401 mctx = context.memfilectx(repo, memctx, fctx.path(), fctx.data(),
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 fctx.islink(),
fctx.isexec(),
copied=copied.get(path))
return mctx
Martin von Zweigbergk
uncommit: inform user if the commit is empty after uncommit...
r41911 if not files:
repo.ui.status(_("note: keeping empty commit\n"))
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 new = context.memctx(repo,
parents=[base.node(), node.nullid],
text=ctx.description(),
files=files,
filectxfn=filectxfn,
user=ctx.user(),
date=ctx.date(),
extra=ctx.extra())
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 return repo.commitctx(new)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
Martin von Zweigbergk
unamend: fix unamending of renamed rename...
r41372 def _fixdirstate(repo, oldctx, newctx, match=None):
Pulkit Goyal
uncommit: unify functions _uncommitdirstate and _unamenddirstate to one...
r35178 """ fix the dirstate after switching the working directory from oldctx to
newctx which can be result of either unamend or uncommit.
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 """
ds = repo.dirstate
Martin von Zweigbergk
uncommit: set dirstateparents from within _fixdirstate()...
r41373 ds.setparents(newctx.node(), node.nullid)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 copies = dict(ds.copies())
Martin von Zweigbergk
unamend: fix unamending of renamed rename...
r41372 s = newctx.status(oldctx, match=match)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 for f in s.modified:
if ds[f] == 'r':
# modified + removed -> removed
continue
ds.normallookup(f)
for f in s.added:
if ds[f] == 'r':
# added + removed -> unknown
ds.drop(f)
elif ds[f] != 'a':
ds.add(f)
for f in s.removed:
if ds[f] == 'a':
# removed + added -> normal
ds.normallookup(f)
elif ds[f] != 'r':
ds.remove(f)
# Merge old parent and old working dir copies
Martin von Zweigbergk
unamend: fix unamending of renamed rename...
r41372 oldcopies = copiesmod.pathcopies(newctx, oldctx, match)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 oldcopies.update(copies)
copies = dict((dst, oldcopies.get(src, src))
for dst, src in oldcopies.iteritems())
# Adjust the dirstate copies
for dst, src in copies.iteritems():
Pulkit Goyal
uncommit: unify functions _uncommitdirstate and _unamenddirstate to one...
r35178 if (src not in newctx or dst in newctx or ds[dst] != 'a'):
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 src = None
ds.copy(src, dst)
@command('uncommit',
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 [('', 'keep', None, _('allow an empty commit after uncommiting')),
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 ] + commands.walkopts,
rdamazio@google.com
help: assigning categories to existing commands...
r40329 _('[OPTION]... [FILE]...'),
helpcategory=command.CATEGORY_CHANGE_MANAGEMENT)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 def uncommit(ui, repo, *pats, **opts):
"""uncommit part or all of a local changeset
This command undoes the effect of a local commit, returning the affected
files to their uncommitted state. This means that files modified or
deleted in the changeset will be left unchanged, and so will remain
modified in the working directory.
Martin von Zweigbergk
uncommit: document when the commit will be pruned...
r36991
If no files are specified, the commit will be pruned, unless --keep is
given.
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 """
Pulkit Goyal
py3: handle keyword arguments in hgext/uncommit.py...
r35005 opts = pycompat.byteskwargs(opts)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193
with repo.wlock(), repo.lock():
Pulkit Goyal
uncommit: add an experimental.uncommitondirtywdir config...
r34286 if not pats and not repo.ui.configbool('experimental',
Martin von Zweigbergk
uncommit: fix unaligned indentation...
r36965 'uncommitondirtywdir'):
Pulkit Goyal
uncommit: don't allow bare uncommit on dirty working directory...
r34285 cmdutil.bailifchanged(repo)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 old = repo['.']
Pulkit Goyal
rewriteutil: use precheck() in uncommit and amend commands...
r35244 rewriteutil.precheck(repo, [old.rev()], 'uncommit')
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 if len(old.parents()) > 1:
raise error.Abort(_("cannot uncommit merge changeset"))
with repo.transaction('uncommit'):
match = scmutil.match(old, pats, opts)
Martin von Zweigbergk
uncommit: add config option to keep commit by default...
r41916 keepcommit = pats
if not keepcommit:
if opts.get('keep') is not None:
keepcommit = opts.get('keep')
else:
keepcommit = ui.configbool('experimental', 'uncommit.keep')
Martin von Zweigbergk
uncommit: simplify condition for keeping commit...
r36992 newid = _commitfiltered(repo, old, match, keepcommit)
Pulkit Goyal
uncommit: move fb-extension to core which uncommits a changeset...
r34193 if newid is None:
ui.status(_("nothing to uncommit\n"))
return 1
mapping = {}
if newid != old.p1().node():
# Move local changes on filtered changeset
mapping[old.node()] = (newid,)
else:
# Fully removed the old commit
mapping[old.node()] = ()
with repo.dirstate.parentchange():
Martin von Zweigbergk
unamend: fix unamending of renamed rename...
r41372 _fixdirstate(repo, old, repo[newid], match)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Martin von Zweigbergk
uncommit: mark old node obsolete after updating dirstate...
r41371 scmutil.cleanupnodes(repo, mapping, 'uncommit', fixphase=True)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 def predecessormarkers(ctx):
"""yields the obsolete markers marking the given changeset as a successor"""
for data in ctx.repo().obsstore.predecessors.get(ctx.node(), ()):
yield obsutil.marker(ctx.repo(), data)
Rodrigo Damazio
help: adding a proper declaration for shortlist/basic commands (API)...
r40331 @command('unamend', [], helpcategory=command.CATEGORY_CHANGE_MANAGEMENT,
helpbasic=True)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 def unamend(ui, repo, **opts):
Martin von Zweigbergk
unamend: fix command summary line...
r35827 """undo the most recent amend operation on a current changeset
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
This command will roll back to the previous version of a changeset,
leaving working directory in state in which it was before running
`hg amend` (e.g. files modified as part of an amend will be
marked as modified `hg status`)
"""
unfi = repo.unfiltered()
Pulkit Goyal
unamend: drop unused vars, query after taking lock, use ctx.hex() for extras...
r35201 with repo.wlock(), repo.lock(), repo.transaction('unamend'):
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Pulkit Goyal
unamend: drop unused vars, query after taking lock, use ctx.hex() for extras...
r35201 # identify the commit from which to unamend
curctx = repo['.']
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
Martin von Zweigbergk
unamend: allow unamending if allowunstable is set...
r35451 rewriteutil.precheck(repo, [curctx.rev()], 'unamend')
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
# identify the commit to which to unamend
markers = list(predecessormarkers(curctx))
if len(markers) != 1:
e = _("changeset must have one predecessor, found %i predecessors")
raise error.Abort(e % len(markers))
prednode = markers[0].prednode()
predctx = unfi[prednode]
# add an extra so that we get a new hash
# note: allowing unamend to undo an unamend is an intentional feature
extras = predctx.extra()
Pulkit Goyal
unamend: drop unused vars, query after taking lock, use ctx.hex() for extras...
r35201 extras['unamend_source'] = curctx.hex()
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
def filectxfn(repo, ctx_, path):
try:
return predctx.filectx(path)
except KeyError:
return None
# Make a new commit same as predctx
newctx = context.memctx(repo,
parents=(predctx.p1(), predctx.p2()),
text=predctx.description(),
files=predctx.files(),
filectxfn=filectxfn,
user=predctx.user(),
date=predctx.date(),
extra=extras)
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 newprednode = repo.commitctx(newctx)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177 newpredctx = repo[newprednode]
dirstate = repo.dirstate
with dirstate.parentchange():
Martin von Zweigbergk
unamend: fix unamending of renamed rename...
r41372 _fixdirstate(repo, curctx, newpredctx)
Pulkit Goyal
unamend: move fb extension unamend to core...
r35177
mapping = {curctx.node(): (newprednode,)}
Martin von Zweigbergk
scmutil: make cleanupnodes optionally also fix the phase...
r38442 scmutil.cleanupnodes(repo, mapping, 'unamend', fixphase=True)