upstream/mercurial-mirror Files · mercurial/__init__.py

interfaces: mark a few dirstate methods abstract...

interfaces: mark a few dirstate methods abstract I'm not sure what's going on here, but when enabling pytype checking on this package, it spits out the following errors: File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 136, in changing_parents: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 145, in changing_files: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ I guess technically that's true, because these methods only have a doc comment, and don't explicitly return something or unconditionally raise an error. The strange thing is that both before and after this change, the *.pyi file that is generated is unchanged, and contains: def changing_files(self, repo) -> contextlib._GeneratorContextManager: ... def changing_parents(self, repo) -> contextlib._GeneratorContextManager: ... I'm not sure if the `@abstractmethod` should be the most inner or most outer decoration. We'll roll the dice with being the innermost, because that's how `@abstractproperty` says it should be used in conjunction with `@property`. We should probably make all of the methods without an actual body abstract, like was done for some `mercurial.wireprototypes` classes in fd200f5bcaea. But let's hold off for now and do that enmass later.

Matt Harbison - - Load All Authors

File last commit:

r52756:f4733654 default


                r53328:2c8c46c3

default

Download file

             __init__.py
        
                    13 lines
            
             | 412 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / mercurial / __init__.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Gregory Szorc
    
mercurial: implement import hook for handling C/Python modules...

              r27220
            
      # __init__.py - Startup and module loading logic for Mercurial.

      #

      # Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

        Matt Harbison
    
typing: add `from __future__ import annotations` to most files...

              r52756
            
      from __future__ import annotations

        Gregory Szorc
    
mercurial: implement import hook for handling C/Python modules...

              r27220
            
        Siddharth Agarwal
    
demandimport: move to separate package...

              r32420
            
      # Allow 'from mercurial import demandimport' to keep working.

      import hgdemandimport

        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
        Siddharth Agarwal
    
demandimport: move to separate package...

              r32420
            
      demandimport = hgdemandimport

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Gregory Szorc mercurial: implement import hook for handling C/Python modules...	r27220	# __init__.py - Startup and module loading logic for Mercurial.
		#
		# Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>
		#
		# This software may be used and distributed according to the terms of the
		# GNU General Public License version 2 or any later version.

Matt Harbison typing: add `from __future__ import annotations` to most files...	r52756	from __future__ import annotations
Gregory Szorc mercurial: implement import hook for handling C/Python modules...	r27220
Siddharth Agarwal demandimport: move to separate package...	r32420	# Allow 'from mercurial import demandimport' to keep working.
		import hgdemandimport
Augie Fackler formatting: blacken the codebase...	r43346
Siddharth Agarwal demandimport: move to separate package...	r32420	demandimport = hgdemandimport