upstream/mercurial-mirror Files · mercurial/compat.h

interfaces: mark a few dirstate methods abstract...

interfaces: mark a few dirstate methods abstract I'm not sure what's going on here, but when enabling pytype checking on this package, it spits out the following errors: File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 136, in changing_parents: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ File "/mnt/c/Users/Matt/hg/mercurial/interfaces/dirstate.py", line 145, in changing_files: bad return type [bad-return-type] Expected: Iterator Actually returned: None Attributes of protocol Iterator are not implemented on None: __next__ I guess technically that's true, because these methods only have a doc comment, and don't explicitly return something or unconditionally raise an error. The strange thing is that both before and after this change, the *.pyi file that is generated is unchanged, and contains: def changing_files(self, repo) -> contextlib._GeneratorContextManager: ... def changing_parents(self, repo) -> contextlib._GeneratorContextManager: ... I'm not sure if the `@abstractmethod` should be the most inner or most outer decoration. We'll roll the dice with being the innermost, because that's how `@abstractproperty` says it should be used in conjunction with `@property`. We should probably make all of the methods without an actual body abstract, like was done for some `mercurial.wireprototypes` classes in fd200f5bcaea. But let's hold off for now and do that enmass later.

David Demelier - - Load All Authors

File last commit:

r49095:d8690805 default


                r53328:2c8c46c3

default

Download file

             compat.h
        
                    58 lines
            
             | 1.0 KiB
            
                | text/x-c
            
             |
                CLexer
            
             / mercurial / compat.h
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        David Demelier
    
hg: remove reserved identifiers...

              r49095
            
      #ifndef HG_COMPAT_H

      #define HG_COMPAT_H

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      #ifdef _WIN32

      #ifdef _MSC_VER

        Matt Harbison
    
cext: fix warnings when building for py3 on Windows...

              r39646
            
      #if _MSC_VER < 1900

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      /* msvc 6.0 has problems */

      #define inline __inline

        Maciej Fijalkowski
    
compat: provide a declaration of ssize_t, for MS windows

              r29521
            
      #if defined(_WIN64)

      typedef __int64 ssize_t;

        Yuya Nishihara
    
encoding: add function to test if a str consists of ASCII characters...

              r33927
            
      typedef unsigned __int64 uintptr_t;

        Maciej Fijalkowski
    
compat: provide a declaration of ssize_t, for MS windows

              r29521
            
      #else

        Yuya Nishihara
    
compat: define ssize_t as int on 32bit Windows, silences C4142 warning...

              r29549
            
      typedef int ssize_t;

        Yuya Nishihara
    
encoding: add function to test if a str consists of ASCII characters...

              r33927
            
      typedef unsigned int uintptr_t;

        Maciej Fijalkowski
    
compat: provide a declaration of ssize_t, for MS windows

              r29521
            
      #endif

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      typedef signed char int8_t;

      typedef short int16_t;

      typedef long int32_t;

      typedef __int64 int64_t;

      typedef unsigned char uint8_t;

      typedef unsigned short uint16_t;

      typedef unsigned long uint32_t;

      typedef unsigned __int64 uint64_t;

      #else

        Matt Harbison
    
cext: fix warnings when building for py3 on Windows...

              r39646
            
      /* VC++ 14 */

      #include <stdint.h>

      #if defined(_WIN64)

      typedef __int64 ssize_t;

      #else

      typedef int ssize_t;

      #endif

      #endif /* _MSC_VER < 1900 */

      #else

      /* not msvc */

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      #include <stdint.h>

      #endif

      #else

      /* not windows */

      #include <sys/types.h>

      #if defined __BEOS__ && !defined __HAIKU__

      #include <ByteOrder.h>

      #else

      #include <arpa/inet.h>

      #endif

      #include <inttypes.h>

      #endif

      #if defined __hpux || defined __SUNPRO_C || defined _AIX

      #define inline

      #endif

      #ifdef __linux

      #define inline __inline

      #endif

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

David Demelier hg: remove reserved identifiers...	r49095	#ifndef HG_COMPAT_H
		#define HG_COMPAT_H
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444
		#ifdef _WIN32
		#ifdef _MSC_VER
Matt Harbison cext: fix warnings when building for py3 on Windows...	r39646	#if _MSC_VER < 1900
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444	/* msvc 6.0 has problems */
		#define inline __inline
Maciej Fijalkowski compat: provide a declaration of ssize_t, for MS windows	r29521	#if defined(_WIN64)
		typedef __int64 ssize_t;
Yuya Nishihara encoding: add function to test if a str consists of ASCII characters...	r33927	typedef unsigned __int64 uintptr_t;
Maciej Fijalkowski compat: provide a declaration of ssize_t, for MS windows	r29521	#else
Yuya Nishihara compat: define ssize_t as int on 32bit Windows, silences C4142 warning...	r29549	typedef int ssize_t;
Yuya Nishihara encoding: add function to test if a str consists of ASCII characters...	r33927	typedef unsigned int uintptr_t;
Maciej Fijalkowski compat: provide a declaration of ssize_t, for MS windows	r29521	#endif
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444	typedef signed char int8_t;
		typedef short int16_t;
		typedef long int32_t;
		typedef __int64 int64_t;
		typedef unsigned char uint8_t;
		typedef unsigned short uint16_t;
		typedef unsigned long uint32_t;
		typedef unsigned __int64 uint64_t;
		#else
Matt Harbison cext: fix warnings when building for py3 on Windows...	r39646	/* VC++ 14 */
		#include <stdint.h>

		#if defined(_WIN64)
		typedef __int64 ssize_t;
		#else
		typedef int ssize_t;
		#endif
		#endif /* _MSC_VER < 1900 */

		#else
		/* not msvc */
Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444	#include <stdint.h>
		#endif
		#else
		/* not windows */
		#include <sys/types.h>
		#if defined __BEOS__ && !defined __HAIKU__
		#include <ByteOrder.h>
		#else
		#include <arpa/inet.h>
		#endif
		#include <inttypes.h>
		#endif

		#if defined __hpux \|\| defined __SUNPRO_C \|\| defined _AIX
		#define inline
		#endif

		#ifdef __linux
		#define inline __inline
		#endif

		#endif