upstream/mercurial-mirror Files · tests/test-check-commit.t

sslutil: require TLS 1.1+ when supported...

sslutil: require TLS 1.1+ when supported Currently, Mercurial will use TLS 1.0 or newer when connecting to remote servers, selecting the highest TLS version supported by both peers. On older Pythons, only TLS 1.0 is available. On newer Pythons, TLS 1.1 and 1.2 should be available. Security professionals recommend avoiding TLS 1.0 if possible. PCI DSS 3.1 "strongly encourages" the use of TLS 1.2. Known attacks like BEAST and POODLE exist against TLS 1.0 (although mitigations are available and properly configured servers aren't vulnerable). I asked Eric Rescorla - Mozilla's resident crypto expert - whether Mercurial should drop support for TLS 1.0. His response was "if you can get away with it." Essentially, a number of servers on the Internet don't support TLS 1.1+. This is why web browsers continue to support TLS 1.0 despite desires from security experts. This patch changes Mercurial's default behavior on modern Python versions to require TLS 1.1+, thus avoiding known security issues with TLS 1.0 and making Mercurial more secure by default. Rather than drop TLS 1.0 support wholesale, we still allow TLS 1.0 to be used if configured. This is a compromise solution - ideally we'd disallow TLS 1.0. However, since we're not sure how many Mercurial servers don't support TLS 1.1+ and we're not sure how much user inconvenience this change will bring, I think it is prudent to ship an escape hatch that still allows usage of TLS 1.0. In the default case our users get better security. In the worst case, they are no worse off than before this patch. This patch has no effect when running on Python versions that don't support TLS 1.1+. As the added test shows, connecting to a server that doesn't support TLS 1.1+ will display a warning message with a link to our wiki, where we can guide people to configure their client to allow less secure connections.

timeless - - Load All Authors

File last commit:

r29219:3c9066ed default


                r29560:303e9300

default

Download file

             test-check-commit.t
        
                    21 lines
            
             | 578 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-commit.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
      #require test-repo

      Enable obsolescence to avoid the warning issue when obsmarker are found

        timeless
    
tests: silence test-repo obsolete warning...

              r29219
            
        $ . "$TESTDIR/helpers-testrepo.sh"

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
      Go back in the hg repo

        $ cd $TESTDIR/..

        Matt Mackall
    
tests: run check-commit on secret changes too

              r27756
            
        $ for node in `hg log --rev 'not public() and ::.' --template '{node|short}\n'`; do

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
        >    hg export $node | contrib/check-commit > ${TESTTMP}/check-commit.out

        >    if [ $? -ne 0 ]; then

        timeless
    
tests: minor grammar change for check-commit

              r28293
            
        >        echo "Revision $node does not comply with rules"

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
        >        echo '------------------------------------------------------'

        >        cat ${TESTTMP}/check-commit.out

        >        echo

        >   fi

        > done

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	#require test-repo

		Enable obsolescence to avoid the warning issue when obsmarker are found

timeless tests: silence test-repo obsolete warning...	r29219	$ . "$TESTDIR/helpers-testrepo.sh"
Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368
		Go back in the hg repo

		$ cd $TESTDIR/..

Matt Mackall tests: run check-commit on secret changes too	r27756	$ for node in `hg log --rev 'not public() and ::.' --template '{node\|short}\n'`; do
Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	> hg export $node \| contrib/check-commit > ${TESTTMP}/check-commit.out
		> if [ $? -ne 0 ]; then
timeless tests: minor grammar change for check-commit	r28293	> echo "Revision $node does not comply with rules"
Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	> echo '------------------------------------------------------'
		> cat ${TESTTMP}/check-commit.out
		> echo
		> fi
		> done