upstream/mercurial-mirror Files · tests/test-chg.t

sslutil: require TLS 1.1+ when supported...

sslutil: require TLS 1.1+ when supported Currently, Mercurial will use TLS 1.0 or newer when connecting to remote servers, selecting the highest TLS version supported by both peers. On older Pythons, only TLS 1.0 is available. On newer Pythons, TLS 1.1 and 1.2 should be available. Security professionals recommend avoiding TLS 1.0 if possible. PCI DSS 3.1 "strongly encourages" the use of TLS 1.2. Known attacks like BEAST and POODLE exist against TLS 1.0 (although mitigations are available and properly configured servers aren't vulnerable). I asked Eric Rescorla - Mozilla's resident crypto expert - whether Mercurial should drop support for TLS 1.0. His response was "if you can get away with it." Essentially, a number of servers on the Internet don't support TLS 1.1+. This is why web browsers continue to support TLS 1.0 despite desires from security experts. This patch changes Mercurial's default behavior on modern Python versions to require TLS 1.1+, thus avoiding known security issues with TLS 1.0 and making Mercurial more secure by default. Rather than drop TLS 1.0 support wholesale, we still allow TLS 1.0 to be used if configured. This is a compromise solution - ideally we'd disallow TLS 1.0. However, since we're not sure how many Mercurial servers don't support TLS 1.1+ and we're not sure how much user inconvenience this change will bring, I think it is prudent to ship an escape hatch that still allows usage of TLS 1.0. In the default case our users get better security. In the worst case, they are no worse off than before this patch. This patch has no effect when running on Python versions that don't support TLS 1.1+. As the added test shows, connecting to a server that doesn't support TLS 1.1+ will display a warning message with a link to our wiki, where we can guide people to configure their client to allow less secure connections.

Jun Wu - - Load All Authors

File last commit:

r29343:e095b9e7 default


                r29560:303e9300

default

Download file

             test-chg.t
        
                    86 lines
            
             | 2.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-chg.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Yuya Nishihara
    
test-chg: run only with chg...

              r29274
            
      #require chg

        Yuya Nishihara
    
test-chg: add basic tests for server lifecycle...

              r29275
            
        $ cp $HGRCPATH $HGRCPATH.orig

        Jun Wu
    
chgserver: handle ParseError during validate...

              r28516
            
      init repo

        Yuya Nishihara
    
test-chg: run only with chg...

              r29274
            
        $ chg init foo

        Jun Wu
    
chgserver: handle ParseError during validate...

              r28516
            
        $ cd foo

      ill-formed config

        Yuya Nishihara
    
test-chg: run only with chg...

              r29274
            
        $ chg status

        Jun Wu
    
chgserver: handle ParseError during validate...

              r28516
            
        $ echo '=brokenconfig' >> $HGRCPATH

        Yuya Nishihara
    
test-chg: run only with chg...

              r29274
            
        $ chg status

        Jun Wu
    
chgserver: handle ParseError during validate...

              r28516
            
        hg: parse error at * (glob)

        [255]

        Jun Wu
    
chgserver: remove _clearenvaliases...

              r29088
            
        Yuya Nishihara
    
test-chg: add basic tests for server lifecycle...

              r29275
            
        $ cp $HGRCPATH.orig $HGRCPATH

        $ cd ..

      server lifecycle

      ----------------

      chg server should be restarted on code change, and old server will shut down

      automatically. In this test, we use the following time parameters:

       - "sleep 1" to make mtime different

       - "sleep 2" to notice mtime change (polling interval is 1 sec)

      set up repository with an extension:

        $ chg init extreload

        $ cd extreload

        $ touch dummyext.py

        $ cat <<EOF >> .hg/hgrc

        > [extensions]

        > dummyext = dummyext.py

        > EOF

      isolate socket directory for stable result:

        $ OLDCHGSOCKNAME=$CHGSOCKNAME

        $ mkdir chgsock

        $ CHGSOCKNAME=`pwd`/chgsock/server

      warm up server:

        $ CHGDEBUG= chg log 2>&1 | egrep 'instruction|start'

        chg: debug: start cmdserver at $TESTTMP/extreload/chgsock/server

      new server should be started if extension modified:

        $ sleep 1

        $ touch dummyext.py

        $ CHGDEBUG= chg log 2>&1 | egrep 'instruction|start'

        chg: debug: instruction: unlink $TESTTMP/extreload/chgsock/server-* (glob)

        chg: debug: instruction: reconnect

        chg: debug: start cmdserver at $TESTTMP/extreload/chgsock/server

      old server will shut down, while new server should still be reachable:

        $ sleep 2

        $ CHGDEBUG= chg log 2>&1 | (egrep 'instruction|start' || true)

      socket file should never be unlinked by old server:

      (simulates unowned socket by updating mtime, which makes sure server exits

      at polling cycle)

        $ ls chgsock/server-*

        chgsock/server-* (glob)

        $ touch chgsock/server-*

        $ sleep 2

        $ ls chgsock/server-*

        chgsock/server-* (glob)

      since no server is reachable from socket file, new server should be started:

      (this test makes sure that old server shut down automatically)

        $ CHGDEBUG= chg log 2>&1 | egrep 'instruction|start'

        chg: debug: start cmdserver at $TESTTMP/extreload/chgsock/server

      shut down servers and restore environment:

        $ rm -R chgsock

        $ CHGSOCKNAME=$OLDCHGSOCKNAME

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Yuya Nishihara test-chg: run only with chg...	r29274	#require chg

Yuya Nishihara test-chg: add basic tests for server lifecycle...	r29275	$ cp $HGRCPATH $HGRCPATH.orig

Jun Wu chgserver: handle ParseError during validate...	r28516	init repo

Yuya Nishihara test-chg: run only with chg...	r29274	$ chg init foo
Jun Wu chgserver: handle ParseError during validate...	r28516	$ cd foo

		ill-formed config

Yuya Nishihara test-chg: run only with chg...	r29274	$ chg status
Jun Wu chgserver: handle ParseError during validate...	r28516	$ echo '=brokenconfig' >> $HGRCPATH
Yuya Nishihara test-chg: run only with chg...	r29274	$ chg status
Jun Wu chgserver: handle ParseError during validate...	r28516	hg: parse error at * (glob)
		[255]
Jun Wu chgserver: remove _clearenvaliases...	r29088
Yuya Nishihara test-chg: add basic tests for server lifecycle...	r29275	$ cp $HGRCPATH.orig $HGRCPATH
		$ cd ..

		server lifecycle
		----------------

		chg server should be restarted on code change, and old server will shut down
		automatically. In this test, we use the following time parameters:

		- "sleep 1" to make mtime different
		- "sleep 2" to notice mtime change (polling interval is 1 sec)

		set up repository with an extension:

		$ chg init extreload
		$ cd extreload
		$ touch dummyext.py
		$ cat <<EOF >> .hg/hgrc
		> [extensions]
		> dummyext = dummyext.py
		> EOF

		isolate socket directory for stable result:

		$ OLDCHGSOCKNAME=$CHGSOCKNAME
		$ mkdir chgsock
		$ CHGSOCKNAME=`pwd`/chgsock/server

		warm up server:

		$ CHGDEBUG= chg log 2>&1 \| egrep 'instruction\|start'
		chg: debug: start cmdserver at $TESTTMP/extreload/chgsock/server

		new server should be started if extension modified:

		$ sleep 1
		$ touch dummyext.py
		$ CHGDEBUG= chg log 2>&1 \| egrep 'instruction\|start'
		chg: debug: instruction: unlink $TESTTMP/extreload/chgsock/server-* (glob)
		chg: debug: instruction: reconnect
		chg: debug: start cmdserver at $TESTTMP/extreload/chgsock/server

		old server will shut down, while new server should still be reachable:

		$ sleep 2
		$ CHGDEBUG= chg log 2>&1 \| (egrep 'instruction\|start' \|\| true)

		socket file should never be unlinked by old server:
		(simulates unowned socket by updating mtime, which makes sure server exits
		at polling cycle)

		$ ls chgsock/server-*
		chgsock/server-* (glob)
		$ touch chgsock/server-*
		$ sleep 2
		$ ls chgsock/server-*
		chgsock/server-* (glob)

		since no server is reachable from socket file, new server should be started:
		(this test makes sure that old server shut down automatically)

		$ CHGDEBUG= chg log 2>&1 \| egrep 'instruction\|start'
		chg: debug: start cmdserver at $TESTTMP/extreload/chgsock/server

		shut down servers and restore environment:

		$ rm -R chgsock
		$ CHGSOCKNAME=$OLDCHGSOCKNAME
		$ cd ..