upstream/mercurial-mirror Files · tests/test-push-validation.t

sslutil: require TLS 1.1+ when supported...

sslutil: require TLS 1.1+ when supported Currently, Mercurial will use TLS 1.0 or newer when connecting to remote servers, selecting the highest TLS version supported by both peers. On older Pythons, only TLS 1.0 is available. On newer Pythons, TLS 1.1 and 1.2 should be available. Security professionals recommend avoiding TLS 1.0 if possible. PCI DSS 3.1 "strongly encourages" the use of TLS 1.2. Known attacks like BEAST and POODLE exist against TLS 1.0 (although mitigations are available and properly configured servers aren't vulnerable). I asked Eric Rescorla - Mozilla's resident crypto expert - whether Mercurial should drop support for TLS 1.0. His response was "if you can get away with it." Essentially, a number of servers on the Internet don't support TLS 1.1+. This is why web browsers continue to support TLS 1.0 despite desires from security experts. This patch changes Mercurial's default behavior on modern Python versions to require TLS 1.1+, thus avoiding known security issues with TLS 1.0 and making Mercurial more secure by default. Rather than drop TLS 1.0 support wholesale, we still allow TLS 1.0 to be used if configured. This is a compromise solution - ideally we'd disallow TLS 1.0. However, since we're not sure how many Mercurial servers don't support TLS 1.1+ and we're not sure how much user inconvenience this change will bring, I think it is prudent to ship an escape hatch that still allows usage of TLS 1.0. In the default case our users get better security. In the worst case, they are no worse off than before this patch. This patch has no effect when running on Python versions that don't support TLS 1.1+. As the added test shows, connecting to a server that doesn't support TLS 1.1+ will display a warning message with a link to our wiki, where we can guide people to configure their client to allow less secure connections.

Martin von Zweigbergk - - Load All Authors

File last commit:

r28114:2a03a365 default


                r29560:303e9300

default

Download file

             test-push-validation.t
        
                    92 lines
            
             | 1.9 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-push-validation.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Adrian Buehlmann
    
combine tests

              r12279
            
        $ hg init test

        $ cd test

        $ cat > .hg/hgrc <<EOF

        > [server]

        > validate=1

        > EOF

        $ echo alpha > alpha

        $ echo beta > beta

        $ hg addr

        adding alpha

        adding beta

        $ hg ci -m 1

        $ cd ..

        $ hg clone test test-clone

        updating to branch default

        2 files updated, 0 files merged, 0 files removed, 0 files unresolved

        Sune Foldager
    
validate: check for spurious incoming filelog entries...

              r18422
            
      Test spurious filelog entries:

        Adrian Buehlmann
    
combine tests

              r12279
            
        $ cd test-clone

        Sune Foldager
    
validate: check for spurious incoming filelog entries...

              r18422
            
        $ echo blah >> beta

        $ cp .hg/store/data/beta.i tmp1

        $ hg ci -m 2

        $ cp .hg/store/data/beta.i tmp2

        $ hg -q rollback

        $ mv tmp2 .hg/store/data/beta.i

        $ echo blah >> beta

        $ hg ci -m '2 (corrupt)'

      Expected to fail:

        $ hg verify

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

         beta@1: dddc47b3ba30 not in manifests

        2 files, 2 changesets, 4 total revisions

        1 integrity errors encountered!

        (first damaged changeset appears to be 1)

        [1]

        $ hg push

        Mads Kiilerich
    
tests: fix for windows - slashes and no serve

              r18506
            
        pushing to $TESTTMP/test (glob)

        Sune Foldager
    
validate: check for spurious incoming filelog entries...

              r18422
            
        searching for changes

        adding changesets

        adding manifests

        adding file changes

        transaction abort!

        rollback completed

        abort: received spurious file revlog entry

        [255]

        $ hg -q rollback

        $ mv tmp1 .hg/store/data/beta.i

        $ echo beta > beta

      Test missing filelog entries:

        Adrian Buehlmann
    
combine tests

              r12279
            
        $ cp .hg/store/data/beta.i tmp

        $ echo blah >> beta

        $ hg ci -m '2 (corrupt)'

        $ mv tmp .hg/store/data/beta.i

      Expected to fail:

        $ hg verify

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

        Martin von Zweigbergk
    
verify: use similar language for missing manifest and file revisions...

              r28114
            
         beta@1: manifest refers to unknown revision dddc47b3ba30

        Adrian Buehlmann
    
combine tests

              r12279
            
        2 files, 2 changesets, 2 total revisions

        1 integrity errors encountered!

        (first damaged changeset appears to be 1)

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [1]

        Adrian Buehlmann
    
combine tests

              r12279
            
        $ hg push

        Mads Kiilerich
    
tests: make (glob) on windows accept \ instead of /...

              r15447
            
        pushing to $TESTTMP/test (glob)

        Adrian Buehlmann
    
combine tests

              r12279
            
        searching for changes

        adding changesets

        adding manifests

        adding file changes

        transaction abort!

        rollback completed

        abort: missing file data for beta:dddc47b3ba30e54484720ce0f4f768a0f4b6efb9 - run hg verify

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Adrian Buehlmann
    
combine tests

              r12279
            
        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Adrian Buehlmann combine tests	r12279	$ hg init test
		$ cd test

		$ cat > .hg/hgrc <<EOF
		> [server]
		> validate=1
		> EOF

		$ echo alpha > alpha
		$ echo beta > beta
		$ hg addr
		adding alpha
		adding beta
		$ hg ci -m 1

		$ cd ..
		$ hg clone test test-clone
		updating to branch default
		2 files updated, 0 files merged, 0 files removed, 0 files unresolved

Sune Foldager validate: check for spurious incoming filelog entries...	r18422	Test spurious filelog entries:

Adrian Buehlmann combine tests	r12279	$ cd test-clone
Sune Foldager validate: check for spurious incoming filelog entries...	r18422	$ echo blah >> beta
		$ cp .hg/store/data/beta.i tmp1
		$ hg ci -m 2
		$ cp .hg/store/data/beta.i tmp2
		$ hg -q rollback
		$ mv tmp2 .hg/store/data/beta.i
		$ echo blah >> beta
		$ hg ci -m '2 (corrupt)'

		Expected to fail:

		$ hg verify
		checking changesets
		checking manifests
		crosschecking files in changesets and manifests
		checking files
		beta@1: dddc47b3ba30 not in manifests
		2 files, 2 changesets, 4 total revisions
		1 integrity errors encountered!
		(first damaged changeset appears to be 1)
		[1]

		$ hg push
Mads Kiilerich tests: fix for windows - slashes and no serve	r18506	pushing to $TESTTMP/test (glob)
Sune Foldager validate: check for spurious incoming filelog entries...	r18422	searching for changes
		adding changesets
		adding manifests
		adding file changes
		transaction abort!
		rollback completed
		abort: received spurious file revlog entry
		[255]

		$ hg -q rollback
		$ mv tmp1 .hg/store/data/beta.i
		$ echo beta > beta

		Test missing filelog entries:

Adrian Buehlmann combine tests	r12279	$ cp .hg/store/data/beta.i tmp
		$ echo blah >> beta
		$ hg ci -m '2 (corrupt)'
		$ mv tmp .hg/store/data/beta.i

		Expected to fail:

		$ hg verify
		checking changesets
		checking manifests
		crosschecking files in changesets and manifests
		checking files
Martin von Zweigbergk verify: use similar language for missing manifest and file revisions...	r28114	beta@1: manifest refers to unknown revision dddc47b3ba30
Adrian Buehlmann combine tests	r12279	2 files, 2 changesets, 2 total revisions
		1 integrity errors encountered!
		(first damaged changeset appears to be 1)
Matt Mackall tests: add exit codes to unified tests	r12316	[1]
Adrian Buehlmann combine tests	r12279
		$ hg push
Mads Kiilerich tests: make (glob) on windows accept \ instead of /...	r15447	pushing to $TESTTMP/test (glob)
Adrian Buehlmann combine tests	r12279	searching for changes
		adding changesets
		adding manifests
		adding file changes
		transaction abort!
		rollback completed
		abort: missing file data for beta:dddc47b3ba30e54484720ce0f4f768a0f4b6efb9 - run hg verify
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Adrian Buehlmann combine tests	r12279
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913	$ cd ..