##// END OF EJS Templates
context: stop catching RepoLookupError from namespace.singlenode()...
context: stop catching RepoLookupError from namespace.singlenode() As pointed out by Yuya, the RepoLookupError was there for catching errors from repo.branchtip(). However, since 885c0290f7d5 (localrepo: add ignoremissing parameter to branchtip, 2014-10-16), that should no longer happen. I think it should now be an error if a namespace raises a RepoLookupError, so we propagate the exception up and and make it easy to fix, rather than trying to interpret the changeid as nodeid prefix and raise a general "unknown revision '...'" error. I also don't think we should catch FilteredLookupError and LookupError from the changelog.rev() call, for the same reason as above: If a namespace returns a node that doesn't exist, we should provide a more helpful exception than "unknown revision '...'". Differential Revision: https://phab.mercurial-scm.org/D3145

File last commit:

r36903:4daa2207 default
r37409:3198d5a2 default
Show More
hgweberror.py
24 lines | 756 B | text/x-python | PythonLexer
Gregory Szorc
hgweb: send proper HTTP response after uncaught exception...
r23409 # A dummy extension that installs an hgweb command that throws an Exception.
Gregory Szorc
tests: use absolute_import in hgweberror.py
r27299 from __future__ import absolute_import
from mercurial.hgweb import (
webcommands,
)
Gregory Szorc
hgweb: send proper HTTP response after uncaught exception...
r23409
Gregory Szorc
hgweb: stop passing req and tmpl into @webcommand functions (API)...
r36903 def raiseerror(web):
Gregory Szorc
hgweb: send proper HTTP response after uncaught exception...
r23409 '''Dummy web command that raises an uncaught Exception.'''
# Simulate an error after partial response.
Gregory Szorc
hgweb: port archive command to modern response API...
r36892 if 'partialresponse' in web.req.qsparams:
web.res.status = b'200 Script output follows'
web.res.headers[b'Content-Type'] = b'text/plain'
web.res.setbodywillwrite()
list(web.res.sendresponse())
web.res.getbodyfile().write(b'partial content\n')
Gregory Szorc
hgweb: send proper HTTP response after uncaught exception...
r23409
raise AttributeError('I am an uncaught error!')
def extsetup(ui):
setattr(webcommands, 'raiseerror', raiseerror)
webcommands.__all__.append('raiseerror')