##// END OF EJS Templates
changegroup: port to emitrevisions() (issue5976)...
changegroup: port to emitrevisions() (issue5976) We now have a unified API for emitting revision data from a storage backend. It handles sorting nodes and the complicated delta versus revision decisions for us. This commit ports changegroup to that API. There should be no behavior changes for changegroups not using ellipsis. And lack of test changes seems to confirm that. There are some changes for ellipsis mode, however. Before, when sending an ellipsis revision, we would always send a fulltext revision (as opposed to a delta). There was a TODO tracking this open item. One of the things the emitrevisions() API does for us is figure out whether we can safely emit a delta. So, it is now possible for ellipsis revisions to be sent as deltas! (It does this by not assuming parent/ancestor revisions are available and tracking which revisions have been sent out.) Because we eliminated the list of revision delta request objects, performance has improved substantially: $ hg perfchangegroupchangelog before: ! wall 24.348077 comb 24.330000 user 24.140000 sys 0.190000 (best of 3) after: ! wall 18.245911 comb 18.240000 user 18.100000 sys 0.140000 (best of 3) That's a lot of overhead for creating a few hundred thousand Python objects! This is still a little slower than 4.7. Probably due to 23d582ca introducing a type for the revision/delta results. There is potentially room to optimize. But at some point we need to abstract storage in order to support alternate storage backends. Unfortunately that means using a Python data structure to represent results. And unfortunately there is overhead with every new Python object created. Differential Revision: https://phab.mercurial-scm.org/D4725

File last commit:

r39840:d3d333ab default
r39901:31b7e8e7 default
Show More
wireprotocolv2.txt
507 lines | 16.4 KiB | text/plain | TextLexer
Gregory Szorc
internals: extract wire protocol version 2 commands to standalone doc...
r39470 **Experimental and under active development**
This section documents the wire protocol commands exposed to transports
using the frame-based protocol. The set of commands exposed through
these transports is distinct from the set of commands exposed to legacy
transports.
The frame-based protocol uses CBOR to encode command execution requests.
All command arguments must be mapped to a specific or set of CBOR data
types.
The response to many commands is also CBOR. There is no common response
format: each command defines its own response format.
TODOs
=====
* Add "node namespace" support to each command. In order to support
SHA-1 hash transition, we want servers to be able to expose different
"node namespaces" for the same data. Every command operating on nodes
should specify which "node namespace" it is operating on and responses
should encode the "node namespace" accordingly.
Commands
========
The sections below detail all commands available to wire protocol version
2.
branchmap
---------
Obtain heads in named branches.
Receives no arguments.
The response is a map with bytestring keys defining the branch name.
Values are arrays of bytestring defining raw changeset nodes.
capabilities
------------
Obtain the server's capabilities.
Receives no arguments.
This command is typically called only as part of the handshake during
initial connection establishment.
The response is a map with bytestring keys defining server information.
The defined keys are:
commands
A map defining available wire protocol commands on this server.
Keys in the map are the names of commands that can be invoked. Values
are maps defining information about that command. The bytestring keys
are:
args
Gregory Szorc
wireprotov2: expose rich arguments metadata...
r39837 (map) Describes arguments accepted by the command.
Keys are bytestrings denoting the argument name.
Values are maps describing the argument. The map has the following
bytestring keys:
Gregory Szorc
internals: extract wire protocol version 2 commands to standalone doc...
r39470
Gregory Szorc
wireprotov2: expose rich arguments metadata...
r39837 default
(varied) The default value for this argument if not specified. Only
present if ``required`` is not true.
required
(boolean) Whether the argument must be specified. Failure to send
required arguments will result in an error executing the command.
type
(bytestring) The type of the argument. e.g. ``bytes`` or ``bool``.
Gregory Szorc
wireprotov2: advertise set of valid values for requestable fields...
r39838 validvalues
(set) Values that are recognized for this argument. Some arguments
only allow a fixed set of values to be specified. These arguments
may advertise that set in this key. If this set is advertised and
a value not in this set is specified, the command should result
in error.
Gregory Szorc
internals: extract wire protocol version 2 commands to standalone doc...
r39470 permissions
An array of permissions required to execute this command.
compression
An array of maps defining available compression format support.
The array is sorted from most preferred to least preferred.
Each entry has the following bytestring keys:
name
Name of the compression engine. e.g. ``zstd`` or ``zlib``.
framingmediatypes
An array of bytestrings defining the supported framing protocol
media types. Servers will not accept media types not in this list.
Gregory Szorc
wireprotov2: advertise recognized path filter prefixes...
r39836 pathfilterprefixes
(set of bytestring) Matcher prefixes that are recognized when performing
path filtering. Specifying a path filter whose type/prefix does not
match one in this set will likely be rejected by the server.
Gregory Szorc
internals: extract wire protocol version 2 commands to standalone doc...
r39470 rawrepoformats
An array of storage formats the repository is using. This set of
requirements can be used to determine whether a client can read a
*raw* copy of file data available.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666 changesetdata
-------------
Obtain various data related to changesets.
The command accepts the following arguments:
noderange
(array of arrays of bytestrings) An array of 2 elements, each being an
array of node bytestrings. The first array denotes the changelog revisions
that are already known to the client. The second array denotes the changelog
revision DAG heads to fetch. The argument essentially defines a DAG range
bounded by root and head nodes to fetch.
The roots array may be empty. The heads array must be defined.
nodes
(array of bytestrings) Changelog revisions to request explicitly.
Gregory Szorc
wireprotov2: teach changesetdata to fetch ancestors until depth...
r39840 nodesdepth
(unsigned integer) Number of ancestor revisions of elements in ``nodes``
to also fetch. When defined, for each element in ``nodes``, DAG ancestors
will be walked until at most N total revisions are emitted.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666 fields
(set of bytestring) Which data associated with changelog revisions to
fetch. The following values are recognized:
Gregory Szorc
wireprotov2: add bookmarks to "changesetdata" command...
r39670 bookmarks
Bookmarks associated with a revision.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666 parents
Parent revisions.
Gregory Szorc
wireprotov2: add phases to "changesetdata" command...
r39668 phase
The phase state of a revision.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666 revision
The raw, revision data for the changelog entry. The hash of this data
will match the revision's node value.
The server resolves the set of revisions relevant to the request by taking
the union of the ``noderange`` and ``nodes`` arguments. At least one of these
arguments must be defined.
The response bytestream starts with a CBOR map describing the data that follows.
This map has the following bytestring keys:
totalitems
(unsigned integer) Total number of changelog revisions whose data is being
Gregory Szorc
wireprotov2: add phases to "changesetdata" command...
r39668 transferred. This maps to the set of revisions in the requested node
range, not the total number of records that follow (see below for why).
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666
Following the map header is a series of 0 or more CBOR values. If values
are present, the first value will always be a map describing a single changeset
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 revision.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 If the ``fieldsfollowing`` key is present, the map will immediately be followed
by N CBOR bytestring values, where N is the number of elements in
``fieldsfollowing``. Each bytestring value corresponds to a field denoted
by ``fieldsfollowing``.
Following the optional bytestring field values is the next revision descriptor
map, or end of stream.
Each revision descriptor map has the following bytestring keys:
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666
node
(bytestring) The node value for this revision. This is the SHA-1 hash of
the raw revision data.
Gregory Szorc
wireprotov2: add bookmarks to "changesetdata" command...
r39670 bookmarks (optional)
(array of bytestrings) Bookmarks attached to this revision. Only present
if ``bookmarks`` data is being requested and the revision has bookmarks
attached.
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 fieldsfollowing (optional)
(array of 2-array) Denotes what fields immediately follow this map. Each
value is an array with 2 elements: the bytestring field name and an unsigned
integer describing the length of the data, in bytes.
If this key isn't present, no special fields will follow this map.
The following fields may be present:
revision
Raw, revision data for the changelog entry. Contains a serialized form
of the changeset data, including the author, date, commit message, set
of changed files, manifest node, and other metadata.
Only present if the ``revision`` field was requested.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666 parents (optional)
(array of bytestrings) The nodes representing the parent revisions of this
revision. Only present if ``parents`` data is being requested.
Gregory Szorc
wireprotov2: add phases to "changesetdata" command...
r39668 phase (optional)
(bytestring) The phase that a revision is in. Recognized values are
``secret``, ``draft``, and ``public``. Only present if ``phase`` data
is being requested.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666 If nodes are requested via ``noderange``, they will be emitted in DAG order,
parents always before children.
If nodes are requested via ``nodes``, they will be emitted in requested order.
Nodes from ``nodes`` are emitted before nodes from ``noderange``.
Gregory Szorc
wireprotov2: add phases to "changesetdata" command...
r39668 The set of changeset revisions emitted may not match the exact set of
changesets requested. Furthermore, the set of keys present on each
map may vary. This is to facilitate emitting changeset updates as well
as new revisions.
For example, if the request wants ``phase`` and ``revision`` data,
the response may contain entries for each changeset in the common nodes
set with the ``phase`` key and without the ``revision`` key in order
to reflect a phase-only update.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666 TODO support different revision selection mechanisms (e.g. non-public, specific
revisions)
TODO support different hash "namespaces" for revisions (e.g. sha-1 versus other)
TODO support emitting obsolescence data
TODO support filtering based on relevant paths (narrow clone)
TODO support hgtagsfnodes cache / tags data
TODO support branch heads cache
Gregory Szorc
wireprotov2: teach changesetdata to fetch ancestors until depth...
r39840 TODO consider unify query mechanism. e.g. as an array of "query descriptors"
rather than a set of top-level arguments that have semantics when combined.
Gregory Szorc
wireprotov2: define and implement "changesetdata" command...
r39666
Gregory Szorc
wireprotov2: define and implement "filedata" command...
r39675 filedata
--------
Obtain various data related to an individual tracked file.
The command accepts the following arguments:
fields
(set of bytestring) Which data associated with a file to fetch.
The following values are recognized:
parents
Parent nodes for the revision.
revision
The raw revision data for a file.
Gregory Szorc
wireprotov2: let clients drive delta behavior...
r39677 haveparents
(bool) Whether the client has the parent revisions of all requested
nodes. If set, the server may emit revision data as deltas against
any parent revision. If not set, the server MUST only emit deltas for
revisions previously emitted by this command.
False is assumed in the absence of any value.
Gregory Szorc
wireprotov2: define and implement "filedata" command...
r39675 nodes
(array of bytestrings) File nodes whose data to retrieve.
path
(bytestring) Path of the tracked file whose data to retrieve.
TODO allow specifying revisions via alternate means (such as from
changeset revisions or ranges)
The response bytestream starts with a CBOR map describing the data that
follows. It has the following bytestream keys:
totalitems
(unsigned integer) Total number of file revisions whose data is
being returned.
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 Following the map header is a series of 0 or more CBOR values. If values
are present, the first value will always be a map describing a single changeset
revision.
If the ``fieldsfollowing`` key is present, the map will immediately be followed
by N CBOR bytestring values, where N is the number of elements in
``fieldsfollowing``. Each bytestring value corresponds to a field denoted
by ``fieldsfollowing``.
Following the optional bytestring field values is the next revision descriptor
map, or end of stream.
Each revision descriptor map has the following bytestring keys:
Gregory Szorc
wireprotov2: define and implement "filedata" command...
r39675
Each map has the following bytestring keys:
node
(bytestring) The node of the file revision whose data is represented.
deltabasenode
(bytestring) Node of the file revision the following delta is against.
Only present if the ``revision`` field is requested and delta data
follows this map.
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 fieldsfollowing
(array of 2-array) Denotes extra bytestring fields that following this map.
See the documentation for ``changesetdata`` for semantics.
The following named fields may be present:
Gregory Szorc
wireprotov2: define and implement "filedata" command...
r39675
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 ``delta``
The delta data to use to construct the fulltext revision.
Only present if the ``revision`` field is requested and a delta is
being emitted. The ``deltabasenode`` top-level key will also be
present if this field is being emitted.
``revision``
The fulltext revision data for this manifest. Only present if the
``revision`` field is requested and a fulltext revision is being emitted.
Gregory Szorc
wireprotov2: define and implement "filedata" command...
r39675
parents
(array of bytestring) The nodes of the parents of this file revision.
Only present if the ``parents`` field is requested.
When ``revision`` data is requested, the server chooses to emit either fulltext
revision data or a delta. What the server decides can be inferred by looking
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 for the presence of the ``delta`` or ``revision`` keys in the
``fieldsfollowing`` array.
Gregory Szorc
wireprotov2: define and implement "filedata" command...
r39675
Gregory Szorc
internals: extract wire protocol version 2 commands to standalone doc...
r39470 heads
-----
Obtain DAG heads in the repository.
The command accepts the following arguments:
publiconly (optional)
(boolean) If set, operate on the DAG for public phase changesets only.
Non-public (i.e. draft) phase DAG heads will not be returned.
The response is a CBOR array of bytestrings defining changeset nodes
of DAG heads. The array can be empty if the repository is empty or no
changesets satisfied the request.
TODO consider exposing phase of heads in response
known
-----
Determine whether a series of changeset nodes is known to the server.
The command accepts the following arguments:
nodes
(array of bytestrings) List of changeset nodes whose presence to
query.
The response is a bytestring where each byte contains a 0 or 1 for the
corresponding requested node at the same index.
TODO use a bit array for even more compact response
listkeys
--------
List values in a specified ``pushkey`` namespace.
The command receives the following arguments:
namespace
(bytestring) Pushkey namespace to query.
The response is a map with bytestring keys and values.
TODO consider using binary to represent nodes in certain pushkey namespaces.
lookup
------
Try to resolve a value to a changeset revision.
Unlike ``known`` which operates on changeset nodes, lookup operates on
node fragments and other names that a user may use.
The command receives the following arguments:
key
(bytestring) Value to try to resolve.
On success, returns a bytestring containing the resolved node.
Gregory Szorc
wireprotov2: define and implement "manifestdata" command...
r39673 manifestdata
------------
Obtain various data related to manifests (which are lists of files in
a revision).
The command accepts the following arguments:
fields
(set of bytestring) Which data associated with manifests to fetch.
The following values are recognized:
parents
Parent nodes for the manifest.
revision
The raw revision data for the manifest.
Gregory Szorc
wireprotov2: let clients drive delta behavior...
r39677 haveparents
(bool) Whether the client has the parent revisions of all requested
nodes. If set, the server may emit revision data as deltas against
any parent revision. If not set, the server MUST only emit deltas for
revisions previously emitted by this command.
False is assumed in the absence of any value.
Gregory Szorc
wireprotov2: define and implement "manifestdata" command...
r39673 nodes
(array of bytestring) Manifest nodes whose data to retrieve.
tree
(bytestring) Path to manifest to retrieve. The empty bytestring represents
the root manifest. All other values represent directories/trees within
the repository.
TODO allow specifying revisions via alternate means (such as from changeset
revisions or ranges)
TODO consider recursive expansion of manifests (with path filtering for
narrow use cases)
The response bytestream starts with a CBOR map describing the data that
follows. It has the following bytestring keys:
totalitems
(unsigned integer) Total number of manifest revisions whose data is
being returned.
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 Following the map header is a series of 0 or more CBOR values. If values
are present, the first value will always be a map describing a single manifest
revision.
Gregory Szorc
wireprotov2: define and implement "manifestdata" command...
r39673
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 If the ``fieldsfollowing`` key is present, the map will immediately be followed
by N CBOR bytestring values, where N is the number of elements in
``fieldsfollowing``. Each bytestring value corresponds to a field denoted
by ``fieldsfollowing``.
Following the optional bytestring field values is the next revision descriptor
map, or end of stream.
Each revision descriptor map has the following bytestring keys:
Gregory Szorc
wireprotov2: define and implement "manifestdata" command...
r39673
node
(bytestring) The node of the manifest revision whose data is represented.
deltabasenode
(bytestring) The node that the delta representation of this revision is
computed against. Only present if the ``revision`` field is requested and
a delta is being emitted.
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 fieldsfollowing
(array of 2-array) Denotes extra bytestring fields that following this map.
See the documentation for ``changesetdata`` for semantics.
The following named fields may be present:
``delta``
The delta data to use to construct the fulltext revision.
Only present if the ``revision`` field is requested and a delta is
being emitted. The ``deltabasenode`` top-level key will also be
present if this field is being emitted.
``revision``
The fulltext revision data for this manifest. Only present if the
``revision`` field is requested and a fulltext revision is being emitted.
Gregory Szorc
wireprotov2: define and implement "manifestdata" command...
r39673
parents
(array of bytestring) The nodes of the parents of this manifest revision.
Only present if the ``parents`` field is requested.
When ``revision`` data is requested, the server chooses to emit either fulltext
revision data or a delta. What the server decides can be inferred by looking
Gregory Szorc
wireprotov2: allow multiple fields to follow revision maps...
r39839 for the presence of ``delta`` or ``revision`` in the ``fieldsfollowing`` array.
Gregory Szorc
wireprotov2: define and implement "manifestdata" command...
r39673
Gregory Szorc
internals: extract wire protocol version 2 commands to standalone doc...
r39470 pushkey
-------
Set a value using the ``pushkey`` protocol.
The command receives the following arguments:
namespace
(bytestring) Pushkey namespace to operate on.
key
(bytestring) The pushkey key to set.
old
(bytestring) Old value for this key.
new
(bytestring) New value for this key.
TODO consider using binary to represent nodes is certain pushkey namespaces.
TODO better define response type and meaning.