##// END OF EJS Templates
obsolete: rename _fnodesize to _fmfnodesize...
obsolete: rename _fnodesize to _fmfnodesize All variables involved in the obsstore format are prefixed with `_fm`. `_fnodesize` was the exception. It is now back in line. This is meaningful as we'll need to distinguish between multiple versions of the obsstore format.

File last commit:

r22326:370b7162 default
r22326:370b7162 default
Show More
obsolete.py
981 lines | 35.1 KiB | text/x-python | PythonLexer
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 # obsolete.py - obsolete markers handling
#
# Copyright 2012 Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Logilab SA <contact@logilab.fr>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 """Obsolete marker handling
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
An obsolete marker maps an old changeset to a list of new
changesets. If the list of new changesets is empty, the old changeset
is said to be "killed". Otherwise, the old changeset is being
"replaced" by the new changesets.
Obsolete markers can be used to record and distribute changeset graph
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 transformations performed by history rewrite operations, and help
building new tools to reconcile conflicting rewrite actions. To
facilitate conflict resolution, markers include various annotations
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 besides old and news changeset identifiers, such as creation date or
author name.
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 The old obsoleted changeset is called a "precursor" and possible
replacements are called "successors". Markers that used changeset X as
a precursor are called "successor markers of X" because they hold
information about the successors of X. Markers that use changeset Y as
a successors are call "precursor markers of Y" because they hold
information about the precursors of Y.
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776
Pierre-Yves David
obsolete: add example of marker usage in the documentation...
r17775 Examples:
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 - When changeset A is replaced by changeset A', one marker is stored:
Pierre-Yves David
obsolete: add example of marker usage in the documentation...
r17775
Martin Geisler
obsolete: fix one-element tuple in module docstring
r21166 (A, (A',))
Pierre-Yves David
obsolete: add example of marker usage in the documentation...
r17775
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 - When changesets A and B are folded into a new changeset C, two markers are
Pierre-Yves David
obsolete: add example of marker usage in the documentation...
r17775 stored:
(A, (C,)) and (B, (C,))
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 - When changeset A is simply "pruned" from the graph, a marker is created:
Pierre-Yves David
obsolete: add example of marker usage in the documentation...
r17775
(A, ())
- When changeset A is split into B and C, a single marker are used:
(A, (C, C))
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 We use a single marker to distinguish the "split" case from the "divergence"
case. If two independent operations rewrite the same changeset A in to A' and
A'', we have an error case: divergent rewriting. We can detect it because
Pierre-Yves David
obsolete: add example of marker usage in the documentation...
r17775 two markers will be created independently:
(A, (B,)) and (A, (C,))
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
Format
------
Markers are stored in an append-only file stored in
'.hg/store/obsstore'.
The file starts with a version header:
- 1 unsigned byte: version number, starting at zero.
The header is followed by the markers. Each marker is made of:
Martin Geisler
obsolete: let N denote number of obsoleted changestes in a marker...
r21165 - 1 unsigned byte: number of new changesets "N", can be zero.
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
- 1 unsigned 32-bits integer: metadata size "M" in bytes.
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 - 1 byte: a bit field. It is reserved for flags used in common
obsolete marker operations, to avoid repeated decoding of metadata
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 entries.
- 20 bytes: obsoleted changeset identifier.
- N*20 bytes: new changesets identifiers.
- M bytes: metadata as a sequence of nul-terminated strings. Each
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164 string contains a key and a value, separated by a colon ':', without
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 additional encoding. Keys cannot contain '\0' or ':' and values
cannot contain '\0'.
Martin Geisler
obsolete: fix language and grammar in module docstring
r21164
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 """
Adrian Buehlmann
obsolete: os.SEEK_END first appeared in Python 2.5...
r17200 import struct
Pierre-Yves David
obsolete: cheap detection of nullid as successors...
r17774 import util, base85, node
Pierre-Yves David
obsolete: order of magnitude speedup in _computebumpedset...
r20207 import phases
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 from i18n import _
_pack = struct.pack
_unpack = struct.unpack
Mads Kiilerich
declare local constants instead of using magic values and comments
r17429 _SEEK_END = 2 # os.SEEK_END was introduced in Python 2.5
Mads Kiilerich
fix trivial spelling errors
r17424 # the obsolete feature is not mature enough to be enabled by default.
Pierre-Yves David
obsolete: introduce an `_enabled` switch to disable the feature by default...
r17296 # you have to rely on third party extension extension to enable this.
_enabled = False
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
# data used for parsing and writing
_fmversion = 0
_fmfixed = '>BIB20s'
_fmnode = '20s'
_fmfsize = struct.calcsize(_fmfixed)
Pierre-Yves David
obsolete: rename _fnodesize to _fmfnodesize...
r22326 _fmfnodesize = struct.calcsize(_fmnode)
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
Pierre-Yves David
obsolete: add a flag that allows fixing "bumped" changeset...
r17831 ### obsolescence marker flag
## bumpedfix flag
#
# When a changeset A' succeed to a changeset A which became public, we call A'
# "bumped" because it's a successors of a public changesets
#
# o A' (bumped)
# |`:
# | o A
# |/
# o Z
#
# The way to solve this situation is to create a new changeset Ad as children
# of A. This changeset have the same content than A'. So the diff from A to A'
# is the same than the diff from A to Ad. Ad is marked as a successors of A'
#
# o Ad
# |`:
# | x A'
# |'|
# o | A
# |/
# o Z
#
# But by transitivity Ad is also a successors of A. To avoid having Ad marked
# as bumped too, we add the `bumpedfix` flag to the marker. <A', (Ad,)>.
Mads Kiilerich
spelling: fix some minor issues found by spell checker
r18644 # This flag mean that the successors express the changes between the public and
# bumped version and fix the situation, breaking the transitivity of
# "bumped" here.
Pierre-Yves David
obsolete: add a flag that allows fixing "bumped" changeset...
r17831 bumpedfix = 1
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 def _readmarkers(data):
"""Read and enumerate markers from raw data"""
off = 0
diskversion = _unpack('>B', data[off:off + 1])[0]
off += 1
if diskversion != _fmversion:
raise util.Abort(_('parsing obsolete marker: unknown version %r')
% diskversion)
# Loop on markers
l = len(data)
while off + _fmfsize <= l:
# read fixed part
cur = data[off:off + _fmfsize]
off += _fmfsize
nbsuc, mdsize, flags, pre = _unpack(_fmfixed, cur)
# read replacement
sucs = ()
if nbsuc:
Pierre-Yves David
obsolete: rename _fnodesize to _fmfnodesize...
r22326 s = _fmfnodesize * nbsuc
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 cur = data[off:off + s]
sucs = _unpack(_fmnode * nbsuc, cur)
off += s
# read metadata
# (metadata will be decoded on demand)
metadata = data[off:off + mdsize]
if len(metadata) != mdsize:
raise util.Abort(_('parsing obsolete marker: metadata is too '
'short, %d bytes expected, got %d')
Pierre-Yves David
obsolete: fix decoding error message arguments
r17253 % (mdsize, len(metadata)))
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 off += mdsize
Pierre-Yves David
obsstore: drop 'date' from the metadata dictionary...
r22257 meta = decodemeta(metadata)
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222 try:
Gregory Szorc
obsolete: avoid slow, generic date parsing...
r22309 when, offset = decodemeta(metadata).pop('date', '0 0').split(' ')
date = float(when), int(offset)
except ValueError:
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222 date = (0., 0)
Pierre-Yves David
obsstore: also store the 'parents' field on disk...
r22258 parents = None
if 'p2' in meta:
parents = (meta.pop('p1', None), meta.pop('p2', None))
elif 'p1' in meta:
parents = (meta.pop('p1', None),)
elif 'p0' in meta:
parents = ()
if parents is not None:
try:
parents = tuple(node.bin(p) for p in parents)
# if parent content is not a nodeid, drop the data
for p in parents:
if len(p) != 20:
parents = None
break
except TypeError:
# if content cannot be translated to nodeid drop the data.
parents = None
Pierre-Yves David
obsstore: drop 'date' from the metadata dictionary...
r22257 metadata = encodemeta(meta)
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222
Pierre-Yves David
obsstore: also store the 'parents' field on disk...
r22258 yield (pre, sucs, flags, metadata, date, parents)
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
def encodemeta(meta):
"""Return encoded metadata string to string mapping.
Assume no ':' in key and no '\0' in both key and value."""
for key, value in meta.iteritems():
if ':' in key or '\0' in key:
raise ValueError("':' and '\0' are forbidden in metadata key'")
if '\0' in value:
Mads Kiilerich
spelling: fixes from spell checker
r21024 raise ValueError("':' is forbidden in metadata value'")
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 return '\0'.join(['%s:%s' % (k, meta[k]) for k in sorted(meta)])
def decodemeta(data):
"""Return string to string dictionary from encoded version."""
d = {}
for l in data.split('\0'):
if l:
key, value = l.split(':')
d[key] = value
return d
Pierre-Yves.David@ens-lyon.org
obsolete: helper class to access obsolete marker data
r17072 class marker(object):
"""Wrap obsolete marker raw data"""
def __init__(self, repo, data):
# the repo argument will be used to create changectx in later version
self._repo = repo
self._data = data
self._decodedmeta = None
Augie Fackler
obsolete: add __eq__ and __hash__ to marker to make set() deduplication work
r20031 def __hash__(self):
return hash(self._data)
def __eq__(self, other):
if type(other) != type(self):
return False
return self._data == other._data
Pierre-Yves.David@ens-lyon.org
obsolete: helper class to access obsolete marker data
r17072 def precnode(self):
"""Precursor changeset node identifier"""
return self._data[0]
def succnodes(self):
"""List of successor changesets node identifiers"""
return self._data[1]
Pierre-Yves David
obsmarkers: add a `parentnodes` method to retrieve parent information
r22259 def parentnodes(self):
"""Parents of the precursors (None if not recorded)"""
return self._data[5]
Pierre-Yves.David@ens-lyon.org
obsolete: helper class to access obsolete marker data
r17072 def metadata(self):
"""Decoded metadata dictionary"""
if self._decodedmeta is None:
self._decodedmeta = decodemeta(self._data[3])
return self._decodedmeta
def date(self):
"""Creation date as (unixtime, offset)"""
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222 return self._data[4]
Pierre-Yves.David@ens-lyon.org
obsolete: helper class to access obsolete marker data
r17072
Pierre-Yves David
obsmarker: add a `flags` method...
r22215 def flags(self):
"""The flags field of the marker"""
return self._data[2]
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 class obsstore(object):
"""Store obsolete markers
Markers can be accessed with two mappings:
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776 - precursors[x] -> set(markers on precursors edges of x)
- successors[x] -> set(markers on successors edges of x)
Pierre-Yves David
obsstore: keep track of children information...
r22270 - children[x] -> set(markers on precursors edges of children(x)
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 """
Pierre-Yves David
obsstore: add a `parents` field...
r22254 fields = ('prec', 'succs', 'flag', 'meta', 'date', 'parents')
# prec: nodeid, precursor changesets
# succs: tuple of nodeid, successor changesets (0-N length)
# flag: integer, flag field carrying modifier for the markers (see doc)
# meta: binary blob, encoded metadata dictionary
# date: (float, int) tuple, date of marker creation
# parents: (tuple of nodeid) or None, parents of precursors
# None is used when no data has been recorded
Pierre-Yves David
obsstore: add fields attribute to track each field in a marker...
r22221
Pierre-Yves David
obsolete: move obsolete markers read/write logic to obsstore object...
r17124 def __init__(self, sopener):
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469 # caches for various obsolescence related cache
self.caches = {}
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070 self._all = []
self.precursors = {}
self.successors = {}
Pierre-Yves David
obsstore: keep track of children information...
r22270 self.children = {}
Pierre-Yves David
obsolete: move obsolete markers read/write logic to obsstore object...
r17124 self.sopener = sopener
data = sopener.tryread('obsstore')
if data:
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 self._load(_readmarkers(data))
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
Pierre-Yves.David@ens-lyon.org
obsolete: add easy way to iterate over obsolete marker object
r17073 def __iter__(self):
return iter(self._all)
Pierre-Yves David
obsstore: add a __len__ method...
r20585 def __len__(self):
return len(self._all)
Pierre-Yves.David@ens-lyon.org
obsolete: exchange obsolete marker over pushkey...
r17075 def __nonzero__(self):
return bool(self._all)
Pierre-Yves David
obsstore: add a `parents` argument to obsstore.create...
r22255 def create(self, transaction, prec, succs=(), flag=0, parents=None,
date=None, metadata=None):
Pierre-Yves.David@ens-lyon.org
command: creation of obsolete marker...
r17071 """obsolete: add a new obsolete marker
* ensuring it is hashable
* check mandatory metadata
* encode metadata
Pierre-Yves David
obsstore: update create docstring to point to the coder friendly function...
r20516
If you are a human writing code creating marker you want to use the
`createmarkers` function in this module instead.
Pierre-Yves David
obsstore: `create` method return True if a marker is actually added...
r20584
return True if a new marker have been added, False if the markers
already existed (no op).
Pierre-Yves.David@ens-lyon.org
command: creation of obsolete marker...
r17071 """
if metadata is None:
metadata = {}
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222 if date is None:
if 'date' in metadata:
# as a courtesy for out-of-tree extensions
date = util.parsedate(metadata.pop('date'))
else:
Pierre-Yves David
obsstore: add an explicit `date` argument to obsstore.create...
r22217 date = util.makedate()
Pierre-Yves.David@ens-lyon.org
command: creation of obsolete marker...
r17071 if len(prec) != 20:
raise ValueError(prec)
for succ in succs:
if len(succ) != 20:
Pierre-Yves David
obsolete: fix error message at marker creation...
r17117 raise ValueError(succ)
Pierre-Yves David
obsstore.create: add a simple safeguard against cyclic markers...
r22177 if prec in succs:
raise ValueError(_('in-marker cycle with %s') % node.hex(prec))
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222 marker = (str(prec), tuple(succs), int(flag), encodemeta(metadata),
Pierre-Yves David
obsstore: add a `parents` argument to obsstore.create...
r22255 date, parents)
Pierre-Yves David
obsstore: `create` method return True if a marker is actually added...
r20584 return bool(self.add(transaction, [marker]))
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220
def add(self, transaction, markers):
"""Add new markers to the store
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 Take care of filtering duplicate.
Return the number of new marker."""
Pierre-Yves David
obsolete: introduce an `_enabled` switch to disable the feature by default...
r17296 if not _enabled:
raise util.Abort('obsolete feature is not enabled on this repo')
Pierre-Yves David
obsolete: stop doing membership test on list...
r20028 known = set(self._all)
Pierre-Yves David
obsolete: do not accept duplicated marker during exchange...
r20030 new = []
for m in markers:
if m not in known:
known.add(m)
new.append(m)
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 if new:
Pierre-Yves David
obsolete: append new markers to obsstore file instead of rewriting everything...
r17125 f = self.sopener('obsstore', 'ab')
Pierre-Yves David
obsolete: move obsolete markers read/write logic to obsstore object...
r17124 try:
Adrian Buehlmann
obsolete: add seek to end of file before calling tell (issue3543)
r17195 # Whether the file's current position is at the begin or at
# the end after opening a file for appending is implementation
# defined. So we must seek to the end before calling tell(),
# or we may get a zero offset for non-zero sized files on
# some platforms (issue3543).
Mads Kiilerich
declare local constants instead of using magic values and comments
r17429 f.seek(0, _SEEK_END)
Pierre-Yves David
obsolete: write obsolete marker inside a transaction...
r17126 offset = f.tell()
transaction.add('obsstore', offset)
Pierre-Yves.David@ens-lyon.org
obsolete: refactor writemarkers to only encode them...
r17219 # offset == 0: new file - add the version header
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 for bytes in _encodemarkers(new, offset == 0):
Pierre-Yves.David@ens-lyon.org
obsolete: refactor writemarkers to only encode them...
r17219 f.write(bytes)
Pierre-Yves David
obsolete: write obsolete marker inside a transaction...
r17126 finally:
# XXX: f.close() == filecache invalidation == obsstore rebuilt.
# call 'filecacheentry.refresh()' here
Pierre-Yves David
obsolete: move obsolete markers read/write logic to obsstore object...
r17124 f.close()
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 self._load(new)
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469 # new marker *may* have changed several set. invalidate the cache.
self.caches.clear()
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 return len(new)
Pierre-Yves David
obsolete: write obsolete marker inside a transaction...
r17126
timeless@mozdev.org
spelling: transaction
r17524 def mergemarkers(self, transaction, data):
Pierre-Yves David
obsstore: have the `mergemarkers` method return the number of new markers...
r22325 """merge a binary stream of markers inside the obsstore
Returns the number of new markers added."""
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 markers = _readmarkers(data)
Pierre-Yves David
obsstore: have the `mergemarkers` method return the number of new markers...
r22325 return self.add(transaction, markers)
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 def _load(self, markers):
for mark in markers:
self._all.append(mark)
pre, sucs = mark[:2]
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776 self.successors.setdefault(pre, set()).add(mark)
Pierre-Yves.David@ens-lyon.org
obsolete: obsstore.add now takes a list of markers....
r17220 for suc in sucs:
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776 self.precursors.setdefault(suc, set()).add(mark)
Pierre-Yves David
obsstore: keep track of children information...
r22270 parents = mark[5]
if parents is not None:
for p in parents:
self.children.setdefault(p, set()).add(mark)
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776 if node.nullid in self.precursors:
Pierre-Yves David
obsolete: cheap detection of nullid as successors...
r17774 raise util.Abort(_('bad obsolescence marker detected: '
'invalid successors nullid'))
Pierre-Yves David
obsstore: add relevantmarkers method...
r22271 def relevantmarkers(self, nodes):
"""return a set of all obsolescence markers relevant to a set of nodes.
"relevant" to a set of nodes mean:
- marker that use this changeset as successor
- prune marker of direct children on this changeset
- recursive application of the two rules on precursors of these markers
It is a set so you cannot rely on order."""
pendingnodes = set(nodes)
seenmarkers = set()
seennodes = set(pendingnodes)
precursorsmarkers = self.precursors
children = self.children
while pendingnodes:
direct = set()
for current in pendingnodes:
direct.update(precursorsmarkers.get(current, ()))
pruned = [m for m in children.get(current, ()) if not m[1]]
direct.update(pruned)
direct -= seenmarkers
pendingnodes = set([m[0] for m in direct])
seenmarkers |= direct
pendingnodes -= seennodes
seennodes |= pendingnodes
return seenmarkers
Pierre-Yves.David@ens-lyon.org
obsolete: introduction of obsolete markers...
r17070
Pierre-Yves.David@ens-lyon.org
obsolete: refactor writemarkers to only encode them...
r17219 def _encodemarkers(markers, addheader=False):
Pierre-Yves David
obsolete: append new markers to obsstore file instead of rewriting everything...
r17125 # Kept separate from flushmarkers(), it will be reused for
# markers exchange.
Pierre-Yves.David@ens-lyon.org
obsolete: refactor writemarkers to only encode them...
r17219 if addheader:
yield _pack('>B', _fmversion)
Pierre-Yves David
obsolete: append new markers to obsstore file instead of rewriting everything...
r17125 for marker in markers:
Pierre-Yves David
pushkey: splits obsolete marker exchange into multiple keys...
r17295 yield _encodeonemarker(marker)
def _encodeonemarker(marker):
Pierre-Yves David
obsstore: add a `parents` field...
r22254 pre, sucs, flags, metadata, date, parents = marker
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222 metadata = decodemeta(metadata)
metadata['date'] = '%d %i' % date
Pierre-Yves David
obsstore: also store the 'parents' field on disk...
r22258 if parents is not None:
if not parents:
# mark that we explicitly recorded no parents
metadata['p0'] = ''
Augie Fackler
obsolete: avoid 2-argument form of enumerate, which was new in Python 2.6
r22262 for i, p in enumerate(parents):
metadata['p%i' % (i + 1)] = node.hex(p)
Pierre-Yves David
obsmarker: add `date` as an explicit field...
r22222 metadata = encodemeta(metadata)
Pierre-Yves David
pushkey: splits obsolete marker exchange into multiple keys...
r17295 nbsuc = len(sucs)
format = _fmfixed + (_fmnode * nbsuc)
data = [nbsuc, len(metadata), flags, pre]
data.extend(sucs)
return _pack(format, *data) + metadata
# arbitrary picked to fit into 8K limit from HTTP server
# you have to take in account:
# - the version header
# - the base85 encoding
_maxpayload = 5300
Pierre-Yves.David@ens-lyon.org
obsolete: exchange obsolete marker over pushkey...
r17075
Pierre-Yves David
obsolete: extract encoding of marker for pushkey from the list key function...
r20599 def _pushkeyescape(markers):
"""encode markers into a dict suitable for pushkey exchange
Mads Kiilerich
spelling: fixes from spell checker
r21024 - binary data is base85 encoded
- split in chunks smaller than 5300 bytes"""
Pierre-Yves David
pushkey: splits obsolete marker exchange into multiple keys...
r17295 keys = {}
parts = []
currentlen = _maxpayload * 2 # ensure we create a new part
Pierre-Yves David
obsolete: extract encoding of marker for pushkey from the list key function...
r20599 for marker in markers:
Pierre-Yves David
pushkey: splits obsolete marker exchange into multiple keys...
r17295 nextdata = _encodeonemarker(marker)
if (len(nextdata) + currentlen > _maxpayload):
currentpart = []
currentlen = 0
parts.append(currentpart)
currentpart.append(nextdata)
Pierre-Yves David
obsolete: properly increment currentlen when building pushkey payload...
r17304 currentlen += len(nextdata)
Pierre-Yves David
pushkey: splits obsolete marker exchange into multiple keys...
r17295 for idx, part in enumerate(reversed(parts)):
data = ''.join([_pack('>B', _fmversion)] + part)
keys['dump%i' % idx] = base85.b85encode(data)
return keys
Pierre-Yves.David@ens-lyon.org
obsolete: add easy way to iterate over obsolete marker object
r17073
Pierre-Yves David
obsolete: extract encoding of marker for pushkey from the list key function...
r20599 def listmarkers(repo):
"""List markers over pushkey"""
if not repo.obsstore:
return {}
return _pushkeyescape(repo.obsstore)
Pierre-Yves.David@ens-lyon.org
obsolete: exchange obsolete marker over pushkey...
r17075 def pushmarker(repo, key, old, new):
"""Push markers over pushkey"""
Pierre-Yves David
pushkey: splits obsolete marker exchange into multiple keys...
r17295 if not key.startswith('dump'):
Pierre-Yves.David@ens-lyon.org
obsolete: exchange obsolete marker over pushkey...
r17075 repo.ui.warn(_('unknown key: %r') % key)
return 0
if old:
FUJIWARA Katsunori
obsolete: add '%' specifier to the format string to avoid TypeError at runtime...
r21098 repo.ui.warn(_('unexpected old value for %r') % key)
Pierre-Yves.David@ens-lyon.org
obsolete: exchange obsolete marker over pushkey...
r17075 return 0
data = base85.b85decode(new)
lock = repo.lock()
try:
Pierre-Yves David
obsolete: write obsolete marker inside a transaction...
r17126 tr = repo.transaction('pushkey: obsolete markers')
try:
repo.obsstore.mergemarkers(tr, data)
tr.close()
return 1
finally:
tr.release()
Pierre-Yves.David@ens-lyon.org
obsolete: exchange obsolete marker over pushkey...
r17075 finally:
lock.release()
Pierre-Yves.David@ens-lyon.org
obsolete: add easy way to iterate over obsolete marker object
r17073
Pierre-Yves David
debugobsolete: add a --rev argument...
r22274 def getmarkers(repo, nodes=None):
"""returns markers known in a repository
If <nodes> is specified, only markers "relevant" to those nodes are are
returned"""
if nodes is None:
rawmarkers = repo.obsstore
else:
rawmarkers = repo.obsstore.relevantmarkers(nodes)
for markerdata in rawmarkers:
Pierre-Yves.David@ens-lyon.org
obsolete: add easy way to iterate over obsolete marker object
r17073 yield marker(repo, markerdata)
Pierre-Yves David
debugobsolete: add a --rev argument...
r22274 def relevantmarkers(repo, node):
"""all obsolete markers relevant to some revision"""
for markerdata in repo.obsstore.relevantmarkers(node):
yield marker(repo, markerdata)
Pierre-Yves.David@ens-lyon.org
obsolete: function and method to access some obsolete data...
r17076 def precursormarkers(ctx):
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776 """obsolete marker marking this changeset as a successors"""
Pierre-Yves.David@ens-lyon.org
obsolete: function and method to access some obsolete data...
r17076 for data in ctx._repo.obsstore.precursors.get(ctx.node(), ()):
yield marker(ctx._repo, data)
def successormarkers(ctx):
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776 """obsolete marker making this changeset obsolete"""
Pierre-Yves.David@ens-lyon.org
obsolete: function and method to access some obsolete data...
r17076 for data in ctx._repo.obsstore.successors.get(ctx.node(), ()):
yield marker(ctx._repo, data)
Pierre-Yves David
obsolete: add a flag that allows fixing "bumped" changeset...
r17831 def allsuccessors(obsstore, nodes, ignoreflags=0):
Pierre-Yves David
obsolete: have `allsuccessors` takes a list of nodes...
r17827 """Yield node for every successor of <nodes>.
Some successors may be unknown locally.
Pierre-Yves David
obsolete: add an any successors function...
r17213
Pierre-Yves David
obsolete: improve allsuccessors doc string...
r20204 This is a linear yield unsuited to detecting split changesets. It includes
initial nodes too."""
Pierre-Yves David
obsolete: have `allsuccessors` takes a list of nodes...
r17827 remaining = set(nodes)
Pierre-Yves David
obsolete: add an any successors function...
r17213 seen = set(remaining)
while remaining:
current = remaining.pop()
yield current
Pierre-Yves David
obsolete: flip `obstore.successors` and `obsolete.precursors`...
r17776 for mark in obsstore.successors.get(current, ()):
Pierre-Yves David
obsolete: fix bad comment...
r20203 # ignore marker flagged with specified flag
Pierre-Yves David
obsolete: add a flag that allows fixing "bumped" changeset...
r17831 if mark[2] & ignoreflags:
continue
Pierre-Yves David
obsolete: add an any successors function...
r17213 for suc in mark[1]:
if suc not in seen:
seen.add(suc)
remaining.add(suc)
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469
Pierre-Yves David
obsolete: add an allprecursors method mirroring allsuccessors one....
r20206 def allprecursors(obsstore, nodes, ignoreflags=0):
"""Yield node for every precursors of <nodes>.
Some precursors may be unknown locally.
This is a linear yield unsuited to detecting folded changesets. It includes
initial nodes too."""
remaining = set(nodes)
seen = set(remaining)
while remaining:
current = remaining.pop()
yield current
for mark in obsstore.precursors.get(current, ()):
# ignore marker flagged with specified flag
if mark[2] & ignoreflags:
continue
suc = mark[0]
if suc not in seen:
seen.add(suc)
remaining.add(suc)
Pierre-Yves David
obsolete: extract foreground computation from bookmark.validdest...
r18984 def foreground(repo, nodes):
"""return all nodes in the "foreground" of other node
The foreground of a revision is anything reachable using parent -> children
Mads Kiilerich
spelling: random spell checker fixes
r19951 or precursor -> successor relation. It is very similar to "descendant" but
Pierre-Yves David
obsolete: extract foreground computation from bookmark.validdest...
r18984 augmented with obsolescence information.
Mads Kiilerich
spelling: random spell checker fixes
r19951 Beware that possible obsolescence cycle may result if complex situation.
Pierre-Yves David
obsolete: extract foreground computation from bookmark.validdest...
r18984 """
repo = repo.unfiltered()
foreground = set(repo.set('%ln::', nodes))
if repo.obsstore:
# We only need this complicated logic if there is obsolescence
# XXX will probably deserve an optimised revset.
nm = repo.changelog.nodemap
plen = -1
# compute the whole set of successors or descendants
while len(foreground) != plen:
plen = len(foreground)
succs = set(c.node() for c in foreground)
mutable = [c.node() for c in foreground if c.mutable()]
succs.update(allsuccessors(repo.obsstore, mutable))
known = (n for n in succs if n in nm)
foreground = set(repo.set('%ln::', known))
return set(c.node() for c in foreground)
Pierre-Yves David
obsolete: compute successors set...
r18068 def successorssets(repo, initialnode, cache=None):
"""Return all set of successors of initial nodes
Sean Farley
obsolete: clarify documentation for succcessorssets
r20277 The successors set of a changeset A are a group of revisions that succeed
A. It succeeds A as a consistent whole, each revision being only a partial
replacement. The successors set contains non-obsolete changesets only.
Pierre-Yves David
obsolete: compute successors set...
r18068
Sean Farley
obsolete: clarify documentation for succcessorssets
r20277 This function returns the full list of successor sets which is why it
returns a list of tuples and not just a single tuple. Each tuple is a valid
successors set. Not that (A,) may be a valid successors set for changeset A
(see below).
Pierre-Yves David
obsolete: compute successors set...
r18068
Sean Farley
obsolete: clarify documentation for succcessorssets
r20277 In most cases, a changeset A will have a single element (e.g. the changeset
A is replaced by A') in its successors set. Though, it is also common for a
changeset A to have no elements in its successor set (e.g. the changeset
has been pruned). Therefore, the returned list of successors sets will be
[(A',)] or [], respectively.
Pierre-Yves David
obsolete: compute successors set...
r18068
Sean Farley
obsolete: clarify documentation for succcessorssets
r20277 When a changeset A is split into A' and B', however, it will result in a
successors set containing more than a single element, i.e. [(A',B')].
Divergent changesets will result in multiple successors sets, i.e. [(A',),
(A'')].
Pierre-Yves David
obsolete: compute successors set...
r18068
Sean Farley
obsolete: clarify documentation for succcessorssets
r20277 If a changeset A is not obsolete, then it will conceptually have no
successors set. To distinguish this from a pruned changeset, the successor
set will only contain itself, i.e. [(A,)].
Pierre-Yves David
obsolete: compute successors set...
r18068
Sean Farley
obsolete: clarify documentation for succcessorssets
r20277 Finally, successors unknown locally are considered to be pruned (obsoleted
without any successors).
The optional `cache` parameter is a dictionary that may contain precomputed
successors sets. It is meant to reuse the computation of a previous call to
`successorssets` when multiple calls are made at the same time. The cache
dictionary is updated in place. The caller is responsible for its live
spawn. Code that makes multiple calls to `successorssets` *must* use this
cache mechanism or suffer terrible performances.
"""
Pierre-Yves David
obsolete: compute successors set...
r18068
succmarkers = repo.obsstore.successors
# Stack of nodes we search successors sets for
toproceed = [initialnode]
# set version of above list for fast loop detection
# element added to "toproceed" must be added here
stackedset = set(toproceed)
if cache is None:
cache = {}
# This while loop is the flattened version of a recursive search for
# successors sets
#
# def successorssets(x):
# successors = directsuccessors(x)
# ss = [[]]
# for succ in directsuccessors(x):
# # product as in itertools cartesian product
# ss = product(ss, successorssets(succ))
# return ss
#
# But we can not use plain recursive calls here:
# - that would blow the python call stack
# - obsolescence markers may have cycles, we need to handle them.
#
# The `toproceed` list act as our call stack. Every node we search
# successors set for are stacked there.
#
# The `stackedset` is set version of this stack used to check if a node is
# already stacked. This check is used to detect cycles and prevent infinite
# loop.
#
# successors set of all nodes are stored in the `cache` dictionary.
#
# After this while loop ends we use the cache to return the successors sets
# for the node requested by the caller.
while toproceed:
# Every iteration tries to compute the successors sets of the topmost
# node of the stack: CURRENT.
#
# There are four possible outcomes:
#
# 1) We already know the successors sets of CURRENT:
# -> mission accomplished, pop it from the stack.
# 2) Node is not obsolete:
# -> the node is its own successors sets. Add it to the cache.
# 3) We do not know successors set of direct successors of CURRENT:
# -> We add those successors to the stack.
# 4) We know successors sets of all direct successors of CURRENT:
# -> We can compute CURRENT successors set and add it to the
# cache.
#
current = toproceed[-1]
if current in cache:
# case (1): We already know the successors sets
stackedset.remove(toproceed.pop())
elif current not in succmarkers:
# case (2): The node is not obsolete.
if current in repo:
# We have a valid last successors.
cache[current] = [(current,)]
else:
# Final obsolete version is unknown locally.
# Do not count that as a valid successors
cache[current] = []
else:
# cases (3) and (4)
#
# We proceed in two phases. Phase 1 aims to distinguish case (3)
# from case (4):
#
# For each direct successors of CURRENT, we check whether its
# successors sets are known. If they are not, we stack the
# unknown node and proceed to the next iteration of the while
# loop. (case 3)
#
# During this step, we may detect obsolescence cycles: a node
# with unknown successors sets but already in the call stack.
# In such a situation, we arbitrary set the successors sets of
# the node to nothing (node pruned) to break the cycle.
#
Mads Kiilerich
spelling: fix some minor issues found by spell checker
r18644 # If no break was encountered we proceed to phase 2.
Pierre-Yves David
obsolete: compute successors set...
r18068 #
# Phase 2 computes successors sets of CURRENT (case 4); see details
# in phase 2 itself.
#
# Note the two levels of iteration in each phase.
# - The first one handles obsolescence markers using CURRENT as
# precursor (successors markers of CURRENT).
#
# Having multiple entry here means divergence.
#
# - The second one handles successors defined in each marker.
#
# Having none means pruned node, multiple successors means split,
# single successors are standard replacement.
#
Mads Kiilerich
obsolete: process markers in a stable order...
r18365 for mark in sorted(succmarkers[current]):
Pierre-Yves David
obsolete: compute successors set...
r18068 for suc in mark[1]:
if suc not in cache:
if suc in stackedset:
# cycle breaking
cache[suc] = []
else:
# case (3) If we have not computed successors sets
# of one of those successors we add it to the
# `toproceed` stack and stop all work for this
# iteration.
toproceed.append(suc)
stackedset.add(suc)
break
else:
continue
break
else:
# case (4): we know all successors sets of all direct
# successors
#
# Successors set contributed by each marker depends on the
# successors sets of all its "successors" node.
#
# Each different marker is a divergence in the obsolescence
Mads Kiilerich
spelling: fix some minor issues found by spell checker
r18644 # history. It contributes successors sets distinct from other
Pierre-Yves David
obsolete: compute successors set...
r18068 # markers.
#
# Within a marker, a successor may have divergent successors
# sets. In such a case, the marker will contribute multiple
# divergent successors sets. If multiple successors have
Mads Kiilerich
spelling: fixes from spell checker
r21024 # divergent successors sets, a Cartesian product is used.
Pierre-Yves David
obsolete: drop successors sets which are subset of another one...
r18069 #
# At the end we post-process successors sets to remove
# duplicated entry and successors set that are strict subset of
# another one.
Pierre-Yves David
obsolete: compute successors set...
r18068 succssets = []
Mads Kiilerich
obsolete: process markers in a stable order...
r18365 for mark in sorted(succmarkers[current]):
Pierre-Yves David
obsolete: compute successors set...
r18068 # successors sets contributed by this marker
markss = [[]]
for suc in mark[1]:
Pierre-Yves David
obsolete: drop successors sets which are subset of another one...
r18069 # cardinal product with previous successors
Pierre-Yves David
obsolete: compute successors set...
r18068 productresult = []
for prefix in markss:
for suffix in cache[suc]:
newss = list(prefix)
for part in suffix:
# do not duplicated entry in successors set
# first entry wins.
if part not in newss:
newss.append(part)
productresult.append(newss)
markss = productresult
succssets.extend(markss)
Pierre-Yves David
obsolete: drop successors sets which are subset of another one...
r18069 # remove duplicated and subset
seen = []
final = []
candidate = sorted(((set(s), s) for s in succssets if s),
key=lambda x: len(x[1]), reverse=True)
for setversion, listversion in candidate:
for seenset in seen:
if setversion.issubset(seenset):
break
else:
final.append(listversion)
seen.append(setversion)
final.reverse() # put small successors set first
cache[current] = final
Pierre-Yves David
obsolete: compute successors set...
r18068 return cache[initialnode]
Pierre-Yves David
obsolete: add the detection of bumped changeset....
r17828 def _knownrevs(repo, nodes):
"""yield revision numbers of known nodes passed in parameters
Unknown revisions are silently ignored."""
torev = repo.changelog.nodemap.get
for n in nodes:
rev = torev(n)
if rev is not None:
yield rev
# mapping of 'set-name' -> <function to compute this set>
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469 cachefuncs = {}
def cachefor(name):
"""Decorator to register a function as computing the cache for a set"""
def decorator(func):
assert name not in cachefuncs
cachefuncs[name] = func
return func
return decorator
Pierre-Yves David
obsolete: rename `getobscache` into `getrevs`...
r17825 def getrevs(repo, name):
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469 """Return the set of revision that belong to the <name> set
Such access may compute the set and cache it for future use"""
Pierre-Yves David
clfilter: unfilter computation of obsolescence related computation...
r18001 repo = repo.unfiltered()
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469 if not repo.obsstore:
return ()
if name not in repo.obsstore.caches:
repo.obsstore.caches[name] = cachefuncs[name](repo)
return repo.obsstore.caches[name]
# To be simple we need to invalidate obsolescence cache when:
#
# - new changeset is added:
# - public phase is changed
# - obsolescence marker are added
# - strip is used a repo
def clearobscaches(repo):
"""Remove all obsolescence related cache from a repo
This remove all cache in obsstore is the obsstore already exist on the
repo.
(We could be smarter here given the exact event that trigger the cache
clearing)"""
# only clear cache is there is obsstore data in this repo
if 'obsstore' in repo._filecache:
repo.obsstore.caches.clear()
@cachefor('obsolete')
def _computeobsoleteset(repo):
"""the set of obsolete revisions"""
obs = set()
Pierre-Yves David
performance: speedup computation of obsolete revisions...
r18271 getrev = repo.changelog.nodemap.get
getphase = repo._phasecache.phase
Mads Kiilerich
cleanup: avoid local vars shadowing imports...
r22200 for n in repo.obsstore.successors:
rev = getrev(n)
Pierre-Yves David
performance: speedup computation of obsolete revisions...
r18271 if rev is not None and getphase(repo, rev):
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469 obs.add(rev)
Pierre-Yves David
performance: speedup computation of obsolete revisions...
r18271 return obs
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469
@cachefor('unstable')
def _computeunstableset(repo):
"""the set of non obsolete revisions with obsolete parents"""
Pierre-Yves David
performance: speedup computation of unstable revisions...
r18275 # revset is not efficient enough here
# we do (obsolete()::) - obsolete() by hand
obs = getrevs(repo, 'obsolete')
if not obs:
return set()
cl = repo.changelog
return set(r for r in cl.descendants(obs) if r not in obs)
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469
@cachefor('suspended')
def _computesuspendedset(repo):
"""the set of obsolete parents with non obsolete descendants"""
Pierre-Yves David
performance: speedup computation of suspended revisions...
r18276 suspended = repo.changelog.ancestors(getrevs(repo, 'unstable'))
return set(r for r in getrevs(repo, 'obsolete') if r in suspended)
Pierre-Yves David
obsolete: introduce caches for all meaningful sets...
r17469
@cachefor('extinct')
def _computeextinctset(repo):
"""the set of obsolete parents without non obsolete descendants"""
Pierre-Yves David
performance: speedup computation of extinct revisions...
r18277 return getrevs(repo, 'obsolete') - getrevs(repo, 'suspended')
Pierre-Yves David
obsolete: add a high level function to create an obsolete marker...
r17474
Pierre-Yves David
obsolete: add the detection of bumped changeset....
r17828
@cachefor('bumped')
def _computebumpedset(repo):
"""the set of revs trying to obsolete public revisions"""
Pierre-Yves David
obsolete: order of magnitude speedup in _computebumpedset...
r20207 bumped = set()
Mads Kiilerich
spelling: fixes from spell checker
r21024 # util function (avoid attribute lookup in the loop)
Pierre-Yves David
obsolete: order of magnitude speedup in _computebumpedset...
r20207 phase = repo._phasecache.phase # would be faster to grab the full list
public = phases.public
cl = repo.changelog
torev = cl.nodemap.get
obs = getrevs(repo, 'obsolete')
for rev in repo:
# We only evaluate mutable, non-obsolete revision
if (public < phase(repo, rev)) and (rev not in obs):
node = cl.node(rev)
# (future) A cache of precursors may worth if split is very common
for pnode in allprecursors(repo.obsstore, [node],
ignoreflags=bumpedfix):
prev = torev(pnode) # unfiltered! but so is phasecache
if (prev is not None) and (phase(repo, prev) <= public):
# we have a public precursors
bumped.add(rev)
break # Next draft!
return bumped
Pierre-Yves David
obsolete: add the detection of bumped changeset....
r17828
Pierre-Yves David
obsolete: detect divergent changesets...
r18070 @cachefor('divergent')
def _computedivergentset(repo):
"""the set of rev that compete to be the final successors of some revision.
"""
divergent = set()
obsstore = repo.obsstore
newermap = {}
for ctx in repo.set('(not public()) - obsolete()'):
mark = obsstore.precursors.get(ctx.node(), ())
toprocess = set(mark)
while toprocess:
prec = toprocess.pop()[0]
if prec not in newermap:
successorssets(repo, prec, newermap)
newer = [n for n in newermap[prec] if n]
if len(newer) > 1:
divergent.add(ctx.rev())
break
toprocess.update(obsstore.precursors.get(prec, ()))
return divergent
Pierre-Yves David
obsolete: add a date argument to the `createmarkers` function...
r22219 def createmarkers(repo, relations, flag=0, date=None, metadata=None):
Pierre-Yves David
obsolete: add a high level function to create an obsolete marker...
r17474 """Add obsolete markers between changesets in a repo
Pierre-Yves David
createmarkers: allow to pass metadata for a marker only...
r20517 <relations> must be an iterable of (<old>, (<new>, ...)[,{metadata}])
Mads Kiilerich
spelling: fixes from spell checker
r21024 tuple. `old` and `news` are changectx. metadata is an optional dictionary
Pierre-Yves David
createmarkers: allow to pass metadata for a marker only...
r20517 containing metadata for this marker only. It is merged with the global
metadata specified through the `metadata` argument of this function,
Pierre-Yves David
obsolete: add a high level function to create an obsolete marker...
r17474
Trying to obsolete a public changeset will raise an exception.
Current user and date are used except if specified otherwise in the
metadata attribute.
This function operates within a transaction of its own, but does
not take any lock on the repo.
"""
# prepare metadata
if metadata is None:
metadata = {}
if 'user' not in metadata:
metadata['user'] = repo.ui.username()
tr = repo.transaction('add-obsolescence-marker')
try:
Pierre-Yves David
createmarkers: allow to pass metadata for a marker only...
r20517 for rel in relations:
prec = rel[0]
sucs = rel[1]
localmetadata = metadata.copy()
if 2 < len(rel):
localmetadata.update(rel[2])
Pierre-Yves David
obsolete: add a high level function to create an obsolete marker...
r17474 if not prec.mutable():
raise util.Abort("cannot obsolete immutable changeset: %s"
% prec)
nprec = prec.node()
nsucs = tuple(s.node() for s in sucs)
Pierre-Yves David
createmarkers: automatically record the parent of pruned changesets...
r22256 npare = None
if not nsucs:
npare = tuple(p.node() for p in prec.parents())
Pierre-Yves David
obsolete: add a high level function to create an obsolete marker...
r17474 if nprec in nsucs:
raise util.Abort("changeset %s cannot obsolete itself" % prec)
Pierre-Yves David
createmarkers: automatically record the parent of pruned changesets...
r22256 repo.obsstore.create(tr, nprec, nsucs, flag, parents=npare,
date=date, metadata=localmetadata)
Pierre-Yves David
clfilter: add a cache on repo for set of revision to filter for a given set....
r18101 repo.filteredrevcache.clear()
Pierre-Yves David
obsolete: add a high level function to create an obsolete marker...
r17474 tr.close()
finally:
tr.release()