##// END OF EJS Templates
hook: move stdio redirection to context manager...
hook: move stdio redirection to context manager The old code was checking stdio redirection in a loop. This didn't make sense. The pattern is better expressed as a context manager IMO, so this commit refactors it to be one. Differential Revision: https://phab.mercurial-scm.org/D8338

File last commit:

r45140:3cbbfd0b default
r45140:3cbbfd0b default
Show More
hook.py
336 lines | 10.7 KiB | text/x-python | PythonLexer
Matt Mackall
hooks: separate hook code into a separate module
r4622 # hook.py - hook support for mercurial
#
# Copyright 2007 Matt Mackall <mpm@selenic.com>
#
Martin Geisler
updated license to be explicit about GPL version 2
r8225 # This software may be used and distributed according to the terms of the
Matt Mackall
Update license to GPLv2+
r10263 # GNU General Public License version 2 or any later version.
Matt Mackall
hooks: separate hook code into a separate module
r4622
Gregory Szorc
hook: use absolute_import
r25953 from __future__ import absolute_import
Gregory Szorc
hook: move stdio redirection to context manager...
r45140 import contextlib
Gregory Szorc
hook: use absolute_import
r25953 import os
import sys
from .i18n import _
Gregory Szorc
py3: manually import getattr where it is needed...
r43359 from .pycompat import getattr
Gregory Szorc
hook: use absolute_import
r25953 from . import (
demandimport,
Pulkit Goyal
py3: convert exception to bytes to pass into ui.warn()...
r32642 encoding,
Gregory Szorc
hook: use absolute_import
r25953 error,
extensions,
Pulkit Goyal
py3: use pycompat.getcwd() instead of os.getcwd()...
r30519 pycompat,
Gregory Szorc
hook: use absolute_import
r25953 util,
)
Yuya Nishihara
procutil: bulk-replace util.std* to point to new module
r37137 from .utils import (
procutil,
Martin von Zweigbergk
procutil: move mainfrozen() to new resourceutil.py...
r44067 resourceutil,
Augie Fackler
hook: use stringutil.pprint instead of reinventing it...
r37769 stringutil,
Yuya Nishihara
procutil: bulk-replace util.std* to point to new module
r37137 )
Matt Mackall
hooks: separate hook code into a separate module
r4622
Augie Fackler
formatting: blacken the codebase...
r43346
hindlemail
filemerge: support specifying a python function to custom merge-tools...
r38052 def pythonhook(ui, repo, htype, hname, funcname, args, throw):
Matt Mackall
hooks: separate hook code into a separate module
r4622 '''call python hook. hook is callable object, looked up as
name in python module. if callable returns "true", hook
fails, else passes. if hook raises exception, treated as
hook failure. exception propagates if throw is "true".
reason for "true" meaning "hook failed" is so that
unmodified commands (e.g. mercurial.commands.update) can
be run as hooks without wrappers to convert return values.'''
Augie Fackler
hook: restore use of callable() since it was readded in Python 3.2
r21797 if callable(funcname):
Mads Kiilerich
hooks: for python hooks, consistently use __name__ etc as name, not the repr...
r20548 obj = funcname
Augie Fackler
cleanup: remove pointless r-prefixes on double-quoted strings...
r43809 funcname = pycompat.sysbytes(obj.__module__ + "." + obj.__name__)
Mads Kiilerich
hooks: for python hooks, consistently use __name__ etc as name, not the repr...
r20548 else:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 d = funcname.rfind(b'.')
Matt Mackall
hooks: separate hook code into a separate module
r4622 if d == -1:
Siddharth Agarwal
hook: raise a separate exception for when loading a hook fails...
r26692 raise error.HookLoadError(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b'%s hook is invalid: "%s" not in a module')
Augie Fackler
formatting: blacken the codebase...
r43346 % (hname, funcname)
)
Matt Mackall
hooks: separate hook code into a separate module
r4622 modname = funcname[:d]
Sune Foldager
hook: fix bug (reuse of variable) introduced in 872d49dd577a...
r10103 oldpaths = sys.path
Martin von Zweigbergk
procutil: move mainfrozen() to new resourceutil.py...
r44067 if resourceutil.mainfrozen():
Steve Borho
hook: fix full path imports on Windows (issue1779)...
r9332 # binary installs require sys.path manipulation
Sune Foldager
hook: fix bug (reuse of variable) introduced in 872d49dd577a...
r10103 modpath, modfile = os.path.split(modname)
if modpath and modfile:
sys.path = sys.path[:] + [modpath]
modname = modfile
Jordi Gutiérrez Hermoso
hooks: replace if-try-finally with a "with" statement...
r25328 with demandimport.deactivated():
Matt Mackall
hooks: separate hook code into a separate module
r4622 try:
Gregory Szorc
py3: use system strings when calling __import__...
r36125 obj = __import__(pycompat.sysstr(modname))
Siddharth Agarwal
hook: don't crash on syntax errors in python hooks...
r28109 except (ImportError, SyntaxError):
Siddharth Agarwal
hook: use sys.exc_info rather than the deprecated equivalents...
r28078 e1 = sys.exc_info()
Jordi Gutiérrez Hermoso
hooks: replace if-try-finally with a "with" statement...
r25328 try:
# extensions are loaded with hgext_ prefix
Augie Fackler
cleanup: remove pointless r-prefixes on double-quoted strings...
r43809 obj = __import__("hgext_%s" % pycompat.sysstr(modname))
Siddharth Agarwal
hook: don't crash on syntax errors in python hooks...
r28109 except (ImportError, SyntaxError):
Siddharth Agarwal
hook: use sys.exc_info rather than the deprecated equivalents...
r28078 e2 = sys.exc_info()
Jordi Gutiérrez Hermoso
hooks: replace if-try-finally with a "with" statement...
r25328 if ui.tracebackflag:
Augie Fackler
formatting: blacken the codebase...
r43346 ui.warn(
_(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'exception from first failed import '
b'attempt:\n'
Augie Fackler
formatting: blacken the codebase...
r43346 )
)
Jordi Gutiérrez Hermoso
hooks: replace if-try-finally with a "with" statement...
r25328 ui.traceback(e1)
if ui.tracebackflag:
Augie Fackler
formatting: blacken the codebase...
r43346 ui.warn(
_(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'exception from second failed import '
b'attempt:\n'
Augie Fackler
formatting: blacken the codebase...
r43346 )
)
Jordi Gutiérrez Hermoso
hooks: replace if-try-finally with a "with" statement...
r25328 ui.traceback(e2)
Siddharth Agarwal
hook: for python hook ImportErrors, add note to run with --traceback...
r28080
if not ui.tracebackflag:
tracebackhint = _(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'run with --traceback for stack trace'
Augie Fackler
formatting: blacken the codebase...
r43346 )
Siddharth Agarwal
hook: for python hook ImportErrors, add note to run with --traceback...
r28080 else:
tracebackhint = None
Siddharth Agarwal
hook: raise a separate exception for when loading a hook fails...
r26692 raise error.HookLoadError(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b'%s hook is invalid: import of "%s" failed')
Augie Fackler
formatting: blacken the codebase...
r43346 % (hname, modname),
hint=tracebackhint,
)
Steve Borho
hook: fix full path imports on Windows (issue1779)...
r9332 sys.path = oldpaths
Matt Mackall
hooks: separate hook code into a separate module
r4622 try:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 for p in funcname.split(b'.')[1:]:
Matt Mackall
hooks: separate hook code into a separate module
r4622 obj = getattr(obj, p)
Benoit Boissinot
remove unused variables
r7280 except AttributeError:
Siddharth Agarwal
hook: raise a separate exception for when loading a hook fails...
r26692 raise error.HookLoadError(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b'%s hook is invalid: "%s" is not defined')
% (hname, funcname)
Augie Fackler
formatting: blacken the codebase...
r43346 )
Augie Fackler
hook: restore use of callable() since it was readded in Python 3.2
r21797 if not callable(obj):
Siddharth Agarwal
hook: raise a separate exception for when loading a hook fails...
r26692 raise error.HookLoadError(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b'%s hook is invalid: "%s" is not callable')
Augie Fackler
formatting: blacken the codebase...
r43346 % (hname, funcname)
)
Mads Kiilerich
hooks: move logging of hook name to after we have found the hook...
r20547
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.note(_(b"calling hook %s: %s\n") % (hname, funcname))
Simon Farnsworth
mercurial: switch to util.timer for all interval timings...
r30975 starttime = util.timer()
Mads Kiilerich
hooks: move logging of hook name to after we have found the hook...
r20547
Matt Mackall
hooks: separate hook code into a separate module
r4622 try:
Pulkit Goyal
py3: handle keyword arguments correctly in hook.py...
r35358 r = obj(ui=ui, repo=repo, hooktype=htype, **pycompat.strkwargs(args))
Gregory Szorc
global: mass rewrite to use modern exception syntax...
r25660 except Exception as exc:
Pierre-Yves David
error: get Abort from 'error' instead of 'util'...
r26587 if isinstance(exc, error.Abort):
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.warn(_(b'error: %s hook failed: %s\n') % (hname, exc.args[0]))
Matt Mackall
hooks: use try/except/finally
r25084 else:
Augie Fackler
formatting: blacken the codebase...
r43346 ui.warn(
Martin von Zweigbergk
cleanup: join string literals that are already on one line...
r43387 _(b'error: %s hook raised an exception: %s\n')
Augie Fackler
formatting: blacken the codebase...
r43346 % (hname, stringutil.forcebytestr(exc))
)
Matt Mackall
hooks: use try/except/finally
r25084 if throw:
Matt Mackall
hooks: separate hook code into a separate module
r4622 raise
Siddharth Agarwal
hook: for python hook exceptions, add note to run with --traceback...
r28108 if not ui.tracebackflag:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.warn(_(b'(run with --traceback for stack trace)\n'))
Matt Mackall
hooks: use try/except/finally
r25084 ui.traceback()
Siddharth Agarwal
hook: for python hooks, also return whether an exception was raised...
r26739 return True, True
Idan Kamara
hooks: redirect stdout/err/in to the ui descriptors when calling python hooks...
r14889 finally:
Simon Farnsworth
mercurial: switch to util.timer for all interval timings...
r30975 duration = util.timer() - starttime
Augie Fackler
formatting: blacken the codebase...
r43346 ui.log(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'pythonhook',
b'pythonhook-%s: %s finished in %0.2f seconds\n',
Augie Fackler
formatting: blacken the codebase...
r43346 htype,
funcname,
duration,
)
Matt Mackall
hooks: separate hook code into a separate module
r4622 if r:
if throw:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 raise error.HookAbort(_(b'%s hook failed') % hname)
ui.warn(_(b'warning: %s hook failed\n') % hname)
Siddharth Agarwal
hook: for python hooks, also return whether an exception was raised...
r26739 return r, False
Matt Mackall
hooks: separate hook code into a separate module
r4622
Augie Fackler
formatting: blacken the codebase...
r43346
Pierre-Yves David
hook: provide hook type information to external hook...
r31746 def _exthook(ui, repo, htype, name, cmd, args, throw):
Simon Farnsworth
mercurial: switch to util.timer for all interval timings...
r30975 starttime = util.timer()
Matt Mackall
Introduce HG_PREPEND to solve pretxn races...
r7787 env = {}
FUJIWARA Katsunori
hook: centralize passing HG_PENDING to external hook process...
r26751
# make in-memory changes visible to external process
Sietse Brouwer
dirstate: don't write repo.currenttransaction to repo.dirstate if repo...
r27228 if repo is not None:
tr = repo.currenttransaction()
repo.dirstate.write(tr)
if tr and tr.writepending():
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 env[b'HG_PENDING'] = repo.root
env[b'HG_HOOKTYPE'] = htype
env[b'HG_HOOKNAME'] = name
FUJIWARA Katsunori
hook: centralize passing HG_PENDING to external hook process...
r26751
Gregory Szorc
py3: finish porting iteritems() to pycompat and remove source transformer...
r43376 for k, v in pycompat.iteritems(args):
Augie Fackler
hook: restore use of callable() since it was readded in Python 3.2
r21797 if callable(v):
Matt Mackall
Introduce HG_PREPEND to solve pretxn races...
r7787 v = v()
Augie Fackler
hook: also use pprint on lists for stable output on py2/3...
r37770 if isinstance(v, (dict, list)):
Yuya Nishihara
stringutil: flip the default of pprint() to bprefix=False...
r37961 v = stringutil.pprint(v)
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 env[b'HG_' + k.upper()] = v
Matt Mackall
Introduce HG_PREPEND to solve pretxn races...
r7787
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 if ui.configbool(b'hooks', b'tonative.%s' % name, False):
Matt Harbison
hook: only print the note about native cmd translation if it actually changes...
r38746 oldcmd = cmd
Matt Harbison
hook: add support for disabling the shell to native command translation...
r38648 cmd = procutil.shelltonative(cmd, env)
Matt Harbison
hook: only print the note about native cmd translation if it actually changes...
r38746 if cmd != oldcmd:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.note(_(b'converting hook "%s" to native\n') % name)
Matt Harbison
hooks: allow Unix style environment variables on external Windows hooks...
r38503
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.note(_(b"running hook %s: %s\n") % (name, cmd))
Matt Harbison
hooks: allow Unix style environment variables on external Windows hooks...
r38503
Matt Mackall
hooks: fix pre- and post- hooks specified in .hg/hgrc...
r5869 if repo:
cwd = repo.root
else:
Matt Harbison
py3: rename pycompat.getcwd() to encoding.getcwd() (API)...
r39843 cwd = encoding.getcwd()
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 r = ui.system(cmd, environ=env, cwd=cwd, blockedtag=b'exthook-%s' % (name,))
Durham Goode
blackbox: logs python and extension hooks via ui.log()...
r18671
Simon Farnsworth
mercurial: switch to util.timer for all interval timings...
r30975 duration = util.timer() - starttime
Augie Fackler
formatting: blacken the codebase...
r43346 ui.log(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 b'exthook',
b'exthook-%s: %s finished in %0.2f seconds\n',
Augie Fackler
formatting: blacken the codebase...
r43346 name,
cmd,
duration,
)
Matt Mackall
hooks: separate hook code into a separate module
r4622 if r:
Yuya Nishihara
procutil: make explainexit() simply return a message (API)...
r37481 desc = procutil.explainexit(r)
Matt Mackall
hooks: separate hook code into a separate module
r4622 if throw:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 raise error.HookAbort(_(b'%s hook %s') % (name, desc))
ui.warn(_(b'warning: %s hook %s\n') % (name, desc))
Matt Mackall
hooks: separate hook code into a separate module
r4622 return r
Augie Fackler
formatting: blacken the codebase...
r43346
Pierre-Yves David
hook: report untrusted hooks as failure (issue5110) (BC)...
r28938 # represent an untrusted hook command
_fromuntrusted = object()
Augie Fackler
formatting: blacken the codebase...
r43346
Matt Zuba
hooks: prioritize run order of hooks...
r15896 def _allhooks(ui):
Pierre-Yves David
hook: split config reading further...
r28937 """return a list of (hook-id, cmd) pairs sorted by priority"""
hooks = _hookitems(ui)
Pierre-Yves David
hook: report untrusted hooks as failure (issue5110) (BC)...
r28938 # Be careful in this section, propagating the real commands from untrusted
# sources would create a security vulnerability, make sure anything altered
# in that section uses "_fromuntrusted" as its command.
untrustedhooks = _hookitems(ui, _untrusted=True)
for name, value in untrustedhooks.items():
trustedvalue = hooks.get(name, (None, None, name, _fromuntrusted))
if value != trustedvalue:
(lp, lo, lk, lv) = trustedvalue
hooks[name] = (lp, lo, lk, _fromuntrusted)
# (end of the security sensitive section)
Pierre-Yves David
hook: split config reading further...
r28937 return [(k, v) for p, o, k, v in sorted(hooks.values())]
Augie Fackler
formatting: blacken the codebase...
r43346
Pierre-Yves David
hook: report untrusted hooks as failure (issue5110) (BC)...
r28938 def _hookitems(ui, _untrusted=False):
Pierre-Yves David
hook: split config reading further...
r28937 """return all hooks items ready to be sorted"""
Pierre-Yves David
hook: small refactor to store hooks as dict instead of list...
r28936 hooks = {}
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 for name, cmd in ui.configitems(b'hooks', untrusted=_untrusted):
if name.startswith(b'priority.') or name.startswith(b'tonative.'):
Matt Harbison
hook: add support for disabling the shell to native command translation...
r38648 continue
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 priority = ui.configint(b'hooks', b'priority.%s' % name, 0)
Matt Harbison
hook: add support for disabling the shell to native command translation...
r38648 hooks[name] = (-priority, len(hooks), name, cmd)
Pierre-Yves David
hook: split config reading further...
r28937 return hooks
Matt Zuba
hooks: prioritize run order of hooks...
r15896
Augie Fackler
formatting: blacken the codebase...
r43346
Matt Mackall
hook: redirect stdout to stderr for ssh and http servers
r5833 _redirect = False
Augie Fackler
formatting: blacken the codebase...
r43346
Matt Mackall
hook: redirect stdout to stderr for ssh and http servers
r5833 def redirect(state):
Alexis S. L. Carvalho
hook.py: fix redirections introduced by 323b9c55b328...
r6266 global _redirect
Matt Mackall
hook: redirect stdout to stderr for ssh and http servers
r5833 _redirect = state
Augie Fackler
formatting: blacken the codebase...
r43346
Boris Feld
hook: add a 'hashook' function to test for hook existence...
r34688 def hashook(ui, htype):
"""return True if a hook is configured for 'htype'"""
if not ui.callhooks:
return False
for hname, cmd in _allhooks(ui):
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 if hname.split(b'.')[0] == htype and cmd:
Boris Feld
hook: add a 'hashook' function to test for hook existence...
r34688 return True
return False
Augie Fackler
formatting: blacken the codebase...
r43346
Pierre-Yves David
hook: use 'htype' in 'hook'...
r31745 def hook(ui, repo, htype, throw=False, **args):
Idan Kamara
ui: add a variable to control whether hooks should be called...
r17048 if not ui.callhooks:
return False
Siddharth Agarwal
hook: factor out determination of hooks from running them...
r26737 hooks = []
for hname, cmd in _allhooks(ui):
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 if hname.split(b'.')[0] == htype and cmd:
Siddharth Agarwal
hook: factor out determination of hooks from running them...
r26737 hooks.append((hname, cmd))
Pierre-Yves David
hook: use 'htype' in 'hook'...
r31745 res = runhooks(ui, repo, htype, hooks, throw=throw, **args)
Siddharth Agarwal
hook.runhooks: return a dict of result values...
r26738 r = False
for hname, cmd in hooks:
Siddharth Agarwal
hook: for python hooks, also return whether an exception was raised...
r26739 r = res[hname][0] or r
Siddharth Agarwal
hook.runhooks: return a dict of result values...
r26738 return r
Siddharth Agarwal
hook: factor out determination of hooks from running them...
r26737
Augie Fackler
formatting: blacken the codebase...
r43346
Gregory Szorc
hook: move stdio redirection to context manager...
r45140 @contextlib.contextmanager
def redirect_stdio():
"""Redirects stdout to stderr, if possible."""
oldstdout = -1
try:
if _redirect:
try:
stdoutno = procutil.stdout.fileno()
stderrno = procutil.stderr.fileno()
# temporarily redirect stdout to stderr, if possible
if stdoutno >= 0 and stderrno >= 0:
procutil.stdout.flush()
oldstdout = os.dup(stdoutno)
os.dup2(stderrno, stdoutno)
except (OSError, AttributeError):
# files seem to be bogus, give up on redirecting (WSGI, etc)
pass
yield
finally:
# The stderr is fully buffered on Windows when connected to a pipe.
# A forcible flush is required to make small stderr data in the
# remote side available to the client immediately.
procutil.stderr.flush()
if _redirect and oldstdout >= 0:
procutil.stdout.flush() # write hook output to stderr fd
os.dup2(oldstdout, stdoutno)
os.close(oldstdout)
Pierre-Yves David
hook: use 'htype' in 'runhooks'...
r31744 def runhooks(ui, repo, htype, hooks, throw=False, **args):
Pulkit Goyal
py3: convert keys of kwargs back to bytes using pycompat.byteskwargs()
r32897 args = pycompat.byteskwargs(args)
Siddharth Agarwal
hook.runhooks: return a dict of result values...
r26738 res = {}
Matt Mackall
hook: redirect stdout to stderr for ssh and http servers
r5833
Gregory Szorc
hook: move stdio redirection to context manager...
r45140 with redirect_stdio():
Siddharth Agarwal
hook: factor out determination of hooks from running them...
r26737 for hname, cmd in hooks:
Pierre-Yves David
hook: report untrusted hooks as failure (issue5110) (BC)...
r28938 if cmd is _fromuntrusted:
if throw:
raise error.HookAbort(
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 _(b'untrusted hook %s not executed') % hname,
hint=_(b"see 'hg help config.trusted'"),
Augie Fackler
formatting: blacken the codebase...
r43346 )
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.warn(_(b'warning: untrusted hook %s not executed\n') % hname)
Pierre-Yves David
hook: report untrusted hooks as failure (issue5110) (BC)...
r28938 r = 1
raised = False
elif callable(cmd):
Augie Fackler
formatting: blacken the codebase...
r43346 r, raised = pythonhook(ui, repo, htype, hname, cmd, args, throw)
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 elif cmd.startswith(b'python:'):
if cmd.count(b':') >= 2:
path, cmd = cmd[7:].rsplit(b':', 1)
Alexander Solovyov
hook: assume relative path to hook is given from repo root
r13118 path = util.expandpath(path)
Matt Mackall
hook: fix import path handling for repo=None
r13119 if repo:
path = os.path.join(repo.root, path)
Simon Heimberg
hooks: print out more information when loading a python hook fails...
r17217 try:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 mod = extensions.loadpath(path, b'hghook.%s' % hname)
Simon Heimberg
hooks: print out more information when loading a python hook fails...
r17217 except Exception:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 ui.write(_(b"loading %s hook failed:\n") % hname)
Simon Heimberg
hooks: print out more information when loading a python hook fails...
r17217 raise
Alexander Solovyov
ability to load hooks from arbitrary python module
r7916 hookfn = getattr(mod, cmd)
else:
hookfn = cmd[7:].strip()
Augie Fackler
formatting: blacken the codebase...
r43346 r, raised = pythonhook(
ui, repo, htype, hname, hookfn, args, throw
)
Jesse Long
hooks: restore io correctly on exception
r7416 else:
Pierre-Yves David
hook: provide hook type information to external hook...
r31746 r = _exthook(ui, repo, htype, hname, cmd, args, throw)
Siddharth Agarwal
hook: for python hooks, also return whether an exception was raised...
r26739 raised = False
Siddharth Agarwal
hook.runhooks: return a dict of result values...
r26738
Siddharth Agarwal
hook: for python hooks, also return whether an exception was raised...
r26739 res[hname] = r, raised
Alexis S. L. Carvalho
hook.py: fix redirections introduced by 323b9c55b328...
r6266
Siddharth Agarwal
hook.runhooks: return a dict of result values...
r26738 return res