##// END OF EJS Templates
typing: attempt to remove @overloads in the platform module for stdlib methods...
typing: attempt to remove @overloads in the platform module for stdlib methods This is mostly successful, as examining util.pyi, posix.pyi, and windows.pyi after a pytype run shows that the type overloads for `oslink`, `readlink`, `removedirs`, `rename`, `split`, and `unlink` have been removed. (Some of these still have an @overload, but the differences are the variable names, not the types.) However, @overloads remain for `abspath` and `normpath` for some reason. It's useful to redefine these methods for the type checking phase because in addition to excluding str and PathLike variants, some of these functions have optional args in stdlib that aren't implemented in the custom implementation on Windows, and we want the type checking to flag that instead of assuming it's an allowable overload everywhere. One last quirk I noticed that I can't explain- `pycompat.TYPE_CHECKING` is always False, so the conditionals need to check `typing.TYPE_CHECKING` directly. I tried dropping the custom code for assigning `pycompat.TYPE_CHECKING` and simply did `from typing import TYPE_CHECKING` directly in pycompat.py, and used `pycompat.TYPE_CHECKING` for the conditional here... and pytype complained that `pycompat` doesn't have the `TYPE_CHECKING` variable.

File last commit:

r49801:642e31cb default
r50713:3fd5824f default
Show More
util.py
37 lines | 1009 B | text/x-python | PythonLexer
Pulkit Goyal
interfaceutil: move to interfaces/...
r43079 # util.py - Utilities for declaring interfaces.
#
# Copyright 2018 Gregory Szorc <gregory.szorc@gmail.com>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
# zope.interface imposes a run-time cost due to module import overhead and
# bookkeeping for declaring interfaces. So, we use stubs for various
# zope.interface primitives unless instructed otherwise.
Augie Fackler
formatting: blacken the codebase...
r43346 from .. import encoding
Pulkit Goyal
interfaceutil: move to interfaces/...
r43079
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 if encoding.environ.get(b'HGREALINTERFACES'):
Augie Fackler
formatting: blacken the codebase...
r43346 from ..thirdparty.zope import interface as zi
Pulkit Goyal
interfaceutil: move to interfaces/...
r43079
Attribute = zi.Attribute
Interface = zi.Interface
implementer = zi.implementer
else:
Augie Fackler
formatting: blacken the codebase...
r43346
Gregory Szorc
py3: use class X: instead of class X(object):...
r49801 class Attribute:
Augie Fackler
formatting: byteify all mercurial/ and hgext/ string literals...
r43347 def __init__(self, __name__, __doc__=b''):
Pulkit Goyal
interfaceutil: move to interfaces/...
r43079 pass
Gregory Szorc
py3: use class X: instead of class X(object):...
r49801 class Interface:
Augie Fackler
formatting: blacken the codebase...
r43346 def __init__(
self, name, bases=(), attrs=None, __doc__=None, __module__=None
):
Pulkit Goyal
interfaceutil: move to interfaces/...
r43079 pass
def implementer(*ifaces):
def wrapper(cls):
return cls
return wrapper