upstream/mercurial-mirror Files · contrib/chg/util.h

lfs: verify lfs object content when transferring to and from the remote store...

lfs: verify lfs object content when transferring to and from the remote store This avoids inserting corrupt files into the usercache, and local and remote stores. One down side is that the bad file won't be available locally for forensic purposes after a remote download. I'm thinking about adding an 'incoming' directory to the local lfs store to handle the download, and then move it to the 'objects' directory after it passes verification. That would have the additional benefit of not concatenating each transfer chunk in memory until the full file is transferred. Verification isn't needed when the data is passed back through the revlog interface or when the oid was just calculated, but otherwise it is on by default. The additional overhead should be well worth avoiding problems with file based remote stores, or buggy lfs servers. Having two different verify functions is a little sad, but the full data of the blob is mostly passed around in memory, because that's what the revlog interface wants. The upload function, however, chunks up the data. It would be ideal if that was how the content is always handled, but that's probably a huge project. I don't really like printing the long hash, but `hg debugdata` isn't a public interface, and is the only way to get it. The filelog and revision info is nowhere near this area, so recommending `hg verify` is the easiest thing to do.

Yuya Nishihara - - Load All Authors

File last commit:

r29440:009cc6c8 default


                r35492:417e8e04

default

Download file

             util.h
        
                    35 lines
            
             | 856 B
            
                | text/x-c
            
             |
                CLexer
            
             / contrib / chg / util.h
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      /*

       * Utility functions

       *

       * Copyright (c) 2011 Yuya Nishihara <yuya@tcha.org>

       *

       * This software may be used and distributed according to the terms of the

       * GNU General Public License version 2 or any later version.

       */

      #ifndef UTIL_H_

      #define UTIL_H_

      #ifdef __GNUC__

      #define PRINTF_FORMAT_ __attribute__((format(printf, 1, 2)))

        Yuya Nishihara
    
chg: silence warning of unused parameter 'sig'

              r29440
            
      #define UNUSED_ __attribute__((unused))

        Jun Wu
    
chg: define PRINTF_FORMAT_ for non gnu C compiler...

              r28604
            
      #else

      #define PRINTF_FORMAT_

        Yuya Nishihara
    
chg: silence warning of unused parameter 'sig'

              r29440
            
      #define UNUSED_

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      #endif

      void abortmsg(const char *fmt, ...) PRINTF_FORMAT_;

        Jun Wu
    
chg: add util function abortmsgerrno to print error with errno...

              r28788
            
      void abortmsgerrno(const char *fmt, ...) PRINTF_FORMAT_;

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
        Jun Wu
    
chg: use color in debug/error messages conditionally...

              r28787
            
      void enablecolor(void);

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      void enabledebugmsg(void);

      void debugmsg(const char *fmt, ...) PRINTF_FORMAT_;

        Jun Wu
    
chg: add fchdirx as a utility function...

              r28854
            
      void fchdirx(int dirfd);

        Jun Wu
    
chg: extract the logic of setting FD_CLOEXEC to a utility function...

              r28855
            
      void fsetcloexec(int fd);

        Jun Wu
    
chg: add utility functions mallocx, reallocx...

              r28165
            
      void *mallocx(size_t size);

      void *reallocx(void *ptr, size_t size);

        Yuya Nishihara
    
chg: import frontend sources...

              r28060
            
      int runshellcmd(const char *cmd, const char *envp[], const char *cwd);

      #endif  /* UTIL_H_ */

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Yuya Nishihara chg: import frontend sources...	r28060	/*
		* Utility functions
		*
		* Copyright (c) 2011 Yuya Nishihara <yuya@tcha.org>
		*
		* This software may be used and distributed according to the terms of the
		* GNU General Public License version 2 or any later version.
		*/

		#ifndef UTIL_H_
		#define UTIL_H_

		#ifdef __GNUC__
		#define PRINTF_FORMAT_ __attribute__((format(printf, 1, 2)))
Yuya Nishihara chg: silence warning of unused parameter 'sig'	r29440	#define UNUSED_ __attribute__((unused))
Jun Wu chg: define PRINTF_FORMAT_ for non gnu C compiler...	r28604	#else
		#define PRINTF_FORMAT_
Yuya Nishihara chg: silence warning of unused parameter 'sig'	r29440	#define UNUSED_
Yuya Nishihara chg: import frontend sources...	r28060	#endif

		void abortmsg(const char *fmt, ...) PRINTF_FORMAT_;
Jun Wu chg: add util function abortmsgerrno to print error with errno...	r28788	void abortmsgerrno(const char *fmt, ...) PRINTF_FORMAT_;
Yuya Nishihara chg: import frontend sources...	r28060
Jun Wu chg: use color in debug/error messages conditionally...	r28787	void enablecolor(void);
Yuya Nishihara chg: import frontend sources...	r28060	void enabledebugmsg(void);
		void debugmsg(const char *fmt, ...) PRINTF_FORMAT_;

Jun Wu chg: add fchdirx as a utility function...	r28854	void fchdirx(int dirfd);
Jun Wu chg: extract the logic of setting FD_CLOEXEC to a utility function...	r28855	void fsetcloexec(int fd);
Jun Wu chg: add utility functions mallocx, reallocx...	r28165	void *mallocx(size_t size);
		void reallocx(void ptr, size_t size);

Yuya Nishihara chg: import frontend sources...	r28060	int runshellcmd(const char cmd, const char envp[], const char *cwd);

		#endif /* UTIL_H_ */