##// END OF EJS Templates
revlog: make compressed size comparisons consistent...
revlog: make compressed size comparisons consistent revlog.compress() compares the compressed size to the input size and throws away the compressed data if it is larger than the input. This is the correct thing to do, as storing compressed data that is larger than the input takes up more storage space and makes reading slower. However, the comparison was implemented inconsistently. For the streaming compression mode, we threw away the result if it was greater than or equal to the input size. But for the one-shot compression, we threw away the compression only if it was greater than the input size! This patch changes the comparison for the simple case so it is consistent with the streaming case. As a few tests demonstrate, this adds 1 byte to some revlog entries. This is because of an added 'u' header on the chunk. It seems somewhat wrong to increase the revlog size here. However, IMO the cost of 1 byte in storage is insignificant compared to the performance gains of avoiding decompression. This patch should invite questions around the heuristic for throwing away compressed data. For example, I'd argue we should be more liberal about rejecting compressed data, additionally doing so where the number of bytes saved fails to reach a threshold. But we can have this discussion another time.

File last commit:

r30636:f1c9fafc default
r30792:4215dc1b default
Show More
wsgicgi.py
90 lines | 2.8 KiB | text/x-python | PythonLexer
Eric Hopper
This patch make several WSGI related alterations....
r2506 # hgweb/wsgicgi.py - CGI->WSGI translator
#
# Copyright 2006 Eric Hopper <hopper@omnifarious.org>
#
Martin Geisler
updated license to be explicit about GPL version 2
r8225 # This software may be used and distributed according to the terms of the
Matt Mackall
Update license to GPLv2+
r10263 # GNU General Public License version 2 or any later version.
Eric Hopper
This patch make several WSGI related alterations....
r2506 #
# This was originally copied from the public domain code at
# http://www.python.org/dev/peps/pep-0333/#the-server-gateway-side
Yuya Nishihara
hgweb: use absolute_import
r27046 from __future__ import absolute_import
from .. import (
Pulkit Goyal
py3: replace os.environ with encoding.environ (part 3 of 5)
r30636 encoding,
Yuya Nishihara
hgweb: use absolute_import
r27046 util,
)
from . import (
common,
)
Eric Hopper
This patch make several WSGI related alterations....
r2506
def launch(application):
Yuya Nishihara
py3: bulk replace sys.stdin/out/err by util's...
r30473 util.setbinary(util.stdin)
util.setbinary(util.stdout)
Eric Hopper
This patch make several WSGI related alterations....
r2506
Pulkit Goyal
py3: replace os.environ with encoding.environ (part 3 of 5)
r30636 environ = dict(encoding.environ.iteritems())
Dirkjan Ochtman
Fix style nit and add some comments to tests.
r5580 environ.setdefault('PATH_INFO', '')
Patrick Mezard
hgweb: improve IIS PATH_INFO fix ee8af8a4d905 (issue1580)...
r10201 if environ.get('SERVER_SOFTWARE', '').startswith('Microsoft-IIS'):
Mads Kiilerich
fix trivial spelling errors
r17424 # IIS includes script_name in PATH_INFO
Patrick Mezard
hgweb: improve IIS PATH_INFO fix ee8af8a4d905 (issue1580)...
r10201 scriptname = environ['SCRIPT_NAME']
if environ['PATH_INFO'].startswith(scriptname):
environ['PATH_INFO'] = environ['PATH_INFO'][len(scriptname):]
Dirkjan Ochtman
hgweb: support broken IIS 5 behavior with .cgi in PATH_INFO
r7406
Yuya Nishihara
py3: bulk replace sys.stdin/out/err by util's...
r30473 stdin = util.stdin
Augie Fackler
hgweb: add support for 100-continue as recommended by PEP 333.
r13570 if environ.get('HTTP_EXPECT', '').lower() == '100-continue':
Yuya Nishihara
py3: bulk replace sys.stdin/out/err by util's...
r30473 stdin = common.continuereader(stdin, util.stdout.write)
Augie Fackler
hgweb: add support for 100-continue as recommended by PEP 333.
r13570
environ['wsgi.input'] = stdin
Yuya Nishihara
py3: bulk replace sys.stdin/out/err by util's...
r30473 environ['wsgi.errors'] = util.stderr
Thomas Arendsen Hein
white space and line break cleanups
r3673 environ['wsgi.version'] = (1, 0)
environ['wsgi.multithread'] = False
Eric Hopper
This patch make several WSGI related alterations....
r2506 environ['wsgi.multiprocess'] = True
Thomas Arendsen Hein
white space and line break cleanups
r3673 environ['wsgi.run_once'] = True
Eric Hopper
This patch make several WSGI related alterations....
r2506
Benoit Boissinot
fix spaces/identation issues
r10339 if environ.get('HTTPS', 'off').lower() in ('on', '1', 'yes'):
Eric Hopper
This patch make several WSGI related alterations....
r2506 environ['wsgi.url_scheme'] = 'https'
else:
environ['wsgi.url_scheme'] = 'http'
headers_set = []
headers_sent = []
Yuya Nishihara
py3: bulk replace sys.stdin/out/err by util's...
r30473 out = util.stdout
Eric Hopper
This patch make several WSGI related alterations....
r2506
def write(data):
if not headers_set:
Thomas Arendsen Hein
white space and line break cleanups
r3673 raise AssertionError("write() before start_response()")
Eric Hopper
This patch make several WSGI related alterations....
r2506
elif not headers_sent:
Thomas Arendsen Hein
white space and line break cleanups
r3673 # Before the first output, send the stored headers
status, response_headers = headers_sent[:] = headers_set
out.write('Status: %s\r\n' % status)
for header in response_headers:
out.write('%s: %s\r\n' % header)
out.write('\r\n')
Eric Hopper
This patch make several WSGI related alterations....
r2506
Alexis S. L. Carvalho
hgweb: fix unbundle....
r2558 out.write(data)
out.flush()
Eric Hopper
This patch make several WSGI related alterations....
r2506
Thomas Arendsen Hein
white space and line break cleanups
r3673 def start_response(status, response_headers, exc_info=None):
Eric Hopper
This patch make several WSGI related alterations....
r2506 if exc_info:
try:
if headers_sent:
# Re-raise original exception if headers sent
Peter Ruibal
use Exception(args)-style raising consistently (py3k compatibility)
r7008 raise exc_info[0](exc_info[1], exc_info[2])
Eric Hopper
This patch make several WSGI related alterations....
r2506 finally:
exc_info = None # avoid dangling circular ref
elif headers_set:
raise AssertionError("Headers already set!")
Thomas Arendsen Hein
white space and line break cleanups
r3673 headers_set[:] = [status, response_headers]
Eric Hopper
This patch make several WSGI related alterations....
r2506 return write
Dirkjan Ochtman
hgweb: fix WSGI iterators handling in CGI adapter (issue1254)
r6922 content = application(environ, start_response)
Konstantin Zemlyak
wsgicgi: call close() on iterable to avoid resource leaks...
r10753 try:
for chunk in content:
write(chunk)
Mads Kiilerich
hgweb.cgi: fix internal WSGI emulation (issue3804)...
r18552 if not headers_sent:
write('') # send headers now if body was empty
Konstantin Zemlyak
wsgicgi: call close() on iterable to avoid resource leaks...
r10753 finally:
Augie Fackler
wsgicgi: use getattr instead of hasattr
r14956 getattr(content, 'close', lambda : None)()