upstream/mercurial-mirror Files · hgext/narrow/TODO.rst

repo: move unfiltered-repo optimization to workingctx...

repo: move unfiltered-repo optimization to workingctx localrepo.__getitem__ special-cased lookup of the working copy parent to avoid looking up obsmarkers. I think the reason for that code (which I once wrote myself) was to make `hg commit` not load obsmarkers, which it would otherwise do via ctx.p1() in localrepo.commitctx(). That had the somewhat unfortunate consequence of making lookup of an unrelated binary nodeid load the dirstate. Now that changectx's constructor is dumb, we can let workingctx._parents() have the opmtimization instead. This affects two tests, because they no longer end up loading the dirstate and their "warning: ignoring unknown working parent ..." messages therefore go way. Differential Revision: https://phab.mercurial-scm.org/D4828

Gregory Szorc - - Load All Authors

File last commit:

r39807:a063786c default


                r39995:43d3b09b

default

Download file

             TODO.rst
        
                    23 lines
            
             | 1.0 KiB
            
                | text/x-rst
            
             |
                RstLexer
            
             / hgext / narrow / TODO.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Augie Fackler
    
narrow: add a TODO document...

              r36121
            
      Integration with the share extension needs improvement. Right now

      we've seen some odd bugs, and the way we modify the contents of the

      .hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().

      Resolve commentary on narrowrepo.wraprepo.narrowrepository.status

      about the filtering of status being done at an awkward layer. This

      came up the import to hgext, but nobody's got concrete improvement

      ideas as of then.

        Gregory Szorc
    
narrow: remove narrowrevlog...

              r39807
            
      Address commentary in manifest.excludedmanifestrevlog.add -

        Augie Fackler
    
narrow: add a TODO document...

              r36121
            
      specifically we should improve the collaboration with core so that

      add() never gets called on an excluded directory and we can improve

      the stand-in to raise a ProgrammingError.

      Reason more completely about rename-filtering logic in

      narrowfilelog. There could be some surprises lurking there.

      Formally document the narrowspec format. Unify with sparse, if at all

      possible. For bonus points, unify with the server-specified narrowspec

      format.

      narrowrepo.setnarrowpats() or narrowspec.save() need to make sure

      they're holding the wlock.

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Augie Fackler narrow: add a TODO document...	r36121	Integration with the share extension needs improvement. Right now
		we've seen some odd bugs, and the way we modify the contents of the
		.hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().

		Resolve commentary on narrowrepo.wraprepo.narrowrepository.status
		about the filtering of status being done at an awkward layer. This
		came up the import to hgext, but nobody's got concrete improvement
		ideas as of then.

Gregory Szorc narrow: remove narrowrevlog...	r39807	Address commentary in manifest.excludedmanifestrevlog.add -
Augie Fackler narrow: add a TODO document...	r36121	specifically we should improve the collaboration with core so that
		add() never gets called on an excluded directory and we can improve
		the stand-in to raise a ProgrammingError.

		Reason more completely about rename-filtering logic in
		narrowfilelog. There could be some surprises lurking there.

		Formally document the narrowspec format. Unify with sparse, if at all
		possible. For bonus points, unify with the server-specified narrowspec
		format.

		narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
		they're holding the wlock.