upstream/mercurial-mirror Files · tests/test-check-code.t

extensions: register functions always at loading extension (issue5601)...

extensions: register functions always at loading extension (issue5601) Before this patch, functions defined in extensions are registered via extra loaders only in _dispatch(). Therefore, loading extensions in other code paths like below omits registration of functions. - WSGI service - operation across repositories (e.g. subrepo) - test-duplicateoptions.py, using extensions.loadall() directly To register functions always at loading new extension, this patch moves implementation for extra loading from dispatch._dispatch() to extensions.loadall(). AFAIK, only commands module causes cyclic dependency between extensions module, but this patch imports all related modules just before extra loading in loadall(), in order to centralize them. This patch makes extensions.py depend on many other modules, even though extensions.py itself doesn't. It should be avoided if possible, but I don't have any better idea. Some other places like below aren't reasonable for extra loading, IMHO. - specific function in newly added module: existing callers of extensions.loadall() should invoke it, too - hg.repository() or so: no-repo commands aren't covered by this. BTW, this patch removes _loaded.add(name) on relocation, because dispatch._loaded is used only for extraloaders (for similar reason, "exts" variable is removed, too).

Gregory Szorc - - Load All Authors

File last commit:

r32225:73c3e226 default


                r33052:45b0e9d0

default

Download file

             test-check-code.t
        
                    49 lines
            
             | 1.5 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-code.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
      #require test-repo

        timeless
    
tests: silence test-repo obsolete warning...

              r29219
            
        $ . "$TESTDIR/helpers-testrepo.sh"

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
        $ check_code="$TESTDIR"/../contrib/check-code.py

        $ cd "$TESTDIR"/..

      New errors are not allowed. Warnings are strongly discouraged.

      (The writing "no-che?k-code" is for not skipping this file when checking.)

        David Soria Parra
    
tests: exclude bundled pywatchman from check-code test...

              r30633
            
        $ hg locate -X contrib/python-zstandard -X hgext/fsmonitor/pywatchman |

        Jun Wu
    
test-check-code: do not use xargs...

              r31825
            
        > sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
        Skipping i18n/polib.py it has no-che?k-code (glob)

        Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)

        Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)

        Gregory Szorc
    
statprof: vendor statprof.py...

              r30253
            
        Skipping mercurial/statprof.py it has no-che?k-code (glob)

        Gregory Szorc
    
tests: add tests for poorly behaving HTTP server...

              r32001
            
        Skipping tests/badserverext.py it has no-che?k-code (glob)

        Gregory Szorc
    
tests: add test that @commands in debugcommands.py are sorted...

              r30540
            
      @commands in debugcommands.py should be in alphabetical order.

        >>> import re

        >>> commands = []

        >>> with open('mercurial/debugcommands.py', 'rb') as fh:

        ...     for line in fh:

        ...         m = re.match("^@command\('([a-z]+)", line)

        ...         if m:

        ...             commands.append(m.group(1))

        >>> scommands = list(sorted(commands))

        >>> for i, command in enumerate(scommands):

        ...     if command != commands[i]:

        ...         print('commands in debugcommands.py not sorted; first differing '

        ...               'command is %s; expected %s' % (commands[i], command))

        ...         break

        Jun Wu
    
test-check-code: prevent files being added to the root directory...

              r31726
            
      Prevent adding new files in the root directory accidentally.

        $ hg files 'glob:*'

        .editorconfig

        .hgignore

        .hgsigs

        .hgtags

        CONTRIBUTING

        CONTRIBUTORS

        COPYING

        Makefile

        README

        hg

        hgeditor

        hgweb.cgi

        setup.py

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	#require test-repo

timeless tests: silence test-repo obsolete warning...	r29219	$ . "$TESTDIR/helpers-testrepo.sh"
Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	$ check_code="$TESTDIR"/../contrib/check-code.py
		$ cd "$TESTDIR"/..

		New errors are not allowed. Warnings are strongly discouraged.
		(The writing "no-che?k-code" is for not skipping this file when checking.)

David Soria Parra tests: exclude bundled pywatchman from check-code test...	r30633	$ hg locate -X contrib/python-zstandard -X hgext/fsmonitor/pywatchman \|
Jun Wu test-check-code: do not use xargs...	r31825	> sed 's-\\-/-g' \| "$check_code" --warnings --per-file=0 - \|\| false
Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	Skipping i18n/polib.py it has no-che?k-code (glob)
		Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
		Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
Gregory Szorc statprof: vendor statprof.py...	r30253	Skipping mercurial/statprof.py it has no-che?k-code (glob)
Gregory Szorc tests: add tests for poorly behaving HTTP server...	r32001	Skipping tests/badserverext.py it has no-che?k-code (glob)
Gregory Szorc tests: add test that @commands in debugcommands.py are sorted...	r30540
		@commands in debugcommands.py should be in alphabetical order.

		>>> import re
		>>> commands = []
		>>> with open('mercurial/debugcommands.py', 'rb') as fh:
		... for line in fh:
		... m = re.match("^@command\('([a-z]+)", line)
		... if m:
		... commands.append(m.group(1))
		>>> scommands = list(sorted(commands))
		>>> for i, command in enumerate(scommands):
		... if command != commands[i]:
		... print('commands in debugcommands.py not sorted; first differing '
		... 'command is %s; expected %s' % (commands[i], command))
		... break
Jun Wu test-check-code: prevent files being added to the root directory...	r31726
		Prevent adding new files in the root directory accidentally.

		$ hg files 'glob:*'
		.editorconfig
		.hgignore
		.hgsigs
		.hgtags
		CONTRIBUTING
		CONTRIBUTORS
		COPYING
		Makefile
		README
		hg
		hgeditor
		hgweb.cgi
		setup.py