upstream/mercurial-mirror Files · tests/test-check-config.t

extensions: register functions always at loading extension (issue5601)...

extensions: register functions always at loading extension (issue5601) Before this patch, functions defined in extensions are registered via extra loaders only in _dispatch(). Therefore, loading extensions in other code paths like below omits registration of functions. - WSGI service - operation across repositories (e.g. subrepo) - test-duplicateoptions.py, using extensions.loadall() directly To register functions always at loading new extension, this patch moves implementation for extra loading from dispatch._dispatch() to extensions.loadall(). AFAIK, only commands module causes cyclic dependency between extensions module, but this patch imports all related modules just before extra loading in loadall(), in order to centralize them. This patch makes extensions.py depend on many other modules, even though extensions.py itself doesn't. It should be avoided if possible, but I don't have any better idea. Some other places like below aren't reasonable for extra loading, IMHO. - specific function in newly added module: existing callers of extensions.loadall() should invoke it, too - hg.repository() or so: no-repo commands aren't covered by this. BTW, this patch removes _loaded.add(name) on relocation, because dispatch._loaded is used only for extraloaders (for similar reason, "exts" variable is removed, too).

Augie Fackler - - Load All Authors

File last commit:

r32940:75be1499 default


                r33052:45b0e9d0

default

Download file

             test-check-config.t
        
                    38 lines
            
             | 1.1 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-config.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
      #require test-repo

        timeless
    
tests: silence test-repo obsolete warning...

              r29219
            
        $ . "$TESTDIR/helpers-testrepo.sh"

        Gregory Szorc
    
tests: add test coverage for check-config...

              r32846
            
      Sanity check check-config.py

        $ cat > testfile.py << EOF

        > # Good

        > foo = ui.config('ui', 'username')

        > # Missing

        > foo = ui.config('ui', 'doesnotexist')

        > # Missing different type

        > foo = ui.configint('ui', 'missingint')

        > # Missing with default value

        > foo = ui.configbool('ui', 'missingbool1', default=True)

        > foo = ui.configbool('ui', 'missingbool2', False)

        > EOF

        $ cat > files << EOF

        > mercurial/help/config.txt

        > $TESTTMP/testfile.py

        > EOF

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
        $ cd "$TESTDIR"/..

        Augie Fackler
    
cleanup: use $PYTHON to run python in many more tests...

              r32940
            
        $ $PYTHON contrib/check-config.py < $TESTTMP/files

        Gregory Szorc
    
tests: add test coverage for check-config...

              r32846
            
        undocumented: ui.doesnotexist (str)

        undocumented: ui.missingbool1 (bool) [True]

        undocumented: ui.missingbool2 (bool)

        undocumented: ui.missingint (int)

        Pierre-Yves David
    
tests: move the '-hg' postfix for all style tests...

              r27368
            
      New errors are not allowed. Warnings are strongly discouraged.

        $ hg files "set:(**.py or **.txt) - tests/**" | sed 's|\\|/|g' |

        Augie Fackler
    
cleanup: use $PYTHON to run python in many more tests...

              r32940
            
        >   $PYTHON contrib/check-config.py

        Gregory Szorc
    
profiling: allow configuring minimum display threshold for hotpath...

              r32851
            
                    limit = ui.configwith(fraction, 'profiling', 'showmin', 0.05)

        conflict on profiling.showmin: ('with', '0.05') != ('with', '0.005')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	#require test-repo

timeless tests: silence test-repo obsolete warning...	r29219	$ . "$TESTDIR/helpers-testrepo.sh"
Gregory Szorc tests: add test coverage for check-config...	r32846
		Sanity check check-config.py

		$ cat > testfile.py << EOF
		> # Good
		> foo = ui.config('ui', 'username')
		> # Missing
		> foo = ui.config('ui', 'doesnotexist')
		> # Missing different type
		> foo = ui.configint('ui', 'missingint')
		> # Missing with default value
		> foo = ui.configbool('ui', 'missingbool1', default=True)
		> foo = ui.configbool('ui', 'missingbool2', False)
		> EOF

		$ cat > files << EOF
		> mercurial/help/config.txt
		> $TESTTMP/testfile.py
		> EOF

Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	$ cd "$TESTDIR"/..

Augie Fackler cleanup: use $PYTHON to run python in many more tests...	r32940	$ $PYTHON contrib/check-config.py < $TESTTMP/files
Gregory Szorc tests: add test coverage for check-config...	r32846	undocumented: ui.doesnotexist (str)
		undocumented: ui.missingbool1 (bool) [True]
		undocumented: ui.missingbool2 (bool)
		undocumented: ui.missingint (int)

Pierre-Yves David tests: move the '-hg' postfix for all style tests...	r27368	New errors are not allowed. Warnings are strongly discouraged.

		$ hg files "set:(.py or .txt) - tests/**" \| sed 's\|\\\|/\|g' \|
Augie Fackler cleanup: use $PYTHON to run python in many more tests...	r32940	> $PYTHON contrib/check-config.py
Gregory Szorc profiling: allow configuring minimum display threshold for hotpath...	r32851	limit = ui.configwith(fraction, 'profiling', 'showmin', 0.05)

		conflict on profiling.showmin: ('with', '0.05') != ('with', '0.005')