upstream/mercurial-mirror Files · tests/test-duplicateoptions.py

extensions: register functions always at loading extension (issue5601)...

extensions: register functions always at loading extension (issue5601) Before this patch, functions defined in extensions are registered via extra loaders only in _dispatch(). Therefore, loading extensions in other code paths like below omits registration of functions. - WSGI service - operation across repositories (e.g. subrepo) - test-duplicateoptions.py, using extensions.loadall() directly To register functions always at loading new extension, this patch moves implementation for extra loading from dispatch._dispatch() to extensions.loadall(). AFAIK, only commands module causes cyclic dependency between extensions module, but this patch imports all related modules just before extra loading in loadall(), in order to centralize them. This patch makes extensions.py depend on many other modules, even though extensions.py itself doesn't. It should be avoided if possible, but I don't have any better idea. Some other places like below aren't reasonable for extra loading, IMHO. - specific function in newly added module: existing callers of extensions.loadall() should invoke it, too - hg.repository() or so: no-repo commands aren't covered by this. BTW, this patch removes _loaded.add(name) on relocation, because dispatch._loaded is used only for extraloaders (for similar reason, "exts" variable is removed, too).

Martin von Zweigbergk - - Load All Authors

File last commit:

r32291:bd872f64 default


                r33052:45b0e9d0

default

Download file

             test-duplicateoptions.py
        
                    41 lines
            
             | 1.0 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / test-duplicateoptions.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Robert Stanca
    
py3: use print_function in test-duplicateoptions.py

              r28740
            
      from __future__ import absolute_import, print_function

        Idan Kamara
    
tests: add a test to check for duplicate command options

              r14449
            
      import os

        Robert Stanca
    
py3: use absolute_import in test-duplicateoptions.py

              r28739
            
      from mercurial import (

          commands,

          extensions,

        Yuya Nishihara
    
test-duplicateoptions: alias ui as uimod

              r28804
            
          ui as uimod,

        Robert Stanca
    
py3: use absolute_import in test-duplicateoptions.py

              r28739
            
      )

        Idan Kamara
    
tests: add a test to check for duplicate command options

              r14449
            
        Martin von Zweigbergk
    
cleanup: use set literals...

              r32291
            
      ignore = {'highlight', 'win32text', 'factotum'}

        Idan Kamara
    
tests: add a test to check for duplicate command options

              r14449
            
      if os.name != 'nt':

          ignore.add('win32mbcs')

      disabled = [ext for ext in extensions.disabled().keys() if ext not in ignore]

      hgrc = open(os.environ["HGRCPATH"], 'w')

      hgrc.write('[extensions]\n')

      for ext in disabled:

          hgrc.write(ext + '=\n')

      hgrc.close()

        Yuya Nishihara
    
ui: factor out ui.load() to create a ui without loading configs (API)...

              r30559
            
      u = uimod.ui.load()

        Idan Kamara
    
tests: add a test to check for duplicate command options

              r14449
            
      extensions.loadall(u)

        Simon Heimberg
    
test: test for options duplicate with global options...

              r15099
            
      globalshort = set()

      globallong = set()

      for option in commands.globalopts:

          option[0] and globalshort.add(option[0])

          option[1] and globallong.add(option[1])

        Idan Kamara
    
tests: add a test to check for duplicate command options

              r14449
            
      for cmd, entry in commands.table.iteritems():

        Simon Heimberg
    
test: test for options duplicate with global options...

              r15099
            
          seenshort = globalshort.copy()

          seenlong = globallong.copy()

        Idan Kamara
    
tests: add a test to check for duplicate command options

              r14449
            
          for option in entry[1]:

              if (option[0] and option[0] in seenshort) or \

                 (option[1] and option[1] in seenlong):

        Robert Stanca
    
py3: use print_function in test-duplicateoptions.py

              r28740
            
                  print("command '" + cmd + "' has duplicate option " + str(option))

        Idan Kamara
    
tests: add a test to check for duplicate command options

              r14449
            
              seenshort.add(option[0])

              seenlong.add(option[1])

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Robert Stanca py3: use print_function in test-duplicateoptions.py	r28740	from __future__ import absolute_import, print_function
Idan Kamara tests: add a test to check for duplicate command options	r14449	import os
Robert Stanca py3: use absolute_import in test-duplicateoptions.py	r28739	from mercurial import (
		commands,
		extensions,
Yuya Nishihara test-duplicateoptions: alias ui as uimod	r28804	ui as uimod,
Robert Stanca py3: use absolute_import in test-duplicateoptions.py	r28739	)
Idan Kamara tests: add a test to check for duplicate command options	r14449
Martin von Zweigbergk cleanup: use set literals...	r32291	ignore = {'highlight', 'win32text', 'factotum'}
Idan Kamara tests: add a test to check for duplicate command options	r14449
		if os.name != 'nt':
		ignore.add('win32mbcs')

		disabled = [ext for ext in extensions.disabled().keys() if ext not in ignore]

		hgrc = open(os.environ["HGRCPATH"], 'w')
		hgrc.write('[extensions]\n')

		for ext in disabled:
		hgrc.write(ext + '=\n')

		hgrc.close()

Yuya Nishihara ui: factor out ui.load() to create a ui without loading configs (API)...	r30559	u = uimod.ui.load()
Idan Kamara tests: add a test to check for duplicate command options	r14449	extensions.loadall(u)

Simon Heimberg test: test for options duplicate with global options...	r15099	globalshort = set()
		globallong = set()
		for option in commands.globalopts:
		option[0] and globalshort.add(option[0])
		option[1] and globallong.add(option[1])

Idan Kamara tests: add a test to check for duplicate command options	r14449	for cmd, entry in commands.table.iteritems():
Simon Heimberg test: test for options duplicate with global options...	r15099	seenshort = globalshort.copy()
		seenlong = globallong.copy()
Idan Kamara tests: add a test to check for duplicate command options	r14449	for option in entry[1]:
		if (option[0] and option[0] in seenshort) or \
		(option[1] and option[1] in seenlong):
Robert Stanca py3: use print_function in test-duplicateoptions.py	r28740	print("command '" + cmd + "' has duplicate option " + str(option))
Idan Kamara tests: add a test to check for duplicate command options	r14449	seenshort.add(option[0])
		seenlong.add(option[1])