##// END OF EJS Templates
cext-revlog: fixed __delitem__ for uninitialized nodetree...
cext-revlog: fixed __delitem__ for uninitialized nodetree This is a bug in a code path that's seldom used, because in practice (at least in the whole test suite), calls to `del index[i:j]` currently just don't happen before the nodetree has been initialized. However, in our current work to replace the nodetree by a Rust implementation, this is of course systematic. In `index_slice_del()`, if the slice start is smaller than `self->length`, the whole of `self->added` has to be cleared. Before this change, the clearing was done only by the call to `index_invalidate_added(self, 0)`, that happens only for initialized nodetrees. Hence the removal was effective only from `start` to `self->length`. The consequence is index corruption, with bogus results in subsequent calls, and in particular errors such as `ValueError("parent out of range")`, due to the fact that parents of entries in `self->added` are now just invalid. This is detected by the rebase tests, under conditions that the nodetree of revlog.c is never initialized. The provided specific test is more direct. Differential Revision: https://phab.mercurial-scm.org/D7603

File last commit:

r26284:c258f4d2 default
r44306:49fa0b31 default
Show More
header.tmpl
8 lines | 549 B | application/x-cheetah | CheetahLexer
Dan Villiom Podlaski Christiansen
setup: install translation files as package data...
r9999 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US">
<head>
Thomas Arendsen Hein
hgweb: urlescape all urls, HTML escape repo/tag/branch/... names...
r18526 <link rel="icon" href="{staticurl|urlescape}hgicon.png" type="image/png" />
Dan Villiom Podlaski Christiansen
setup: install translation files as package data...
r9999 <meta name="robots" content="index, nofollow" />
av6
coal: reuse style-paper.css and use a separate css file for visual tweaks...
r26284 <link rel="stylesheet" href="{staticurl|urlescape}style-paper.css" type="text/css" />
<link rel="stylesheet" href="{staticurl|urlescape}style-extra-coal.css" type="text/css" />
Thomas Arendsen Hein
hgweb: urlescape all urls, HTML escape repo/tag/branch/... names...
r18526 <script type="text/javascript" src="{staticurl|urlescape}mercurial.js"></script>