upstream/mercurial-mirror Files · rust/hg-core/src/dirstate_tree.rs

rust: make `Revision` a newtype...

rust: make `Revision` a newtype This change is the one we've been building towards during this series. The aim is to make `Revision` mean more than a simple integer, holding the information that it is valid for a given revlog index. While this still allows for programmer error, since creating a revision directly and querying a different index with a "checked" revision are still possible, the friction created by the newtype will hopefully make us think twice about which type to use. Enough of the Rust ecosystem relies on the newtype pattern to be efficiently optimized away (even compiler in codegen tests¹), so I'm not worried about this being a fundamental problem. [1] https://github.com/rust-lang/rust/blob/7a70647f195f6b0a0f1ebd72b1542ba91a32f43a/tests/codegen/vec-in-place.rs#L47

Simon Sapin - - Load All Authors

File last commit:

r48883:3d0a9c6e default


                r51872:4c5f6e95

default

Download file

             dirstate_tree.rs
        
                    5 lines
            
             | 99 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / dirstate_tree.rs
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Simon Sapin
    
dirstate-tree: Empty shell for a second Rust DirstateMap implementation...

              r47865
            
      pub mod dirstate_map;

        Simon Sapin
    
dirstate-v2: Change the on-disk format when the requirement is enabled...

              r48055
            
      pub mod on_disk;

        Simon Sapin
    
rust: Make OwningDirstateMap generic and move it into hg-core...

              r48766
            
      pub mod owning;

        Simon Sapin
    
dirstate-tree: Add `WithBasename` wrapper for `HgPath`...

              r47866
            
      pub mod path_with_basename;

        Simon Sapin
    
rhg: Add support for dirstate-v2...

              r48165
            
      pub mod status;

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Simon Sapin dirstate-tree: Empty shell for a second Rust DirstateMap implementation...	r47865	pub mod dirstate_map;
Simon Sapin dirstate-v2: Change the on-disk format when the requirement is enabled...	r48055	pub mod on_disk;
Simon Sapin rust: Make OwningDirstateMap generic and move it into hg-core...	r48766	pub mod owning;
Simon Sapin dirstate-tree: Add `WithBasename` wrapper for `HgPath`...	r47866	pub mod path_with_basename;
Simon Sapin rhg: Add support for dirstate-v2...	r48165	pub mod status;