##// END OF EJS Templates
revlog: change generaldelta delta parent heuristic...
revlog: change generaldelta delta parent heuristic The old generaldelta heuristic was "if p1 (or p2) was closer than the last full text, use it, otherwise use prev". This was problematic when a repo contained multiple branches that were very different. If commits to branch A were pushed, and the last full text was branch B, it would generate a fulltext. Then if branch B was pushed, it would generate another fulltext. The problem is that the last fulltext (and delta'ing against `prev` in general) has no correlation with the contents of the incoming revision, and therefore will always have degenerate cases. According to the blame, that algorithm was chosen to minimize the chain length. Since there is already code that protects against that (the delta-vs-fulltext code), and since it has been improved since the original generaldelta algorithm went in (2011), I believe the chain length criteria will still be preserved. The new algorithm always diffs against p1 (or p2 if it's closer), unless the resulting delta will fail the delta-vs-fulltext check, in which case we delta against prev. Some before and after stats on manifest.d size. internal large repo old heuristic - 2.0 GB new heuristic - 1.2 GB mozilla-central old heuristic - 242 MB new heuristic - 261 MB The regression in mozilla central is due to the new heuristic choosing p2r as the delta when it's closer to the tip. Switching the algorithm to always prefer p1r brings the size back down (242 MB). This is result of the way in which mozilla does merges and pushes, and the result could easily swing the other direction in other repos (depending on if they merge X into Y or Y into X), but will never be as degenerate as before. I future patch will address the regression by introducing an optional, even more aggressive delta heuristic which will knock the mozilla manifest size down dramatically.

File last commit:

r20167:09e41ac6 stable
r26117:4dc5b51f default
Show More
mpatch.c
420 lines | 8.5 KiB | text/x-c | CLexer
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 /*
mpatch.c - efficient binary patching for Mercurial
This implements a patch algorithm that's O(m + nlog n) where m is the
size of the output and n is the number of patches.
Given a list of binary patches, it unpacks each into a hunk list,
then combines the hunk lists with a treewise recursion to form a
single hunk list. This hunk list is then applied to the original
text.
The text (or binary) fragments are copied directly from their source
Python objects into a preallocated output string to avoid the
allocation of intermediate Python objects. Working memory is about 2x
the total number of hunks.
Vadim Gelfer
update copyrights.
r2859 Copyright 2005, 2006 Matt Mackall <mpm@selenic.com>
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
This software may be used and distributed according to the terms
of the GNU General Public License, incorporated herein by reference.
*/
Adrian Buehlmann
mpatch: use Py_ssize_t for string length
r16758 #define PY_SSIZE_T_CLEAN
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 #include <Python.h>
#include <stdlib.h>
#include <string.h>
Vadim Gelfer
mac os x: fixes for 10.2 from chris monson <monpublic@gmail.com>
r2468
Renato Cunha
mpatch.c: Added preliminary support for py3k....
r11360 #include "util.h"
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 static char mpatch_doc[] = "Efficient binary patching.";
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 static PyObject *mpatch_Error;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
struct frag {
int start, end, len;
Matt Mackall
mpatch: allow buffer objects for input
r5444 const char *data;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 };
struct flist {
struct frag *base, *head, *tail;
};
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 static struct flist *lalloc(Py_ssize_t size)
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {
mpm@selenic.com
Add safety checking to mpatch
r128 struct flist *a = NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
Matt Mackall
mpatch: Fix for malloc corner case on AIX
r3138 if (size < 1)
size = 1;
TK Soh
do proper typecasting on malloc() and calloc() calls...
r1978 a = (struct flist *)malloc(sizeof(struct flist));
mpm@selenic.com
Add safety checking to mpatch
r128 if (a) {
TK Soh
do proper typecasting on malloc() and calloc() calls...
r1978 a->base = (struct frag *)malloc(sizeof(struct frag) * size);
Thomas Arendsen Hein
Set correct exception for another possible malloc error in mpatch.c
r2048 if (a->base) {
mpm@selenic.com
Add safety checking to mpatch
r128 a->head = a->tail = a->base;
Thomas Arendsen Hein
Set correct exception for another possible malloc error in mpatch.c
r2048 return a;
}
free(a);
a = NULL;
mpm@selenic.com
Add safety checking to mpatch
r128 }
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (!PyErr_Occurred())
PyErr_NoMemory();
return NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
static void lfree(struct flist *a)
{
mpm@selenic.com
Add safety checking to mpatch
r128 if (a) {
free(a->base);
free(a);
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 static Py_ssize_t lsize(struct flist *a)
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {
return a->tail - a->head;
}
/* move hunks in source that are less cut to dest, compensating
for changes in offset. the last hunk may be split if necessary.
*/
static int gather(struct flist *dest, struct flist *src, int cut, int offset)
{
struct frag *d = dest->tail, *s = src->head;
int postend, c, l;
while (s != src->tail) {
if (s->start + offset >= cut)
mpm@selenic.com
Gotos are embarrassing.
r82 break; /* we've gone far enough */
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
postend = offset + s->start + s->len;
if (postend <= cut) {
/* save this hunk */
offset += s->start + s->len - s->end;
*d++ = *s++;
}
else {
/* break up this hunk */
c = cut - offset;
if (s->end < c)
c = s->end;
l = cut - offset - s->start;
if (s->len < l)
l = s->len;
offset += s->start + l - c;
d->start = s->start;
d->end = c;
d->len = l;
d->data = s->data;
d++;
s->start = c;
s->len = s->len - l;
s->data = s->data + l;
mpm@selenic.com
Gotos are embarrassing.
r82 break;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
}
dest->tail = d;
src->head = s;
return offset;
}
/* like gather, but with no output list */
static int discard(struct flist *src, int cut, int offset)
{
struct frag *s = src->head;
int postend, c, l;
while (s != src->tail) {
if (s->start + offset >= cut)
mpm@selenic.com
Gotos are embarrassing.
r82 break;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
postend = offset + s->start + s->len;
if (postend <= cut) {
offset += s->start + s->len - s->end;
s++;
}
else {
c = cut - offset;
if (s->end < c)
c = s->end;
l = cut - offset - s->start;
if (s->len < l)
l = s->len;
offset += s->start + l - c;
s->start = c;
s->len = s->len - l;
s->data = s->data + l;
mpm@selenic.com
Gotos are embarrassing.
r82 break;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
}
src->head = s;
return offset;
}
/* combine hunk lists a and b, while adjusting b for offset changes in a/
this deletes a and b and returns the resultant list. */
static struct flist *combine(struct flist *a, struct flist *b)
{
mpm@selenic.com
Add safety checking to mpatch
r128 struct flist *c = NULL;
struct frag *bh, *ct;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 int offset = 0, post;
mpm@selenic.com
Add safety checking to mpatch
r128 if (a && b)
c = lalloc((lsize(a) + lsize(b)) * 2);
if (c) {
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
mpm@selenic.com
Add safety checking to mpatch
r128 for (bh = b->head; bh != b->tail; bh++) {
/* save old hunks */
offset = gather(c, a, bh->start, offset);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
mpm@selenic.com
Add safety checking to mpatch
r128 /* discard replaced hunks */
post = discard(a, bh->end, offset);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
mpm@selenic.com
Add safety checking to mpatch
r128 /* insert new hunk */
ct = c->tail;
ct->start = bh->start - offset;
ct->end = bh->end - post;
ct->len = bh->len;
ct->data = bh->data;
c->tail++;
offset = post;
}
/* hold on to tail from a */
memcpy(c->tail, a->head, sizeof(struct frag) * lsize(a));
c->tail += lsize(a);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
lfree(a);
lfree(b);
return c;
}
/* decode a binary patch into a hunk list */
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 static struct flist *decode(const char *bin, Py_ssize_t len)
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {
struct flist *l;
struct frag *lt;
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 int pos = 0;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
/* assume worst case size, we won't have many of these lists */
l = lalloc(len / 12);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (!l)
return NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 lt = l->tail;
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 while (pos >= 0 && pos < len) {
lt->start = getbe32(bin + pos);
lt->end = getbe32(bin + pos + 4);
lt->len = getbe32(bin + pos + 8);
Thomas Arendsen Hein
Fix segfaults when parsing bdiff hunks in mpatch.decode() and .patchedsize()...
r4358 if (lt->start > lt->end)
break; /* sanity check */
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 lt->data = bin + pos + 12;
pos += 12 + lt->len;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 lt++;
}
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 if (pos != len) {
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error, "patch cannot be decoded");
lfree(l);
return NULL;
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 l->tail = lt;
return l;
}
/* calculate the size of resultant text */
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 static Py_ssize_t calcsize(Py_ssize_t len, struct flist *l)
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 Py_ssize_t outlen = 0, last = 0;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 struct frag *f = l->head;
while (f != l->tail) {
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (f->start < last || f->end > len) {
if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error,
"invalid patch");
return -1;
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 outlen += f->start - last;
last = f->end;
outlen += f->len;
f++;
}
outlen += len - last;
return outlen;
}
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 static int apply(char *buf, const char *orig, Py_ssize_t len, struct flist *l)
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {
struct frag *f = l->head;
int last = 0;
char *p = buf;
while (f != l->tail) {
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (f->start < last || f->end > len) {
if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error,
"invalid patch");
return 0;
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 memcpy(p, orig + last, f->start - last);
p += f->start - last;
memcpy(p, f->data, f->len);
last = f->end;
p += f->len;
f++;
}
memcpy(p, orig + last, len - last);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 return 1;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
/* recursively generate a patch of all bins between start and end */
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 static struct flist *fold(PyObject *bins, Py_ssize_t start, Py_ssize_t end)
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 Py_ssize_t len, blen;
Matt Mackall
mpatch: allow buffer objects for input
r5444 const char *buffer;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
if (start + 1 == end) {
/* trivial case, output a decoded list */
PyObject *tmp = PyList_GetItem(bins, start);
mpm@selenic.com
Add safety checking to mpatch
r128 if (!tmp)
return NULL;
Matt Mackall
mpatch: allow buffer objects for input
r5444 if (PyObject_AsCharBuffer(tmp, &buffer, &blen))
return NULL;
return decode(buffer, blen);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
/* divide and conquer, memory management is elsewhere */
len = (end - start) / 2;
return combine(fold(bins, start, start + len),
fold(bins, start + len, end));
}
static PyObject *
patches(PyObject *self, PyObject *args)
{
PyObject *text, *bins, *result;
struct flist *patch;
Matt Mackall
mpatch: allow buffer objects for input
r5444 const char *in;
char *out;
Adrian Buehlmann
mpatch: use Py_ssize_t...
r16757 Py_ssize_t len, outlen, inlen;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72
Matt Mackall
mpatch: allow buffer objects for input
r5444 if (!PyArg_ParseTuple(args, "OO:mpatch", &text, &bins))
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 return NULL;
len = PyList_Size(bins);
if (!len) {
/* nothing to do */
Py_INCREF(text);
return text;
}
Matt Mackall
mpatch: allow buffer objects for input
r5444 if (PyObject_AsCharBuffer(text, &in, &inlen))
return NULL;
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 patch = fold(bins, 0, len);
mpm@selenic.com
Add safety checking to mpatch
r128 if (!patch)
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 return NULL;
mpm@selenic.com
Add safety checking to mpatch
r128
Matt Mackall
mpatch: allow buffer objects for input
r5444 outlen = calcsize(inlen, patch);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (outlen < 0) {
result = NULL;
goto cleanup;
}
Renato Cunha
mpatch.c: Added preliminary support for py3k....
r11360 result = PyBytes_FromStringAndSize(NULL, outlen);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 if (!result) {
result = NULL;
goto cleanup;
mpm@selenic.com
Add safety checking to mpatch
r128 }
Renato Cunha
mpatch.c: Added preliminary support for py3k....
r11360 out = PyBytes_AsString(result);
Matt Mackall
mpatch: allow buffer objects for input
r5444 if (!apply(out, in, inlen, patch)) {
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 Py_DECREF(result);
result = NULL;
}
cleanup:
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 lfree(patch);
return result;
}
mason@suse.com
Fill in the uncompressed size during revlog.addgroup...
r2078 /* calculate size of a patched file directly */
static PyObject *
patchedsize(PyObject *self, PyObject *args)
{
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 long orig, start, end, len, outlen = 0, last = 0, pos = 0;
Adrian Buehlmann
mpatch: use Py_ssize_t for string length
r16758 Py_ssize_t patchlen;
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 char *bin;
mason@suse.com
Fill in the uncompressed size during revlog.addgroup...
r2078
if (!PyArg_ParseTuple(args, "ls#", &orig, &bin, &patchlen))
return NULL;
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 while (pos >= 0 && pos < patchlen) {
start = getbe32(bin + pos);
end = getbe32(bin + pos + 4);
len = getbe32(bin + pos + 8);
Thomas Arendsen Hein
Fix segfaults when parsing bdiff hunks in mpatch.decode() and .patchedsize()...
r4358 if (start > end)
break; /* sanity check */
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 pos += 12 + len;
mason@suse.com
Fill in the uncompressed size during revlog.addgroup...
r2078 outlen += start - last;
last = end;
outlen += len;
}
Matt Mackall
mpatch: rewrite pointer overflow checks
r20167 if (pos != patchlen) {
mason@suse.com
Fill in the uncompressed size during revlog.addgroup...
r2078 if (!PyErr_Occurred())
PyErr_SetString(mpatch_Error, "patch cannot be decoded");
return NULL;
}
outlen += orig - last;
return Py_BuildValue("l", outlen);
}
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 static PyMethodDef methods[] = {
{"patches", patches, METH_VARARGS, "apply a series of patches\n"},
mason@suse.com
Fill in the uncompressed size during revlog.addgroup...
r2078 {"patchedsize", patchedsize, METH_VARARGS, "calculed patched size\n"},
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 {NULL, NULL}
};
Renato Cunha
mpatch.c: Added preliminary support for py3k....
r11360 #ifdef IS_PY3K
static struct PyModuleDef mpatch_module = {
PyModuleDef_HEAD_INIT,
"mpatch",
mpatch_doc,
-1,
methods
};
PyMODINIT_FUNC PyInit_mpatch(void)
{
PyObject *m;
m = PyModule_Create(&mpatch_module);
if (m == NULL)
return NULL;
mpatch_Error = PyErr_NewException("mpatch.mpatchError", NULL, NULL);
Py_INCREF(mpatch_Error);
PyModule_AddObject(m, "mpatchError", mpatch_Error);
return m;
}
#else
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 PyMODINIT_FUNC
initmpatch(void)
{
Py_InitModule3("mpatch", methods, mpatch_doc);
Benoit Boissinot
catch errors and throw exception with invalid binary patch data
r1722 mpatch_Error = PyErr_NewException("mpatch.mpatchError", NULL, NULL);
mpm@selenic.com
Add an O(m + nlog n) patching extension
r72 }
Renato Cunha
mpatch.c: Added preliminary support for py3k....
r11360 #endif