upstream/mercurial-mirror Files · tests/test-devel-warnings.t

mq: use dirstateguard instead of dirstate.invalidate (qpush)...

mq: use dirstateguard instead of dirstate.invalidate (qpush) Before this patch, "mq.queue.apply()" uses "dirstate.invalidate()" as a kind of "restore .hg/dirstate to the original status" during afailure. But it just discards changes in memory, and doesn't actually restore ".hg/dirstate". Then, it can't work as expected, if "dirstate.write()" is executed while processing. This patch uses "dirstateguard" instead of "dirstate.invalidate()" to restore ".hg/dirstate" at failure even if "dirstate.write()" is executed before failure. This is a part of preparations to fix the issue that the recent (in memory) dirstate isn't visible to external processes (e.g. "precommit" hook).

Pierre-Yves David - - Load All Authors

File last commit:

r24755:cd89f4e6 default


                r24996:58308dde

default

Download file

             test-devel-warnings.t
        
                    90 lines
            
             | 2.8 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-devel-warnings.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Pierre-Yves David
    
devel: move the lock-checking code into core...

              r24386
            
        $ cat << EOF > buggylocking.py

        > """A small extension that acquire locks in the wrong order

        > """

        > 

        > from mercurial import cmdutil

        > 

        > cmdtable = {}

        > command = cmdutil.command(cmdtable)

        > 

        > @command('buggylocking', [], '')

        > def buggylocking(ui, repo):

        Pierre-Yves David
    
devel: also warn about transaction started without a lock...

              r24388
            
        >     tr = repo.transaction('buggy')

        Pierre-Yves David
    
devel: move the lock-checking code into core...

              r24386
            
        >     lo = repo.lock()

        >     wl = repo.wlock()

        Matt Mackall
    
tests: avoid deprecation warning

              r24392
            
        >     wl.release()

        >     lo.release()

        Pierre-Yves David
    
wlock: only issue devel warning when actually acquiring the lock...

              r24744
            
        > 

        > @command('properlocking', [], '')

        > def properlocking(ui, repo):

        >     """check that reentrance is fine"""

        >     wl = repo.wlock()

        >     lo = repo.lock()

        >     tr = repo.transaction('proper')

        >     tr2 = repo.transaction('proper')

        >     lo2 = repo.lock()

        >     wl2 = repo.wlock()

        >     wl2.release()

        >     lo2.release()

        >     tr2.close()

        >     tr.close()

        >     lo.release()

        >     wl.release()

        Pierre-Yves David
    
wlock: do not warn for non-wait locking...

              r24750
            
        > 

        > @command('nowaitlocking', [], '')

        > def nowaitlocking(ui, repo):

        >     lo = repo.lock()

        >     wl = repo.wlock(wait=False)

        >     wl.release()

        >     lo.release()

        Pierre-Yves David
    
devel: move the lock-checking code into core...

              r24386
            
        > EOF

        $ cat << EOF >> $HGRCPATH

        > [extensions]

        > buggylocking=$TESTTMP/buggylocking.py

        > [devel]

        > all=1

        > EOF

        $ hg init lock-checker

        $ cd lock-checker

        $ hg buggylocking

        Pierre-Yves David
    
devel-warn: add a prefix to all messages ("devel-warn: ")...

              r24755
            
        devel-warn: transaction with no lock at: $TESTTMP/buggylocking.py:11 (buggylocking)

        devel-warn: "wlock" acquired after "lock" at: $TESTTMP/buggylocking.py:13 (buggylocking)

        Pierre-Yves David
    
devel: move the lock-checking code into core...

              r24386
            
        $ cat << EOF >> $HGRCPATH

        > [devel]

        > all=0

        > check-locks=1

        > EOF

        $ hg buggylocking

        Pierre-Yves David
    
devel-warn: add a prefix to all messages ("devel-warn: ")...

              r24755
            
        devel-warn: transaction with no lock at: $TESTTMP/buggylocking.py:11 (buggylocking)

        devel-warn: "wlock" acquired after "lock" at: $TESTTMP/buggylocking.py:13 (buggylocking)

        Pierre-Yves David
    
devel: move the lock-checking code into core...

              r24386
            
        $ hg buggylocking --traceback

        Pierre-Yves David
    
devel-warn: add a prefix to all messages ("devel-warn: ")...

              r24755
            
        devel-warn: transaction with no lock at:

        Matt Mackall
    
tests: fix py2.4 glob for devel warnings

              r24555
            
         */hg:* in * (glob)

        Pierre-Yves David
    
devel: also warn about transaction started without a lock...

              r24388
            
         */mercurial/dispatch.py:* in run (glob)

         */mercurial/dispatch.py:* in dispatch (glob)

         */mercurial/dispatch.py:* in _runcatch (glob)

         */mercurial/dispatch.py:* in _dispatch (glob)

         */mercurial/dispatch.py:* in runcommand (glob)

         */mercurial/dispatch.py:* in _runcommand (glob)

         */mercurial/dispatch.py:* in checkargs (glob)

         */mercurial/dispatch.py:* in <lambda> (glob)

         */mercurial/util.py:* in check (glob)

         $TESTTMP/buggylocking.py:* in buggylocking (glob)

        Pierre-Yves David
    
devel-warn: add a prefix to all messages ("devel-warn: ")...

              r24755
            
        devel-warn: "wlock" acquired after "lock" at:

        Matt Mackall
    
tests: fix py2.4 glob for devel warnings

              r24555
            
         */hg:* in * (glob)

        Pierre-Yves David
    
devel: move the lock-checking code into core...

              r24386
            
         */mercurial/dispatch.py:* in run (glob)

         */mercurial/dispatch.py:* in dispatch (glob)

         */mercurial/dispatch.py:* in _runcatch (glob)

         */mercurial/dispatch.py:* in _dispatch (glob)

         */mercurial/dispatch.py:* in runcommand (glob)

         */mercurial/dispatch.py:* in _runcommand (glob)

         */mercurial/dispatch.py:* in checkargs (glob)

         */mercurial/dispatch.py:* in <lambda> (glob)

         */mercurial/util.py:* in check (glob)

         $TESTTMP/buggylocking.py:* in buggylocking (glob)

        Pierre-Yves David
    
wlock: only issue devel warning when actually acquiring the lock...

              r24744
            
        $ hg properlocking

        Pierre-Yves David
    
wlock: do not warn for non-wait locking...

              r24750
            
        $ hg nowaitlocking

        Pierre-Yves David
    
devel: move the lock-checking code into core...

              r24386
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Pierre-Yves David devel: move the lock-checking code into core...	r24386
		$ cat << EOF > buggylocking.py
		> """A small extension that acquire locks in the wrong order
		> """
		>
		> from mercurial import cmdutil
		>
		> cmdtable = {}
		> command = cmdutil.command(cmdtable)
		>
		> @command('buggylocking', [], '')
		> def buggylocking(ui, repo):
Pierre-Yves David devel: also warn about transaction started without a lock...	r24388	> tr = repo.transaction('buggy')
Pierre-Yves David devel: move the lock-checking code into core...	r24386	> lo = repo.lock()
		> wl = repo.wlock()
Matt Mackall tests: avoid deprecation warning	r24392	> wl.release()
		> lo.release()
Pierre-Yves David wlock: only issue devel warning when actually acquiring the lock...	r24744	>
		> @command('properlocking', [], '')
		> def properlocking(ui, repo):
		> """check that reentrance is fine"""
		> wl = repo.wlock()
		> lo = repo.lock()
		> tr = repo.transaction('proper')
		> tr2 = repo.transaction('proper')
		> lo2 = repo.lock()
		> wl2 = repo.wlock()
		> wl2.release()
		> lo2.release()
		> tr2.close()
		> tr.close()
		> lo.release()
		> wl.release()
Pierre-Yves David wlock: do not warn for non-wait locking...	r24750	>
		> @command('nowaitlocking', [], '')
		> def nowaitlocking(ui, repo):
		> lo = repo.lock()
		> wl = repo.wlock(wait=False)
		> wl.release()
		> lo.release()
Pierre-Yves David devel: move the lock-checking code into core...	r24386	> EOF

		$ cat << EOF >> $HGRCPATH
		> [extensions]
		> buggylocking=$TESTTMP/buggylocking.py
		> [devel]
		> all=1
		> EOF

		$ hg init lock-checker
		$ cd lock-checker
		$ hg buggylocking
Pierre-Yves David devel-warn: add a prefix to all messages ("devel-warn: ")...	r24755	devel-warn: transaction with no lock at: $TESTTMP/buggylocking.py:11 (buggylocking)
		devel-warn: "wlock" acquired after "lock" at: $TESTTMP/buggylocking.py:13 (buggylocking)
Pierre-Yves David devel: move the lock-checking code into core...	r24386	$ cat << EOF >> $HGRCPATH
		> [devel]
		> all=0
		> check-locks=1
		> EOF
		$ hg buggylocking
Pierre-Yves David devel-warn: add a prefix to all messages ("devel-warn: ")...	r24755	devel-warn: transaction with no lock at: $TESTTMP/buggylocking.py:11 (buggylocking)
		devel-warn: "wlock" acquired after "lock" at: $TESTTMP/buggylocking.py:13 (buggylocking)
Pierre-Yves David devel: move the lock-checking code into core...	r24386	$ hg buggylocking --traceback
Pierre-Yves David devel-warn: add a prefix to all messages ("devel-warn: ")...	r24755	devel-warn: transaction with no lock at:
Matt Mackall tests: fix py2.4 glob for devel warnings	r24555	/hg: in * (glob)
Pierre-Yves David devel: also warn about transaction started without a lock...	r24388	/mercurial/dispatch.py: in run (glob)
		/mercurial/dispatch.py: in dispatch (glob)
		/mercurial/dispatch.py: in _runcatch (glob)
		/mercurial/dispatch.py: in _dispatch (glob)
		/mercurial/dispatch.py: in runcommand (glob)
		/mercurial/dispatch.py: in _runcommand (glob)
		/mercurial/dispatch.py: in checkargs (glob)
		/mercurial/dispatch.py: in <lambda> (glob)
		/mercurial/util.py: in check (glob)
		$TESTTMP/buggylocking.py:* in buggylocking (glob)
Pierre-Yves David devel-warn: add a prefix to all messages ("devel-warn: ")...	r24755	devel-warn: "wlock" acquired after "lock" at:
Matt Mackall tests: fix py2.4 glob for devel warnings	r24555	/hg: in * (glob)
Pierre-Yves David devel: move the lock-checking code into core...	r24386	/mercurial/dispatch.py: in run (glob)
		/mercurial/dispatch.py: in dispatch (glob)
		/mercurial/dispatch.py: in _runcatch (glob)
		/mercurial/dispatch.py: in _dispatch (glob)
		/mercurial/dispatch.py: in runcommand (glob)
		/mercurial/dispatch.py: in _runcommand (glob)
		/mercurial/dispatch.py: in checkargs (glob)
		/mercurial/dispatch.py: in <lambda> (glob)
		/mercurial/util.py: in check (glob)
		$TESTTMP/buggylocking.py:* in buggylocking (glob)
Pierre-Yves David wlock: only issue devel warning when actually acquiring the lock...	r24744	$ hg properlocking
Pierre-Yves David wlock: do not warn for non-wait locking...	r24750	$ hg nowaitlocking
Pierre-Yves David devel: move the lock-checking code into core...	r24386	$ cd ..