##// END OF EJS Templates
progress: avoid ui.configbool() lookup when progress bar is active...
progress: avoid ui.configbool() lookup when progress bar is active Profiling revealed that the ui.configbool('progress', 'debug') during progress bar updates was consuming a significant amount of overhead. This commit adds an attribute on progress bar instances that caches this config option. The impact on `hg perfprogress` with default options is significant: before: ! wall 4.641942 comb 4.580000 user 4.210000 sys 0.370000 (best of 3) after: ! wall 1.948626 comb 1.950000 user 1.950000 sys 0.000000 (best of 5) After this change, profiling reveals that progress.progbar.progress() is now consuming ~73% of time. This change does not improve the execution time if the progress bar is disabled. We may want a more comprehensive solution for that case, as the progress bar won't be enabled in a number of scenarios (e.g. servers and processes not attached to an interactive TTY). I also think that overhead of ~2.0s for 1M updates is a bit high. I suspect further refactoring of the progress bar can significantly reduce overhead. I don't have plans to do this, however. Differential Revision: https://phab.mercurial-scm.org/D5408

File last commit:

r38915:e79a69af default
r41093:6603de28 default
Show More
minifileset.py
92 lines | 3.5 KiB | text/x-python | PythonLexer
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 # minifileset.py - a simple language to select files
#
# Copyright 2017 Facebook, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
from .i18n import _
from . import (
error,
fileset,
Yuya Nishihara
fileset: extract language processing part to new module (API)...
r38841 filesetlang,
Augie Fackler
minifileset: fix on Python 3...
r37893 pycompat,
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 )
Yuya Nishihara
fileset: parse argument of size() by predicate function...
r38709 def _sizep(x):
# i18n: "size" is a keyword
Yuya Nishihara
fileset: extract language processing part to new module (API)...
r38841 expr = filesetlang.getstring(x, _("size requires an expression"))
Yuya Nishihara
fileset: parse argument of size() by predicate function...
r38709 return fileset.sizematcher(expr)
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 def _compile(tree):
if not tree:
raise error.ParseError(_("missing argument"))
op = tree[0]
Yuya Nishihara
fileset: insert hints where status should be computed...
r38915 if op == 'withstatus':
return _compile(tree[1])
elif op in {'symbol', 'string', 'kindpat'}:
Yuya Nishihara
fileset: extract language processing part to new module (API)...
r38841 name = filesetlang.getpattern(tree, {'path'}, _('invalid file pattern'))
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 if name.startswith('**'): # file extension test, ex. "**.tar.gz"
ext = name[2:]
Augie Fackler
minifileset: fix on Python 3...
r37893 for c in pycompat.bytestr(ext):
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 if c in '*{}[]?/\\':
raise error.ParseError(_('reserved character: %s') % c)
return lambda n, s: n.endswith(ext)
Yuya Nishihara
minifileset: unify handling of symbol and string patterns...
r35758 elif name.startswith('path:'): # directory or full path test
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 p = name[5:] # prefix
pl = len(p)
Augie Fackler
minifileset: fix on Python 3...
r37893 f = lambda n, s: n.startswith(p) and (len(n) == pl
or n[pl:pl + 1] == '/')
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 return f
Matt Harbison
minifileset: note the unsupported file pattern when raising a parse error...
r35818 raise error.ParseError(_("unsupported file pattern: %s") % name,
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 hint=_('paths must be prefixed with "path:"'))
Yuya Nishihara
fileset: combine union of basic patterns into single matcher...
r38901 elif op in {'or', 'patterns'}:
Yuya Nishihara
fileset: flatten 'or' nodes to unnest unionmatchers...
r38840 funcs = [_compile(x) for x in tree[1:]]
return lambda n, s: any(f(n, s) for f in funcs)
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 elif op == 'and':
func1 = _compile(tree[1])
func2 = _compile(tree[2])
return lambda n, s: func1(n, s) and func2(n, s)
elif op == 'not':
return lambda n, s: not _compile(tree[1])(n, s)
elif op == 'func':
symbols = {
'all': lambda n, s: True,
'none': lambda n, s: False,
Yuya Nishihara
fileset: parse argument of size() by predicate function...
r38709 'size': lambda n, s: _sizep(tree[2])(s),
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 }
Yuya Nishihara
fileset: extract language processing part to new module (API)...
r38841 name = filesetlang.getsymbol(tree[1])
Yuya Nishihara
fileset: make it robust for bad function calls...
r35709 if name in symbols:
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 return symbols[name]
raise error.UnknownIdentifier(name, symbols.keys())
elif op == 'minus': # equivalent to 'x and not y'
func1 = _compile(tree[1])
func2 = _compile(tree[2])
return lambda n, s: func1(n, s) and not func2(n, s)
elif op == 'list':
raise error.ParseError(_("can't use a list in this context"),
Martin von Zweigbergk
help: add quotes to a few commands we point to...
r38846 hint=_('see \'hg help "filesets.x or y"\''))
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 raise error.ProgrammingError('illegal tree: %r' % (tree,))
def compile(text):
"""generate a function (path, size) -> bool from filter specification.
"text" could contain the operators defined by the fileset language for
common logic operations, and parenthesis for grouping. The supported path
tests are '**.extname' for file extension test, and '"path:dir/subdir"'
for prefix test. The ``size()`` predicate is borrowed from filesets to test
file size. The predicates ``all()`` and ``none()`` are also supported.
Yuya Nishihara
fileset: add kind:pat operator...
r35759 '(**.php & size(">10MB")) | **.zip | (path:bin & !path:bin/README)' for
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 example, will catch all php files whose size is greater than 10 MB, all
files whose name ends with ".zip", and all files under "bin" in the repo
root except for "bin/README".
"""
Yuya Nishihara
fileset: extract language processing part to new module (API)...
r38841 tree = filesetlang.parse(text)
Yuya Nishihara
fileset: add phase to transform parsed tree...
r38862 tree = filesetlang.analyze(tree)
Yuya Nishihara
fileset: add stub for weight-based optimization...
r38865 tree = filesetlang.optimize(tree)
Matt Harbison
fileset: add a lightweight file filtering language...
r35634 return _compile(tree)