##// END OF EJS Templates
wireproto: formalize permissions checking as part of protocol interface...
wireproto: formalize permissions checking as part of protocol interface Per the inline comment desiring to formalize permissions checking in the protocol interface, we do that. I'm not convinced this is the best way to go about things. I would love for there to e.g. be a better exception for denoting permissions problems. But it does feel strictly better than snipping attributes on the proto instance. Differential Revision: https://phab.mercurial-scm.org/D2719

File last commit:

r36797:bf9a04d7 default
r36819:66de4555 default
Show More
server.py
347 lines | 11.9 KiB | text/x-python | PythonLexer
Eric Hopper
Fixing up comment headers for split up code.
r2391 # hgweb/server.py - The standalone hg web server.
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 #
# Copyright 21 May 2005 - (c) 2005 Jake Edge <jake@edge2.net>
Thomas Arendsen Hein
Updated copyright notices and add "and others" to "hg version"
r4635 # Copyright 2005-2007 Matt Mackall <mpm@selenic.com>
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 #
Martin Geisler
updated license to be explicit about GPL version 2
r8225 # This software may be used and distributed according to the terms of the
Matt Mackall
Update license to GPLv2+
r10263 # GNU General Public License version 2 or any later version.
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Yuya Nishihara
hgweb: use absolute_import
r27046 from __future__ import absolute_import
import errno
import os
import socket
import sys
import traceback
from ..i18n import _
from .. import (
Augie Fackler
hgweb: fix logging to use native strings as appropriate...
r34707 encoding,
Yuya Nishihara
hgweb: use absolute_import
r27046 error,
Pulkit Goyal
py3: replace os.name with pycompat.osname (part 1 of 2)...
r30639 pycompat,
Yuya Nishihara
hgweb: use absolute_import
r27046 util,
)
Pulkit Goyal
py3: conditionalize BaseHTTPServer, SimpleHTTPServer and CGIHTTPServer import...
r29566 httpservermod = util.httpserver
Pulkit Goyal
py3: conditionalize SocketServer import...
r29433 socketserver = util.socketserver
timeless
pycompat: switch to util.urlreq/util.urlerr for py3 compat
r28883 urlerr = util.urlerr
urlreq = util.urlreq
Yuya Nishihara
hgweb: use absolute_import
r27046 from . import (
common,
)
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
def _splitURI(uri):
Mads Kiilerich
improve some comments and docstrings, fixing issues found when spell checking
r17427 """Return path and query that has been split from uri
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Just like CGI environment, the path is unquoted, the query is
not.
"""
Augie Fackler
hgweb: more native string treatment in query string parsing...
r34701 if r'?' in uri:
path, query = uri.split(r'?', 1)
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 else:
Augie Fackler
hgweb: more native string treatment in query string parsing...
r34701 path, query = uri, r''
timeless
pycompat: switch to util.urlreq/util.urlerr for py3 compat
r28883 return urlreq.unquote(path), query
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Eric Hopper
This patch make several WSGI related alterations....
r2506 class _error_logger(object):
def __init__(self, handler):
self.handler = handler
def flush(self):
pass
Benoit Boissinot
hgweb: fix errors spotted by pychecker
r3130 def write(self, str):
Eric Hopper
This patch make several WSGI related alterations....
r2506 self.writelines(str.split('\n'))
Benoit Boissinot
hgweb: fix errors spotted by pychecker
r3130 def writelines(self, seq):
Eric Hopper
This patch make several WSGI related alterations....
r2506 for msg in seq:
self.handler.log_error("HG error: %s", msg)
Pulkit Goyal
py3: conditionalize BaseHTTPServer, SimpleHTTPServer and CGIHTTPServer import...
r29566 class _httprequesthandler(httpservermod.basehttprequesthandler):
Wesley J. Landaker
Make hg serve set the wsgi.url_scheme property correctly....
r4870
url_scheme = 'http'
Thomas Arendsen Hein
removed trailing whitespace
r4957
Mads Kiilerich
hgweb: refactor all pyOpenSSL references into one class
r12783 @staticmethod
Gregory Szorc
hgweb: pass ui into preparehttpserver...
r29553 def preparehttpserver(httpserver, ui):
Mads Kiilerich
hgweb: refactor all pyOpenSSL references into one class
r12783 """Prepare .socket of new HTTPServer instance"""
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 def __init__(self, *args, **kargs):
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 self.protocol_version = r'HTTP/1.1'
Pulkit Goyal
py3: conditionalize BaseHTTPServer, SimpleHTTPServer and CGIHTTPServer import...
r29566 httpservermod.basehttprequesthandler.__init__(self, *args, **kargs)
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Patrick Mezard
hgweb.server: flush log files after every access
r5549 def _log_any(self, fp, format, *args):
Augie Fackler
hgweb: fix logging to use native strings as appropriate...
r34707 fp.write(pycompat.sysbytes(
r"%s - - [%s] %s" % (self.client_address[0],
self.log_date_time_string(),
format % args)) + '\n')
Patrick Mezard
hgweb.server: flush log files after every access
r5549 fp.flush()
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 def log_error(self, format, *args):
Patrick Mezard
hgweb.server: flush log files after every access
r5549 self._log_any(self.server.errorlog, format, *args)
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
def log_message(self, format, *args):
Patrick Mezard
hgweb.server: flush log files after every access
r5549 self._log_any(self.server.accesslog, format, *args)
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Augie Fackler
hgweb: fix logging to use native strings as appropriate...
r34707 def log_request(self, code=r'-', size=r'-'):
David Soria Parra
hgweb: log headers only if headers were successfully parsed...
r19877 xheaders = []
if util.safehasattr(self, 'headers'):
xheaders = [h for h in self.headers.items()
Augie Fackler
hgweb: fix logging to use native strings as appropriate...
r34707 if h[0].startswith(r'x-')]
self.log_message(r'"%s" %s %s%s',
Steven Brown
httprepo: long arguments support (issue2126)...
r14093 self.requestline, str(code), str(size),
Augie Fackler
hgweb: fix logging to use native strings as appropriate...
r34707 r''.join([r' %s:%s' % h for h in sorted(xheaders)]))
Steven Brown
httprepo: long arguments support (issue2126)...
r14093
Brendan Cully
Add SSL support to hg serve, activated via --certificate option
r4860 def do_write(self):
try:
self.do_hgweb()
Gregory Szorc
global: mass rewrite to use modern exception syntax...
r25660 except socket.error as inst:
Brendan Cully
Add SSL support to hg serve, activated via --certificate option
r4860 if inst[0] != errno.EPIPE:
raise
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 def do_POST(self):
try:
Brendan Cully
Add SSL support to hg serve, activated via --certificate option
r4860 self.do_write()
Mads Kiilerich
serve: catch and log all Exceptions, not only StandardException...
r13443 except Exception:
Thomas Arendsen Hein
Handle exceptions in do_hgweb: Send "Internal Server Error", log traceback
r4015 self._start_response("500 Internal Server Error", [])
self._write("Internal Server Error")
Gregory Szorc
hgweb: send proper HTTP response after uncaught exception...
r23409 self._done()
Augie Fackler
hgweb: fix logging to use native strings as appropriate...
r34707 tb = r"".join(traceback.format_exception(*sys.exc_info()))
# We need a native-string newline to poke in the log
# message, because we won't get a newline when using an
# r-string. This is the easy way out.
newline = chr(10)
self.log_error(r"Exception happened during processing "
r"request '%s':%s%s", self.path, newline, tb)
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
def do_GET(self):
self.do_POST()
def do_hgweb(self):
Augie Fackler
hgweb: set sent_headers attr as early as practical...
r34721 self.sent_headers = False
Michele Cella
adding "prefix" option to "hg serve" (command line and [web] section)...
r5835 path, query = _splitURI(self.path)
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
env = {}
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 env[r'GATEWAY_INTERFACE'] = r'CGI/1.1'
env[r'REQUEST_METHOD'] = self.command
env[r'SERVER_NAME'] = self.server.server_name
env[r'SERVER_PORT'] = str(self.server.server_port)
env[r'REQUEST_URI'] = self.path
env[r'SCRIPT_NAME'] = self.server.prefix
env[r'PATH_INFO'] = path[len(self.server.prefix):]
env[r'REMOTE_HOST'] = self.client_address[0]
env[r'REMOTE_ADDR'] = self.client_address[0]
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 if query:
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 env[r'QUERY_STRING'] = query
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Augie Fackler
hgweb: detect Python 3-era libraries and use modern attribute names...
r34720 if pycompat.ispy3:
if self.headers.get_content_type() is None:
env[r'CONTENT_TYPE'] = self.headers.get_default_type()
else:
env[r'CONTENT_TYPE'] = self.headers.get_content_type()
length = self.headers.get('content-length')
else:
Augie Fackler
server: indent block that's about to get conditionalized...
r34719 if self.headers.typeheader is None:
env[r'CONTENT_TYPE'] = self.headers.type
else:
env[r'CONTENT_TYPE'] = self.headers.typeheader
length = self.headers.getheader('content-length')
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355 if length:
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 env[r'CONTENT_LENGTH'] = length
Thomas Arendsen Hein
Cleanup of whitespace, indentation and line continuation.
r4633 for header in [h for h in self.headers.keys()
Eric Hopper
Fix server to set up a more WSGI compliant environment.
r2505 if h not in ('content-type', 'content-length')]:
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 hkey = r'HTTP_' + header.replace(r'-', r'_').upper()
hval = self.headers.get(header)
hval = hval.replace(r'\n', r'').strip()
Eric Hopper
Fix server to set up a more WSGI compliant environment.
r2505 if hval:
env[hkey] = hval
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 env[r'SERVER_PROTOCOL'] = self.request_version
env[r'wsgi.version'] = (1, 0)
env[r'wsgi.url_scheme'] = self.url_scheme
if env.get(r'HTTP_EXPECT', '').lower() == '100-continue':
Augie Fackler
hgweb: add support for 100-continue as recommended by PEP 333.
r13570 self.rfile = common.continuereader(self.rfile, self.wfile.write)
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 env[r'wsgi.input'] = self.rfile
env[r'wsgi.errors'] = _error_logger(self)
env[r'wsgi.multithread'] = isinstance(self.server,
Pulkit Goyal
py3: conditionalize SocketServer import...
r29433 socketserver.ThreadingMixIn)
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 env[r'wsgi.multiprocess'] = isinstance(self.server,
Pulkit Goyal
py3: conditionalize SocketServer import...
r29433 socketserver.ForkingMixIn)
Augie Fackler
hgweb: when constructing or adding to a wsgi environ dict, use native strs...
r34513 env[r'wsgi.run_once'] = 0
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Eric Hopper
This patch make several WSGI related alterations....
r2506 self.saved_status = None
self.saved_headers = []
Eric Hopper
Put support for persistent connections back in.
r2508 self.length = None
Mads Kiilerich
serve: use chunked encoding in hgweb responses...
r18354 self._chunked = None
Dirkjan Ochtman
hgweb: all protocol functions have become generators...
r6784 for chunk in self.server.application(env, self._start_response):
self._write(chunk)
Mads Kiilerich
serve: send response headers even if response has no body...
r18349 if not self.sent_headers:
self.send_headers()
Mads Kiilerich
serve: use chunked encoding in hgweb responses...
r18354 self._done()
Eric Hopper
This patch make several WSGI related alterations....
r2506
def send_headers(self):
if not self.saved_status:
Martin Geisler
wrap string literals in error messages
r8663 raise AssertionError("Sending headers before "
"start_response() called")
Eric Hopper
This patch make several WSGI related alterations....
r2506 saved_status = self.saved_status.split(None, 1)
saved_status[0] = int(saved_status[0])
self.send_response(*saved_status)
Mads Kiilerich
serve: use chunked encoding in hgweb responses...
r18354 self.length = None
self._chunked = False
Eric Hopper
This patch make several WSGI related alterations....
r2506 for h in self.saved_headers:
self.send_header(*h)
Eric Hopper
Put support for persistent connections back in.
r2508 if h[0].lower() == 'content-length':
self.length = int(h[1])
Mads Kiilerich
serve: don't send any content headers with 304 responses...
r18380 if (self.length is None and
saved_status[0] != common.HTTP_NOT_MODIFIED):
Mads Kiilerich
serve: use chunked encoding in hgweb responses...
r18354 self._chunked = (not self.close_connection and
self.request_version == "HTTP/1.1")
if self._chunked:
Augie Fackler
hgweb: more "http headers are native strs" cleanup...
r34741 self.send_header(r'Transfer-Encoding', r'chunked')
Mads Kiilerich
serve: use chunked encoding in hgweb responses...
r18354 else:
Augie Fackler
hgweb: more "http headers are native strs" cleanup...
r34741 self.send_header(r'Connection', r'close')
Eric Hopper
This patch make several WSGI related alterations....
r2506 self.end_headers()
self.sent_headers = True
def _start_response(self, http_status, headers, exc_info=None):
code, msg = http_status.split(None, 1)
code = int(code)
self.saved_status = http_status
Eric Hopper
Put support for persistent connections back in.
r2508 bad_headers = ('connection', 'transfer-encoding')
Thomas Arendsen Hein
Cleanup of whitespace, indentation and line continuation.
r4633 self.saved_headers = [h for h in headers
if h[0].lower() not in bad_headers]
Eric Hopper
This patch make several WSGI related alterations....
r2506 return self._write
def _write(self, data):
if not self.saved_status:
raise AssertionError("data written before start_response() called")
elif not self.sent_headers:
self.send_headers()
Eric Hopper
Put support for persistent connections back in.
r2508 if self.length is not None:
if len(data) > self.length:
Martin Geisler
wrap string literals in error messages
r8663 raise AssertionError("Content-length header sent, but more "
"bytes than specified are being written.")
Eric Hopper
Put support for persistent connections back in.
r2508 self.length = self.length - len(data)
Mads Kiilerich
serve: use chunked encoding in hgweb responses...
r18354 elif self._chunked and data:
data = '%x\r\n%s\r\n' % (len(data), data)
Eric Hopper
This patch make several WSGI related alterations....
r2506 self.wfile.write(data)
self.wfile.flush()
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Mads Kiilerich
serve: use chunked encoding in hgweb responses...
r18354 def _done(self):
if self._chunked:
self.wfile.write('0\r\n\r\n')
self.wfile.flush()
Mads Kiilerich
hgweb: use Pythons ssl module for HTTPS serve when using Python 2.6 or later...
r12784 class _httprequesthandlerssl(_httprequesthandler):
timeless@mozdev.org
hgweb.server: fix _httprequesthandlerssl help text
r26202 """HTTPS handler based on Python's ssl module"""
Mads Kiilerich
hgweb: use Pythons ssl module for HTTPS serve when using Python 2.6 or later...
r12784
url_scheme = 'https'
@staticmethod
Gregory Szorc
hgweb: pass ui into preparehttpserver...
r29553 def preparehttpserver(httpserver, ui):
Mads Kiilerich
hgweb: use Pythons ssl module for HTTPS serve when using Python 2.6 or later...
r12784 try:
Gregory Szorc
hgweb: use sslutil.wrapserversocket()...
r29555 from .. import sslutil
sslutil.modernssl
Mads Kiilerich
hgweb: use Pythons ssl module for HTTPS serve when using Python 2.6 or later...
r12784 except ImportError:
Pierre-Yves David
error: get Abort from 'error' instead of 'util'...
r26587 raise error.Abort(_("SSL support is unavailable"))
Gregory Szorc
hgweb: pass ui into preparehttpserver...
r29553
certfile = ui.config('web', 'certificate')
Gregory Szorc
hgweb: use sslutil.wrapserversocket()...
r29555
# These config options are currently only meant for testing. Use
# at your own risk.
cafile = ui.config('devel', 'servercafile')
reqcert = ui.configbool('devel', 'serverrequirecert')
httpserver.socket = sslutil.wrapserversocket(httpserver.socket,
ui,
certfile=certfile,
cafile=cafile,
requireclientcert=reqcert)
Mads Kiilerich
hgweb: use Pythons ssl module for HTTPS serve when using Python 2.6 or later...
r12784
def setup(self):
self.connection = self.request
Augie Fackler
hgweb: adapt to socket._fileobject changes in Python 3...
r36797 self.rfile = self.request.makefile(r"rb", self.rbufsize)
self.wfile = self.request.makefile(r"wb", self.wbufsize)
Mads Kiilerich
hgweb: use Pythons ssl module for HTTPS serve when using Python 2.6 or later...
r12784
Dirkjan Ochtman
server: externalize and streamline mixin setup
r10639 try:
Yuya Nishihara
hgweb: use absolute_import
r27046 import threading
threading.activeCount() # silence pyflakes and bypass demandimport
Pulkit Goyal
py3: conditionalize SocketServer import...
r29433 _mixin = socketserver.ThreadingMixIn
Dirkjan Ochtman
server: externalize and streamline mixin setup
r10639 except ImportError:
Augie Fackler
hgweb: move remaining hasattr calls to safehasattr
r14957 if util.safehasattr(os, "fork"):
Pulkit Goyal
py3: conditionalize SocketServer import...
r29433 _mixin = socketserver.ForkingMixIn
Dirkjan Ochtman
server: externalize and streamline mixin setup
r10639 else:
Thomas Arendsen Hein
classes: fix class style problems found by b071cd58af50...
r14764 class _mixin(object):
Dirkjan Ochtman
server: externalize and streamline mixin setup
r10639 pass
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643 def openlog(opt, default):
if opt and opt != '-':
Augie Fackler
hgweb: open server logs in binary mode...
r36271 return open(opt, 'ab')
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643 return default
Martijn Pieters
hgweb: fix the MRO in Python 3...
r30082 class MercurialHTTPServer(_mixin, httpservermod.httpserver, object):
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643
# SO_REUSEADDR has broken semantics on windows
Jun Wu
codemod: use pycompat.iswindows...
r34646 if pycompat.iswindows:
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643 allow_reuse_address = 0
def __init__(self, ui, app, addr, handler, **kwargs):
Pulkit Goyal
py3: conditionalize BaseHTTPServer, SimpleHTTPServer and CGIHTTPServer import...
r29566 httpservermod.httpserver.__init__(self, addr, handler, **kwargs)
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643 self.daemon_threads = True
self.application = app
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Gregory Szorc
hgweb: pass ui into preparehttpserver...
r29553 handler.preparehttpserver(self, ui)
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643
Boris Feld
configitems: register the 'web.prefix' config
r34240 prefix = ui.config('web', 'prefix')
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643 if prefix:
prefix = '/' + prefix.strip('/')
self.prefix = prefix
Boris Feld
configitems: register the 'web.accesslog' config
r34224 alog = openlog(ui.config('web', 'accesslog'), ui.fout)
Boris Feld
configitems: register the 'web.errorlog' config
r34237 elog = openlog(ui.config('web', 'errorlog'), ui.ferr)
Dirkjan Ochtman
server: unnest server classes into module namespace
r10643 self.accesslog = alog
self.errorlog = elog
self.addr, self.port = self.socket.getsockname()[0:2]
self.fqaddr = socket.getfqdn(addr[0])
class IPv6HTTPServer(MercurialHTTPServer):
address_family = getattr(socket, 'AF_INET6', None)
def __init__(self, *args, **kwargs):
if self.address_family is None:
raise error.RepoError(_('IPv6 is not available on this system'))
super(IPv6HTTPServer, self).__init__(*args, **kwargs)
Dirkjan Ochtman
server: initialize wsgi app in command, then wrap server around it
r10644 def create_server(ui, app):
Eric Hopper
Splitting up hgweb so it's easier to change.
r2355
Dirkjan Ochtman
server: initialize wsgi app in command, then wrap server around it
r10644 if ui.config('web', 'certificate'):
Siddharth Agarwal
hgweb.server: drop support for Python 2.4
r26848 handler = _httprequesthandlerssl
Brendan Cully
Add SSL support to hg serve, activated via --certificate option
r4860 else:
Mads Kiilerich
hgweb: refactor all pyOpenSSL references into one class
r12783 handler = _httprequesthandler
Brendan Cully
Add SSL support to hg serve, activated via --certificate option
r4860
Dirkjan Ochtman
server: initialize wsgi app in command, then wrap server around it
r10644 if ui.configbool('web', 'ipv6'):
Dirkjan Ochtman
server: abstract setup of ipv6 vs. normal server
r10641 cls = IPv6HTTPServer
else:
cls = MercurialHTTPServer
Dirkjan Ochtman
hgweb: pre-init mimetypes module (fixes ugly bug in python-2.6.2 mimetypes)...
r8224 # ugly hack due to python issue5853 (for threaded use)
Matt Mackall
hgweb: hack around mimetypes encoding thinko (issue4160)...
r20357 try:
import mimetypes
mimetypes.init()
except UnicodeDecodeError:
# Python 2.x's mimetypes module attempts to decode strings
# from Windows' ANSI APIs as ascii (fail), then re-encode them
# as ascii (clown fail), because the default Python Unicode
# codec is hardcoded as ascii.
Yuya Nishihara
hgweb: make sure sys module is loaded prior to reload hack...
r20529 sys.argv # unwrap demand-loader so that reload() works
Matt Mackall
hgweb: hack around mimetypes encoding thinko (issue4160)...
r20357 reload(sys) # resurrect sys.setdefaultencoding()
oldenc = sys.getdefaultencoding()
sys.setdefaultencoding("latin1") # or any full 8-bit encoding
mimetypes.init()
sys.setdefaultencoding(oldenc)
Dirkjan Ochtman
hgweb: pre-init mimetypes module (fixes ugly bug in python-2.6.2 mimetypes)...
r8224
Boris Feld
configitems: register the 'web.address' config
r34225 address = ui.config('web', 'address')
Boris Feld
configitems: register the 'web.port' config
r34239 port = util.getport(ui.config('web', 'port'))
Matt Mackall
hgweb: internalize some socket details
r3628 try:
Dirkjan Ochtman
server: initialize wsgi app in command, then wrap server around it
r10644 return cls(ui, app, (address, port), handler)
Gregory Szorc
global: mass rewrite to use modern exception syntax...
r25660 except socket.error as inst:
Pierre-Yves David
error: get Abort from 'error' instead of 'util'...
r26587 raise error.Abort(_("cannot start server at '%s:%d': %s")
Augie Fackler
hgweb: fix logging to use native strings as appropriate...
r34707 % (address, port, encoding.strtolocal(inst.args[1])))