##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

hgweb: fail if an invalid command was supplied in url path (issue4071)...
hgweb: fail if an invalid command was supplied in url path (issue4071) Traditionally, the way to specify a command for hgweb was to use url query arguments (e.g. "?cmd=batch"). If the command is unknown to hgweb, it gives an error (e.g. "400 no such method: badcmd"). But there's also another way to specify a command: as a url path fragment (e.g. "/graph"). Before, hgweb was made forgiving (looks like it was made in 44c5157474e7) and user could put any unknown command in the url. If hgweb couldn't understand it, it would just silently fall back to the default command, which depends on the actual style (e.g. for paper it's shortlog, for monoblue it's summary). This was inconsistent and was breaking some tools that rely on http status codes (as noted in the issue4071). So this patch changes that behavior to the more consistent one, i.e. hgweb will now return "400 no such method: badcmd". So if some tool was relying on having an invalid command return http status code 200 and also have some information, then it will stop working. That is, if somebody typed foobar when they really meant shortlog (and the user was lucky enough to choose a style where the default command is shortlog too), that fact will now be revealed. Code-wise, the changed if block is only relevant when there's no "?cmd" query parameter (i.e. only when command is specified as a url path fragment), and looks like the removed else branch was there only for falling back to default command. With that removed, the rest of the code works as expected: it looks at the command, and if it's not known, raises a proper ErrorResponse exception with an appropriate message. Evidently, there were no tests that required the old behavior. But, frankly, I don't know any way to tell if anyone actually exploited such forgiving behavior in some in-house tool.
Matt Mackall - - Load All Authors

File last commit:

r10263:25e57239 stable
r22506:6e1fbcb1 stable
Show More
node.py
18 lines | 449 B | text/x-python | PythonLexer
/ mercurial / node.py
History | Source | Raw |Copy content |Copy permalink
Martin Geisler
put license and copyright info into comment blocks
 r8226 # node.py - basic nodeid manipulation for mercurial
#
# Copyright 2005, 2006 Matt Mackall <mpm@selenic.com>
#
# This software may be used and distributed according to the terms of the
Matt Mackall
Update license to GPLv2+
 r10263 # GNU General Public License version 2 or any later version.
mpm@selenic.com
Break apart hg.py...
 r1089
Matt Mackall
Replace demandload with new demandimport
 r3877 import binascii
mpm@selenic.com
Break apart hg.py...
 r1089
Thomas Arendsen Hein
Define and use nullrev (revision of nullid) instead of -1.
 r3578 nullrev = -1
mpm@selenic.com
Break apart hg.py...
 r1089 nullid = "\0" * 20
Matt Mackall
manifest: speed up creation of the manifestdict...
 r4995 # This ugly style has a noticeable effect in manifest parsing
hex = binascii.hexlify
bin = binascii.unhexlify
mpm@selenic.com
Break apart hg.py...
 r1089
def short(node):
return hex(node[:6])