##// END OF EJS Templates
bookmarks: fix _bookmarks/lookup() reentrancy issue (issue2016)...
bookmarks: fix _bookmarks/lookup() reentrancy issue (issue2016) _bookmarks is loaded lazily and calls super.lookup(). Unfortunately, branch and tags caches initializations also recurse in lookup() and end up trying to access _bookmarks again. Massive confusion ensues. I considered fixing all branches and tags cache loading to avoid recursing in lookup() but it would add complexity to otherwise working code provided lookups are performed on nodes or revnums.

File last commit:

r12392:74129048 stable
r12392:74129048 stable
Show More
test-bookmarks-strip.out
24 lines | 651 B | text/plain | TextLexer
/ tests / test-bookmarks-strip.out
David Soria Parra
bookmarks: Use dirstate to determine the current node in addchangegroup...
r7316 % add file
adding qqq.txt
% commit first revision
% set bookmark
% commit second revision
% set bookmark
% update to -2
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
% commit new head
created new head
% bookmarks updated?
test 1:16b24da7e457
test2 1:16b24da7e457
% strip to revision 1
Matt Mackall
strip: improve full backup message
r11200 saved backup bundle to
David Soria Parra
bookmarks: Use dirstate to determine the current node in addchangegroup...
r7316 % list bookmarks
* test 1:9f1b7e78eff8
* test2 1:9f1b7e78eff8
Patrick Mezard
bookmarks: fix _bookmarks/lookup() reentrancy issue (issue2016)...
r12392 % test immediate rollback and reentrancy issue
adding a
adding b
rolling back to revision 0 (undo commit)
no bookmarks set
* markb 0:07f494440405