upstream/mercurial-mirror Files · mercurial/bitmanipulation.h

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Maciej Fijalkowski - - Load All Authors

File last commit:

r29444:284d742e default


                r32050:77eaf953

4.1.3 stable

Download file

             bitmanipulation.h
        
                    53 lines
            
             | 933 B
            
                | text/x-c
            
             |
                CLexer
            
             / mercurial / bitmanipulation.h
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Maciej Fijalkowski
    
internals: move the bitmanipulation routines into its own file...

              r29444
            
      #ifndef _HG_BITMANIPULATION_H_

      #define _HG_BITMANIPULATION_H_

      #include "compat.h"

      static inline uint32_t getbe32(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 24) |

      		(d[1] << 16) |

      		(d[2] << 8) |

      		(d[3]));

      }

      static inline int16_t getbeint16(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 8) |

      		(d[1]));

      }

      static inline uint16_t getbeuint16(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	return ((d[0] << 8) |

      		(d[1]));

      }

      static inline void putbe32(uint32_t x, char *c)

      {

      	c[0] = (x >> 24) & 0xff;

      	c[1] = (x >> 16) & 0xff;

      	c[2] = (x >> 8) & 0xff;

      	c[3] = (x) & 0xff;

      }

      static inline double getbefloat64(const char *c)

      {

      	const unsigned char *d = (const unsigned char *)c;

      	double ret;

      	int i;

      	uint64_t t = 0;

      	for (i = 0; i < 8; i++) {

      		t = (t<<8) + d[i];

      	}

      	memcpy(&ret, &t, sizeof(t));

      	return ret;

      }

      #endif

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Maciej Fijalkowski internals: move the bitmanipulation routines into its own file...	r29444	#ifndef _HG_BITMANIPULATION_H_
		#define _HG_BITMANIPULATION_H_

		#include "compat.h"

		static inline uint32_t getbe32(const char *c)
		{
		const unsigned char d = (const unsigned char )c;

		return ((d[0] << 24) \|
		(d[1] << 16) \|
		(d[2] << 8) \|
		(d[3]));
		}

		static inline int16_t getbeint16(const char *c)
		{
		const unsigned char d = (const unsigned char )c;

		return ((d[0] << 8) \|
		(d[1]));
		}

		static inline uint16_t getbeuint16(const char *c)
		{
		const unsigned char d = (const unsigned char )c;

		return ((d[0] << 8) \|
		(d[1]));
		}

		static inline void putbe32(uint32_t x, char *c)
		{
		c[0] = (x >> 24) & 0xff;
		c[1] = (x >> 16) & 0xff;
		c[2] = (x >> 8) & 0xff;
		c[3] = (x) & 0xff;
		}

		static inline double getbefloat64(const char *c)
		{
		const unsigned char d = (const unsigned char )c;
		double ret;
		int i;
		uint64_t t = 0;
		for (i = 0; i < 8; i++) {
		t = (t<<8) + d[i];
		}
		memcpy(&ret, &t, sizeof(t));
		return ret;
		}

		#endif