##// END OF EJS Templates
dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...
dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

File last commit:

r31007:bfdb0741 default
r32050:77eaf953 4.1.3 stable
Show More
dummyssh
26 lines | 556 B | text/plain | TextLexer
Mads Kiilerich
tests: share dummyssh
r14186 #!/usr/bin/env python
Pulkit Goyal
py3: make tests/dummyssh use absolute_import
r29159 from __future__ import absolute_import
import os
Mads Kiilerich
tests: share dummyssh
r14186 import sys
os.chdir(os.getenv('TESTTMP'))
if sys.argv[1] != "user@dummy":
sys.exit(-1)
os.environ["SSH_CLIENT"] = "127.0.0.1 1 2"
log = open("dummylog", "ab")
log.write("Got arguments")
for i, arg in enumerate(sys.argv[1:]):
Augie Fackler
dummyssh: fix check-code nit
r19320 log.write(" %d:%s" % (i + 1, arg))
Mads Kiilerich
tests: share dummyssh
r14186 log.write("\n")
log.close()
Mads Kiilerich
tests: make simple single quotes work with dummyssh on windows...
r15768 hgcmd = sys.argv[2]
if os.name == 'nt':
# hack to make simple unix single quote quoting work on windows
hgcmd = hgcmd.replace("'", '"')
r = os.system(hgcmd)
Mads Kiilerich
tests: share dummyssh
r14186 sys.exit(bool(r))