upstream/mercurial-mirror Files · tests/mockblackbox.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Robert Stanca - - Load All Authors

File last commit:

r28943:417380aa default


                r32050:77eaf953

4.1.3 stable

Download file

             mockblackbox.py
        
                    17 lines
            
             | 332 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / mockblackbox.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Robert Stanca
    
py3: use absolute_import in mockblackbox.py

              r28943
            
      from __future__ import absolute_import

      from mercurial import (

          util,

      )

        Gregory Szorc
    
tests: move mock blackbox extension into own file...

              r24705
            
      def makedate():

          return 0, 0

      def getuser():

          return 'bob'

        timeless
    
tests: mock getpid to reduce glob usage...

              r28028
            
      def getpid():

          return 5000

        Gregory Szorc
    
tests: move mock blackbox extension into own file...

              r24705
            
      # mock the date and user apis so the output is always the same

      def uisetup(ui):

          util.makedate = makedate

          util.getuser = getuser

        timeless
    
tests: mock getpid to reduce glob usage...

              r28028
            
          util.getpid = getpid

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Robert Stanca py3: use absolute_import in mockblackbox.py	r28943	from __future__ import absolute_import
		from mercurial import (
		util,
		)
Gregory Szorc tests: move mock blackbox extension into own file...	r24705
		def makedate():
		return 0, 0
		def getuser():
		return 'bob'
timeless tests: mock getpid to reduce glob usage...	r28028	def getpid():
		return 5000
Gregory Szorc tests: move mock blackbox extension into own file...	r24705
		# mock the date and user apis so the output is always the same
		def uisetup(ui):
		util.makedate = makedate
		util.getuser = getuser
timeless tests: mock getpid to reduce glob usage...	r28028	util.getpid = getpid