upstream/mercurial-mirror Files · tests/silenttestrunner.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Robert Stanca - - Load All Authors

File last commit:

r28736:403b0a7a default


                r32050:77eaf953

4.1.3 stable

Download file

             silenttestrunner.py
        
                    24 lines
            
             | 734 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / silenttestrunner.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Robert Stanca
    
py3: use print_function in silenttestrunner.py

              r28730
            
      from __future__ import absolute_import, print_function

        Robert Stanca
    
tests: lexicographical imports in silenttestrunner.py

              r28736
            
      import os

      import sys

        Robert Stanca
    
py3: use absolute_import in silenttestrunner.py

              r28729
            
      import unittest

        Idan Kamara
    
tests: add a test runner utility that prints nothing when all tests pass...

              r18665
            
      def main(modulename):

          '''run the tests found in module, printing nothing when all tests pass'''

          module = sys.modules[modulename]

          suite = unittest.defaultTestLoader.loadTestsFromModule(module)

          results = unittest.TestResult()

          suite.run(results)

          if results.errors or results.failures:

              for tc, exc in results.errors:

        Robert Stanca
    
py3: use print_function in silenttestrunner.py

              r28730
            
                  print('ERROR:', tc)

                  print()

        Idan Kamara
    
tests: add a test runner utility that prints nothing when all tests pass...

              r18665
            
                  sys.stdout.write(exc)

              for tc, exc in results.failures:

        Robert Stanca
    
py3: use print_function in silenttestrunner.py

              r28730
            
                  print('FAIL:', tc)

                  print()

        Idan Kamara
    
tests: add a test runner utility that prints nothing when all tests pass...

              r18665
            
                  sys.stdout.write(exc)

              sys.exit(1)

        Augie Fackler
    
silenttestrunner: add environment variable to make tests noisy again...

              r23308
            
      if os.environ.get('SILENT_BE_NOISY'):

          main = unittest.main

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Robert Stanca py3: use print_function in silenttestrunner.py	r28730	from __future__ import absolute_import, print_function
Robert Stanca tests: lexicographical imports in silenttestrunner.py	r28736	import os
		import sys
Robert Stanca py3: use absolute_import in silenttestrunner.py	r28729	import unittest
Idan Kamara tests: add a test runner utility that prints nothing when all tests pass...	r18665
		def main(modulename):
		'''run the tests found in module, printing nothing when all tests pass'''
		module = sys.modules[modulename]
		suite = unittest.defaultTestLoader.loadTestsFromModule(module)
		results = unittest.TestResult()
		suite.run(results)
		if results.errors or results.failures:
		for tc, exc in results.errors:
Robert Stanca py3: use print_function in silenttestrunner.py	r28730	print('ERROR:', tc)
		print()
Idan Kamara tests: add a test runner utility that prints nothing when all tests pass...	r18665	sys.stdout.write(exc)
		for tc, exc in results.failures:
Robert Stanca py3: use print_function in silenttestrunner.py	r28730	print('FAIL:', tc)
		print()
Idan Kamara tests: add a test runner utility that prints nothing when all tests pass...	r18665	sys.stdout.write(exc)
		sys.exit(1)
Augie Fackler silenttestrunner: add environment variable to make tests noisy again...	r23308
		if os.environ.get('SILENT_BE_NOISY'):
		main = unittest.main