upstream/mercurial-mirror Files · tests/svn-safe-append.py

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Pulkit Goyal - - Load All Authors

File last commit:

r29195:bdba6a20 default


                r32050:77eaf953

4.1.3 stable

Download file

             svn-safe-append.py
        
                    28 lines
            
             | 533 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / svn-safe-append.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Peter Arrenbrecht
    
convert: fix test-convert-svn-* problems with mtime not changing...

              r6439
            
      #!/usr/bin/env python

        Pulkit Goyal
    
py3: make tests/svn-safe-append.py use absolute_import

              r29195
            
      from __future__ import absolute_import

        Peter Arrenbrecht
    
convert: fix test-convert-svn-* problems with mtime not changing...

              r6439
            
      __doc__ = """Same as `echo a >> b`, but ensures a changed mtime of b.

      Without this svn will not detect workspace changes."""

        Pulkit Goyal
    
py3: make tests/svn-safe-append.py use absolute_import

              r29195
            
      import os

      import sys

        Peter Arrenbrecht
    
convert: fix test-convert-svn-* problems with mtime not changing...

              r6439
            
      text = sys.argv[1]

      fname = sys.argv[2]

      f = open(fname, "ab")

      try:

          before = os.fstat(f.fileno()).st_mtime

          f.write(text)

          f.write("\n")

      finally:

          f.close()

      inc = 1

      now = os.stat(fname).st_mtime

      while now == before:

          t = now + inc

          inc += 1

          os.utime(fname, (t, t))

          now = os.stat(fname).st_mtime

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Peter Arrenbrecht convert: fix test-convert-svn-* problems with mtime not changing...	r6439	#!/usr/bin/env python

Pulkit Goyal py3: make tests/svn-safe-append.py use absolute_import	r29195	from __future__ import absolute_import

Peter Arrenbrecht convert: fix test-convert-svn-* problems with mtime not changing...	r6439	__doc__ = """Same as `echo a >> b`, but ensures a changed mtime of b.
		Without this svn will not detect workspace changes."""

Pulkit Goyal py3: make tests/svn-safe-append.py use absolute_import	r29195	import os
		import sys
Peter Arrenbrecht convert: fix test-convert-svn-* problems with mtime not changing...	r6439
		text = sys.argv[1]
		fname = sys.argv[2]

		f = open(fname, "ab")
		try:
		before = os.fstat(f.fileno()).st_mtime
		f.write(text)
		f.write("\n")
		finally:
		f.close()
		inc = 1
		now = os.stat(fname).st_mtime
		while now == before:
		t = now + inc
		inc += 1
		os.utime(fname, (t, t))
		now = os.stat(fname).st_mtime