##// END OF EJS Templates
dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...
dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

File last commit:

r25472:4d2b9b30 default
r32050:77eaf953 4.1.3 stable
Show More
test-hgwebdirsym.t
80 lines | 1.6 KiB | text/troff | Tads3Lexer
/ tests / test-hgwebdirsym.t
Matt Mackall
tests: replace exit 80 with #require
r22046 #require serve symlink
Matt Mackall
tests: unify test-hgwebdirsym
r12444
Matt Mackall
tests: replace exit 80 with #require
r22046 Tests whether or not hgwebdir properly handles various symlink topologies.
Mads Kiilerich
tests: add missing no-outer-repo requirements...
r17015
hide outer repo
$ hg init
Matt Mackall
tests: unify test-hgwebdirsym
r12444 $ hg init a
$ echo a > a/a
$ hg --cwd a ci -Ama -d'1 0'
adding a
$ mkdir webdir
$ cd webdir
$ hg init b
$ echo b > b/b
$ hg --cwd b ci -Amb -d'2 0'
adding b
$ hg init c
$ echo c > c/c
$ hg --cwd c ci -Amc -d'3 0'
adding c
$ ln -s ../a al
$ ln -s ../webdir circle
$ root=`pwd`
$ cd ..
$ cat > collections.conf <<EOF
> [collections]
> $root=$root
> EOF
$ hg serve -p $HGPORT -d --pid-file=hg.pid --webdir-conf collections.conf \
> -A access-collections.log -E error-collections.log
$ cat hg.pid >> $DAEMON_PIDS
should succeed
Matt Mackall
tests: drop explicit $TESTDIR from executables...
r25472 $ get-with-headers.py localhost:$HGPORT '?style=raw'
Matt Mackall
tests: unify test-hgwebdirsym
r12444 200 Script output follows
/al/
/b/
/c/
Matt Mackall
tests: drop explicit $TESTDIR from executables...
r25472 $ get-with-headers.py localhost:$HGPORT 'al/file/tip/a?style=raw'
Matt Mackall
tests: unify test-hgwebdirsym
r12444 200 Script output follows
a
Matt Mackall
tests: drop explicit $TESTDIR from executables...
r25472 $ get-with-headers.py localhost:$HGPORT 'b/file/tip/b?style=raw'
Matt Mackall
tests: unify test-hgwebdirsym
r12444 200 Script output follows
b
Matt Mackall
tests: drop explicit $TESTDIR from executables...
r25472 $ get-with-headers.py localhost:$HGPORT 'c/file/tip/c?style=raw'
Matt Mackall
tests: unify test-hgwebdirsym
r12444 200 Script output follows
c
should fail
Matt Mackall
tests: drop explicit $TESTDIR from executables...
r25472 $ get-with-headers.py localhost:$HGPORT 'circle/al/file/tip/a?style=raw'
Matt Mackall
tests: unify test-hgwebdirsym
r12444 404 Not Found
Wagner Bruna
hgwebdir: fix incorrect index generation for invalid paths (issue2023)...
r13066 error: repository circle/al/file/tip/a not found
Matt Mackall
tests: unify test-hgwebdirsym
r12444 [1]
Matt Mackall
tests: drop explicit $TESTDIR from executables...
r25472 $ get-with-headers.py localhost:$HGPORT 'circle/b/file/tip/a?style=raw'
Matt Mackall
tests: unify test-hgwebdirsym
r12444 404 Not Found
Wagner Bruna
hgwebdir: fix incorrect index generation for invalid paths (issue2023)...
r13066 error: repository circle/b/file/tip/a not found
Matt Mackall
tests: unify test-hgwebdirsym
r12444 [1]
Matt Mackall
tests: drop explicit $TESTDIR from executables...
r25472 $ get-with-headers.py localhost:$HGPORT 'circle/c/file/tip/a?style=raw'
Matt Mackall
tests: unify test-hgwebdirsym
r12444 404 Not Found
Wagner Bruna
hgwebdir: fix incorrect index generation for invalid paths (issue2023)...
r13066 error: repository circle/c/file/tip/a not found
Matt Mackall
tests: unify test-hgwebdirsym
r12444 [1]
collections errors
$ cat error-collections.log