upstream/mercurial-mirror Files · tests/test-mq-qimport-fail-cleanup.t

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

timeless - - Load All Authors

File last commit:

r29968:0342bf29 default


                r32050:77eaf953

4.1.3 stable

Download file

             test-mq-qimport-fail-cleanup.t
        
                    42 lines
            
             | 772 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-mq-qimport-fail-cleanup.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: unify test-mq-qimport-fail-cleanup

              r12465
            
      Failed qimport of patches from files should cleanup by recording successfully

      imported patches in series file.

        $ echo "[extensions]" >> $HGRCPATH

        $ echo "mq=" >> $HGRCPATH

        $ hg init repo

        $ cd repo

        $ echo a > a

        $ hg ci -Am'add a'

        adding a

        $ cat >b.patch<<EOF

        > diff --git a/a b/a

        > --- a/a

        > +++ b/a

        > @@ -1,1 +1,2 @@

        >  a

        > +b

        > EOF

      empty series

        $ hg qseries

      qimport valid patch followed by invalid patch

        $ hg qimport b.patch fakepatch

        adding b.patch to series file

        abort: unable to read file fakepatch

        [255]

      valid patches before fail added to series

        $ hg qseries

        b.patch

        Pierre-Yves David
    
phases: prevent mq to qimport immutable change.

              r15704
            
        $ hg pull -q -r 0 . # update phase

        $ hg qimport -r 0

        abort: revision 0 is not mutable

        timeless
    
mq: use single quotes in use warning

              r29968
            
        (see 'hg help phases' for details)

        Pierre-Yves David
    
phases: prevent mq to qimport immutable change.

              r15704
            
        [255]

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: unify test-mq-qimport-fail-cleanup	r12465	Failed qimport of patches from files should cleanup by recording successfully
		imported patches in series file.

		$ echo "[extensions]" >> $HGRCPATH
		$ echo "mq=" >> $HGRCPATH
		$ hg init repo
		$ cd repo
		$ echo a > a
		$ hg ci -Am'add a'
		adding a
		$ cat >b.patch<<EOF
		> diff --git a/a b/a
		> --- a/a
		> +++ b/a
		> @@ -1,1 +1,2 @@
		> a
		> +b
		> EOF

		empty series

		$ hg qseries

		qimport valid patch followed by invalid patch

		$ hg qimport b.patch fakepatch
		adding b.patch to series file
		abort: unable to read file fakepatch
		[255]

		valid patches before fail added to series

		$ hg qseries
		b.patch
Pierre-Yves David phases: prevent mq to qimport immutable change.	r15704
		$ hg pull -q -r 0 . # update phase
		$ hg qimport -r 0
		abort: revision 0 is not mutable
timeless mq: use single quotes in use warning	r29968	(see 'hg help phases' for details)
Pierre-Yves David phases: prevent mq to qimport immutable change.	r15704	[255]
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913
		$ cd ..