upstream/mercurial-mirror Files · tests/test-serve.t

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Matt Harbison - - Load All Authors

File last commit:

r31771:5e92ba77 default


                r32050:77eaf953

4.1.3 stable

Download file

             test-serve.t
        
                    81 lines
            
             | 1.8 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-serve.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: replace exit 80 with #require

              r22046
            
      #require serve

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        $ hgserve()

        > {

        >    hg serve -a localhost -d --pid-file=hg.pid -E errors.log -v $@ \

        >        | sed -e "s/:$HGPORT1\\([^0-9]\\)/:HGPORT1\1/g" \

        >              -e "s/:$HGPORT2\\([^0-9]\\)/:HGPORT2\1/g" \

        >              -e 's/http:\/\/[^/]*\//http:\/\/localhost\//'

        >    cat hg.pid >> "$DAEMON_PIDS"

        >    echo % errors

        >    cat errors.log

        Matt Mackall
    
tests: drop explicit $TESTDIR from executables...

              r25472
            
        >    killdaemons.py hg.pid

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        > }

        $ hg init test

        $ cd test

        $ echo '[web]' > .hg/hgrc

        $ echo 'accesslog = access.log' >> .hg/hgrc

        $ echo "port = $HGPORT1" >> .hg/hgrc

      Without -v

        $ hg serve -a localhost -p $HGPORT -d --pid-file=hg.pid -E errors.log

        $ cat hg.pid >> "$DAEMON_PIDS"

        $ if [ -f access.log ]; then

        Mads Kiilerich
    
tests: fix incorrect markup of continued lines of sh commands

              r16487
            
        >     echo 'access log created - .hg/hgrc respected'

        > fi

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        access log created - .hg/hgrc respected

      errors

        $ cat errors.log

      With -v

        $ hgserve

        Augie Fackler
    
test-serve: add missing globs...

              r29563
            
        listening at http://localhost/ (bound to 127.0.0.1:HGPORT1) (glob)

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        % errors

      With -v and -p HGPORT2

        $ hgserve -p "$HGPORT2"

        Augie Fackler
    
test-serve: add missing globs...

              r29563
            
        listening at http://localhost/ (bound to 127.0.0.1:HGPORT2) (glob)

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        % errors

      With -v and -p daytime (should fail because low port)

        Matt Mackall
    
tests: skip tests that require not having root (issue4089)...

              r20008
            
      #if no-root

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        $ KILLQUIETLY=Y

        $ hgserve -p daytime

        abort: cannot start server at 'localhost:13': Permission denied

        abort: child process failed to start

        % errors

        $ KILLQUIETLY=N

        Matt Mackall
    
tests: skip tests that require not having root (issue4089)...

              r20008
            
      #endif

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
      With --prefix foo

        $ hgserve --prefix foo

        Augie Fackler
    
test-serve: add missing globs...

              r29563
            
        listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        % errors

      With --prefix /foo

        $ hgserve --prefix /foo

        Augie Fackler
    
test-serve: add missing globs...

              r29563
            
        listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        % errors

      With --prefix foo/

        $ hgserve --prefix foo/

        Augie Fackler
    
test-serve: add missing globs...

              r29563
            
        listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        % errors

      With --prefix /foo/

        $ hgserve --prefix /foo/

        Augie Fackler
    
test-serve: add missing globs...

              r29563
            
        listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)

        Patrick Mezard
    
tests: convert test-serve to new format

              r13540
            
        % errors

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: replace exit 80 with #require	r22046	#require serve
Patrick Mezard tests: convert test-serve to new format	r13540
		$ hgserve()
		> {
		> hg serve -a localhost -d --pid-file=hg.pid -E errors.log -v $@ \
		> \| sed -e "s/:$HGPORT1\\([^0-9]\\)/:HGPORT1\1/g" \
		> -e "s/:$HGPORT2\\([^0-9]\\)/:HGPORT2\1/g" \
		> -e 's/http:\/\/[^/]*\//http:\/\/localhost\//'
		> cat hg.pid >> "$DAEMON_PIDS"
		> echo % errors
		> cat errors.log
Matt Mackall tests: drop explicit $TESTDIR from executables...	r25472	> killdaemons.py hg.pid
Patrick Mezard tests: convert test-serve to new format	r13540	> }

		$ hg init test
		$ cd test
		$ echo '[web]' > .hg/hgrc
		$ echo 'accesslog = access.log' >> .hg/hgrc
		$ echo "port = $HGPORT1" >> .hg/hgrc

		Without -v

		$ hg serve -a localhost -p $HGPORT -d --pid-file=hg.pid -E errors.log
		$ cat hg.pid >> "$DAEMON_PIDS"
		$ if [ -f access.log ]; then
Mads Kiilerich tests: fix incorrect markup of continued lines of sh commands	r16487	> echo 'access log created - .hg/hgrc respected'
		> fi
Patrick Mezard tests: convert test-serve to new format	r13540	access log created - .hg/hgrc respected

		errors

		$ cat errors.log

		With -v

		$ hgserve
Augie Fackler test-serve: add missing globs...	r29563	listening at http://localhost/ (bound to 127.0.0.1:HGPORT1) (glob)
Patrick Mezard tests: convert test-serve to new format	r13540	% errors

		With -v and -p HGPORT2

		$ hgserve -p "$HGPORT2"
Augie Fackler test-serve: add missing globs...	r29563	listening at http://localhost/ (bound to 127.0.0.1:HGPORT2) (glob)
Patrick Mezard tests: convert test-serve to new format	r13540	% errors

		With -v and -p daytime (should fail because low port)

Matt Mackall tests: skip tests that require not having root (issue4089)...	r20008	#if no-root
Patrick Mezard tests: convert test-serve to new format	r13540	$ KILLQUIETLY=Y
		$ hgserve -p daytime
		abort: cannot start server at 'localhost:13': Permission denied
		abort: child process failed to start
		% errors
		$ KILLQUIETLY=N
Matt Mackall tests: skip tests that require not having root (issue4089)...	r20008	#endif
Patrick Mezard tests: convert test-serve to new format	r13540
		With --prefix foo

		$ hgserve --prefix foo
Augie Fackler test-serve: add missing globs...	r29563	listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)
Patrick Mezard tests: convert test-serve to new format	r13540	% errors

		With --prefix /foo

		$ hgserve --prefix /foo
Augie Fackler test-serve: add missing globs...	r29563	listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)
Patrick Mezard tests: convert test-serve to new format	r13540	% errors

		With --prefix foo/

		$ hgserve --prefix foo/
Augie Fackler test-serve: add missing globs...	r29563	listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)
Patrick Mezard tests: convert test-serve to new format	r13540	% errors

		With --prefix /foo/

		$ hgserve --prefix /foo/
Augie Fackler test-serve: add missing globs...	r29563	listening at http://localhost/foo/ (bound to 127.0.0.1:HGPORT1) (glob)
Patrick Mezard tests: convert test-serve to new format	r13540	% errors
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913
		$ cd ..