upstream/mercurial-mirror Files · tests/test-symlink-placeholder.t

dispatch: protect against malicious 'hg serve --stdio' invocations (sec)...

dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

Matt Mackall - - Load All Authors

File last commit:

r22046:7a9cbb31 default


                r32050:77eaf953

4.1.3 stable

Download file

             test-symlink-placeholder.t
        
                    79 lines
            
             | 1.9 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-symlink-placeholder.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: replace exit 80 with #require

              r22046
            
      #require symlink

        Mads Kiilerich
    
tests: use 'hghave symlink' for tests using symlinks

              r15441
            
        Matt Mackall
    
windows: sanity-check symlink placeholders...

              r15348
            
      Create extension that can disable symlink support:

        $ cat > nolink.py <<EOF

        > from mercurial import extensions, util

        > def setflags(orig, f, l, x):

        >     pass

        > def checklink(orig, path):

        >     return False

        > def extsetup(ui):

        >     extensions.wrapfunction(util, 'setflags', setflags)

        >     extensions.wrapfunction(util, 'checklink', checklink)

        > EOF

        $ hg init unix-repo

        $ cd unix-repo

        $ echo foo > a

        $ ln -s a b

        $ hg ci -Am0

        adding a

        adding b

        $ cd ..

      Simulate a checkout shared on NFS/Samba:

        $ hg clone -q unix-repo shared

        $ cd shared

        $ rm b

        $ echo foo > b

        $ hg --config extensions.n=$TESTTMP/nolink.py status --debug

        ignoring suspect symlink placeholder "b"

      Make a clone using placeholders:

        $ hg --config extensions.n=$TESTTMP/nolink.py clone . ../win-repo

        updating to branch default

        2 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd ../win-repo

        $ cat b

        a (no-eol)

        $ hg --config extensions.n=$TESTTMP/nolink.py st --debug

        Siddharth Agarwal
    
localrepo.status: ignore empty symlink placeholders...

              r19650
            
      Empty placeholder:

        $ rm b

        $ touch b

        $ hg --config extensions.n=$TESTTMP/nolink.py st --debug

        ignoring suspect symlink placeholder "b"

        Matt Mackall
    
windows: sanity-check symlink placeholders...

              r15348
            
      Write binary data to the placeholder:

        >>> open('b', 'w').write('this is a binary\0')

        $ hg --config extensions.n=$TESTTMP/nolink.py st --debug

        ignoring suspect symlink placeholder "b"

      Write a long string to the placeholder:

        >>> open('b', 'w').write('this' * 1000)

        $ hg --config extensions.n=$TESTTMP/nolink.py st --debug

        ignoring suspect symlink placeholder "b"

      Commit shouldn't succeed:

        $ hg --config extensions.n=$TESTTMP/nolink.py ci -m1

        nothing changed

        [1]

      Write a valid string to the placeholder:

        >>> open('b', 'w').write('this')

        $ hg --config extensions.n=$TESTTMP/nolink.py st --debug

        M b

        $ hg --config extensions.n=$TESTTMP/nolink.py ci -m1

        $ hg manifest tip --verbose

        644   a

        644 @ b

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: replace exit 80 with #require	r22046	#require symlink
Mads Kiilerich tests: use 'hghave symlink' for tests using symlinks	r15441
Matt Mackall windows: sanity-check symlink placeholders...	r15348	Create extension that can disable symlink support:

		$ cat > nolink.py <<EOF
		> from mercurial import extensions, util
		> def setflags(orig, f, l, x):
		> pass
		> def checklink(orig, path):
		> return False
		> def extsetup(ui):
		> extensions.wrapfunction(util, 'setflags', setflags)
		> extensions.wrapfunction(util, 'checklink', checklink)
		> EOF

		$ hg init unix-repo
		$ cd unix-repo
		$ echo foo > a
		$ ln -s a b
		$ hg ci -Am0
		adding a
		adding b
		$ cd ..

		Simulate a checkout shared on NFS/Samba:

		$ hg clone -q unix-repo shared
		$ cd shared
		$ rm b
		$ echo foo > b
		$ hg --config extensions.n=$TESTTMP/nolink.py status --debug
		ignoring suspect symlink placeholder "b"

		Make a clone using placeholders:

		$ hg --config extensions.n=$TESTTMP/nolink.py clone . ../win-repo
		updating to branch default
		2 files updated, 0 files merged, 0 files removed, 0 files unresolved
		$ cd ../win-repo
		$ cat b
		a (no-eol)
		$ hg --config extensions.n=$TESTTMP/nolink.py st --debug

Siddharth Agarwal localrepo.status: ignore empty symlink placeholders...	r19650	Empty placeholder:

		$ rm b
		$ touch b
		$ hg --config extensions.n=$TESTTMP/nolink.py st --debug
		ignoring suspect symlink placeholder "b"

Matt Mackall windows: sanity-check symlink placeholders...	r15348	Write binary data to the placeholder:

		>>> open('b', 'w').write('this is a binary\0')
		$ hg --config extensions.n=$TESTTMP/nolink.py st --debug
		ignoring suspect symlink placeholder "b"

		Write a long string to the placeholder:

		>>> open('b', 'w').write('this' * 1000)
		$ hg --config extensions.n=$TESTTMP/nolink.py st --debug
		ignoring suspect symlink placeholder "b"

		Commit shouldn't succeed:

		$ hg --config extensions.n=$TESTTMP/nolink.py ci -m1
		nothing changed
		[1]

		Write a valid string to the placeholder:

		>>> open('b', 'w').write('this')
		$ hg --config extensions.n=$TESTTMP/nolink.py st --debug
		M b
		$ hg --config extensions.n=$TESTTMP/nolink.py ci -m1
		$ hg manifest tip --verbose
		644 a
		644 @ b
Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913
		$ cd ..