upstream/mercurial-mirror Files · hgext/narrow/TODO.rst

localrepo: move repo creation logic out of localrepository.__init__ (API)...

localrepo: move repo creation logic out of localrepository.__init__ (API) It has long bothered me that local repository creation is handled as part of localrepository.__init__. Upcoming changes I want to make around how repositories are initialized and instantiated will make the continued existence of repository creation code in localrepository.__init__ even more awkward. localrepository instances are almost never constructed directly: instead, callers are supposed to go through hg.repository() to obtain a handle on a repository. And hg.repository() calls localrepo.instance() to return a new repo instance. This commit teaches localrepo.instance() to handle the create=True logic. Most of the code for repo construction has been moved to a standalone function. This allows extensions to monkeypatch the function to further customize freshly-created repositories. A few calls to localrepo.localrepository.__init__ that were passing create=True were converted to call localrepo.instance(). .. api:: local repo creation moved out of constructor ``localrepo.localrepository.__init__`` no longer accepts a ``create`` argument to create a new repository. New repository creation is now performed as part of ``localrepo.instance()`` and the bulk of the work is performed by ``localrepo.createrepository()``. Differential Revision: https://phab.mercurial-scm.org/D4534

Gregory Szorc - - Load All Authors

File last commit:

r39581:10a8472f default


                r39584:7ce9dea3

default

Download file

             TODO.rst
        
                    30 lines
            
             | 1.3 KiB
            
                | text/x-rst
            
             |
                RstLexer
            
             / hgext / narrow / TODO.rst
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Augie Fackler
    
narrow: add a TODO document...

              r36121
            
      Integration with the share extension needs improvement. Right now

      we've seen some odd bugs, and the way we modify the contents of the

      .hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().

      Resolve commentary on narrowrepo.wraprepo.narrowrepository.status

      about the filtering of status being done at an awkward layer. This

      came up the import to hgext, but nobody's got concrete improvement

      ideas as of then.

      Fold most (or preferably all) of narrowrevlog.py into core.

      Address commentary in narrowrevlog.excludedmanifestrevlog.add -

      specifically we should improve the collaboration with core so that

      add() never gets called on an excluded directory and we can improve

      the stand-in to raise a ProgrammingError.

      Figure out how to correctly produce narrowmanifestrevlog and

      narrowfilelog instances instead of monkeypatching regular revlogs at

      runtime to our subclass. Even better, merge the narrowing logic

      directly into core.

      Reason more completely about rename-filtering logic in

      narrowfilelog. There could be some surprises lurking there.

      Formally document the narrowspec format. Unify with sparse, if at all

      possible. For bonus points, unify with the server-specified narrowspec

      format.

      narrowrepo.setnarrowpats() or narrowspec.save() need to make sure

      they're holding the wlock.

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Augie Fackler narrow: add a TODO document...	r36121	Integration with the share extension needs improvement. Right now
		we've seen some odd bugs, and the way we modify the contents of the
		.hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().

		Resolve commentary on narrowrepo.wraprepo.narrowrepository.status
		about the filtering of status being done at an awkward layer. This
		came up the import to hgext, but nobody's got concrete improvement
		ideas as of then.

		Fold most (or preferably all) of narrowrevlog.py into core.

		Address commentary in narrowrevlog.excludedmanifestrevlog.add -
		specifically we should improve the collaboration with core so that
		add() never gets called on an excluded directory and we can improve
		the stand-in to raise a ProgrammingError.

		Figure out how to correctly produce narrowmanifestrevlog and
		narrowfilelog instances instead of monkeypatching regular revlogs at
		runtime to our subclass. Even better, merge the narrowing logic
		directly into core.

		Reason more completely about rename-filtering logic in
		narrowfilelog. There could be some surprises lurking there.

		Formally document the narrowspec format. Unify with sparse, if at all
		possible. For bonus points, unify with the server-specified narrowspec
		format.

		narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
		they're holding the wlock.