upstream/mercurial-mirror Files · rust/rhg/src/commands/root.rs

rust-index: using the `hg::index::Index` in ancestors iterator and lazy set...

rust-index: using the `hg::index::Index` in ancestors iterator and lazy set Since there is no Rust implementation for REVLOGV2/CHANGELOGv2, we declare them to be incompatible with Rust, hence indexes in these formats will use the implementations from Python `mercurial.ancestor`. If this is an unacceptable performance hit for current users of these formats, we can later on add Rust implementations based on the C index for them or implement these formats for the Rust indexes. Among the challenges that we had to meet, we wanted to avoid taking the GIL each time the inner (vcsgraph) iterator has to call the parents function. This would probably still be acceptable in terms of performance with `AncestorsIterator`, but not with `LazyAncestors` nor for the upcoming change in `MissingAncestors`. Hence we enclose the reference to the index in a `PySharedRef`, leading to more rigourous checking of mutations, which does pass now that there no logically immutable methods of `hg::index::Index` that take a mutable reference as input.

Raphaël Gomès - - Load All Authors

File last commit:

r52013:532e74ad default


                r52132:7eea2e41

default

Download file

             root.rs
        
                    28 lines
            
             | 861 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / rhg / src / commands / root.rs
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Antoine Cezar
    
rhg: simplify `FindRootError` handling...

              r45922
            
      use crate::error::CommandError;

        Raphaël Gomès
    
rhg: use `format_bytes!` for error messages...

              r46598
            
      use format_bytes::format_bytes;

        Simon Sapin
    
rhg: Don’t make repository path absolute too early...

              r47474
            
      use hg::errors::{IoErrorContext, IoResultExt};

        Antoine Cezar
    
rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`...

              r45592
            
      use hg::utils::files::get_bytes_from_path;

      pub const HELP_TEXT: &str = "

      Print the root directory of the current repository.

      Returns 0 on success.

      ";

        Raphaël Gomès
    
rhg: upgrade `clap` dependency...

              r50534
            
      pub fn args() -> clap::Command {

          clap::command!("root").about(HELP_TEXT)

        Simon Sapin
    
rhg: Move subcommand CLI arguments definitions to respective modules...

              r47251
            
      }

        Simon Sapin
    
rhg: Group values passed to every sub-command into a struct...

              r47334
            
      pub fn run(invocation: &crate::CliInvocation) -> Result<(), CommandError> {

        Simon Sapin
    
rhg: Move `Repo` object creation into `main()`...

              r47335
            
          let repo = invocation.repo?;

        Simon Sapin
    
rhg: Don’t make repository path absolute too early...

              r47474
            
          let working_directory = repo.working_directory_path();

          let working_directory = std::fs::canonicalize(working_directory)

              .with_context(|| {

                  IoErrorContext::CanonicalizingPath(working_directory.to_owned())

              })?;

        Raphaël Gomès
    
rust: run a clippy pass with the latest stable version...

              r52013
            
          let bytes = get_bytes_from_path(working_directory);

        Simon Sapin
    
rhg: Group values passed to every sub-command into a struct...

              r47334
            
          invocation

              .ui

              .write_stdout(&format_bytes!(b"{}\n", bytes.as_slice()))?;

        Simon Sapin
    
rhg: replace command structs with functions...

              r47250
            
          Ok(())

        Antoine Cezar
    
rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`...

              r45592
            
      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Antoine Cezar rhg: simplify `FindRootError` handling...	r45922	use crate::error::CommandError;
Raphaël Gomès rhg: use `format_bytes!` for error messages...	r46598	use format_bytes::format_bytes;
Simon Sapin rhg: Don’t make repository path absolute too early...	r47474	use hg::errors::{IoErrorContext, IoResultExt};
Antoine Cezar rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`...	r45592	use hg::utils::files::get_bytes_from_path;

		pub const HELP_TEXT: &str = "
		Print the root directory of the current repository.

		Returns 0 on success.
		";

Raphaël Gomès rhg: upgrade `clap` dependency...	r50534	pub fn args() -> clap::Command {
		clap::command!("root").about(HELP_TEXT)
Simon Sapin rhg: Move subcommand CLI arguments definitions to respective modules...	r47251	}

Simon Sapin rhg: Group values passed to every sub-command into a struct...	r47334	pub fn run(invocation: &crate::CliInvocation) -> Result<(), CommandError> {
Simon Sapin rhg: Move `Repo` object creation into `main()`...	r47335	let repo = invocation.repo?;
Simon Sapin rhg: Don’t make repository path absolute too early...	r47474	let working_directory = repo.working_directory_path();
		let working_directory = std::fs::canonicalize(working_directory)
		.with_context(\|\| {
		IoErrorContext::CanonicalizingPath(working_directory.to_owned())
		})?;
Raphaël Gomès rust: run a clippy pass with the latest stable version...	r52013	let bytes = get_bytes_from_path(working_directory);
Simon Sapin rhg: Group values passed to every sub-command into a struct...	r47334	invocation
		.ui
		.write_stdout(&format_bytes!(b"{}\n", bytes.as_slice()))?;
Simon Sapin rhg: replace command structs with functions...	r47250	Ok(())
Antoine Cezar rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`...	r45592	}