upstream/mercurial-mirror Files · tests/test-diffdir.t

localrepo: make journal.dirstate contain in-memory changes before transaction...

localrepo: make journal.dirstate contain in-memory changes before transaction Before this patch, in-memory dirstate changes aren't written out at opening transaction, even though 'journal.dirstate' is created directly from '.hg/dirstate'. Therefore, subsequent 'hg rollback' uses incomplete 'undo.dirstate' to restore dirstate, if dirstate is changed and isn't written out before opening transaction. In cases below, the condition "dirstate is changed and isn't written out before opening transaction" isn't satisfied and this problem doesn't appear: - "wlock scope" and "transaction scope" are almost equivalent e.g. 'commit --amend', 'import' and so on - dirstate changes are written out before opening transaction e.g. 'rebase' (via 'dirstateguard') and 'commit -A' (by separated wlock scopes) On the other hand, 'backout' may satisfy the condition above. To make 'journal.dirstate' contain in-memory changes before opening transaction, this patch explicitly invokes 'dirstate.write()' in 'localrepository.transaction()'. 'dirstate.write()' is placed before not "writing journal files out" but "invoking pretxnopen hooks" for visibility of dirstate changes to external hook processes. BTW, in the test script, 'touch -t 200001010000' and 'hg status' are invoked to make file 'c' surely clean in dirstate, because "clean but unsure" files indirectly cause 'dirstate.write()' at 'repo.status()' in 'repo.commit()' (see for detail) and prevents from certainly reproducing the issue.

Matt Mackall - - Load All Authors

File last commit:

r12617:2063d36b default


                r25878:800e090e

stable

Download file

             test-diffdir.t
        
                    40 lines
            
             | 597 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-diffdir.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Pradeepkumar Gayam
    
tests: unify test-diffdir

              r11921
            
        $ hg init

        $ touch a

        $ hg add a

        Martin Geisler
    
tests: remove unneeded -d flags...

              r12156
            
        $ hg ci -m "a"

        Pradeepkumar Gayam
    
tests: unify test-diffdir

              r11921
            
        $ echo 123 > b

        $ hg add b

        $ hg diff --nodates

        Martin Geisler
    
tests: remove unneeded -d flags...

              r12156
            
        diff -r 3903775176ed b

        Pradeepkumar Gayam
    
tests: unify test-diffdir

              r11921
            
        --- /dev/null

        +++ b/b

        @@ -0,0 +1,1 @@

        +123

        $ hg diff --nodates -r tip

        Martin Geisler
    
tests: remove unneeded -d flags...

              r12156
            
        diff -r 3903775176ed b

        Pradeepkumar Gayam
    
tests: unify test-diffdir

              r11921
            
        --- /dev/null

        +++ b/b

        @@ -0,0 +1,1 @@

        +123

        $ echo foo > a

        $ hg diff --nodates

        Martin Geisler
    
tests: remove unneeded -d flags...

              r12156
            
        diff -r 3903775176ed a

        Pradeepkumar Gayam
    
tests: unify test-diffdir

              r11921
            
        --- a/a

        +++ b/a

        @@ -0,0 +1,1 @@

        +foo

        Martin Geisler
    
tests: remove unneeded -d flags...

              r12156
            
        diff -r 3903775176ed b

        Pradeepkumar Gayam
    
tests: unify test-diffdir

              r11921
            
        --- /dev/null

        +++ b/b

        @@ -0,0 +1,1 @@

        +123

        $ hg diff -r ""

        Matt Mackall
    
revsets: make revpair revsets-aware...

              r12617
            
        hg: parse error: empty query

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

        Pradeepkumar Gayam
    
tests: unify test-diffdir

              r11921
            
        $ hg diff -r tip -r ""

        Matt Mackall
    
revsets: make revpair revsets-aware...

              r12617
            
        hg: parse error: empty query

        Matt Mackall
    
tests: add exit codes to unified tests

              r12316
            
        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Pradeepkumar Gayam tests: unify test-diffdir	r11921	$ hg init
		$ touch a
		$ hg add a
Martin Geisler tests: remove unneeded -d flags...	r12156	$ hg ci -m "a"
Pradeepkumar Gayam tests: unify test-diffdir	r11921
		$ echo 123 > b
		$ hg add b
		$ hg diff --nodates
Martin Geisler tests: remove unneeded -d flags...	r12156	diff -r 3903775176ed b
Pradeepkumar Gayam tests: unify test-diffdir	r11921	--- /dev/null
		+++ b/b
		@@ -0,0 +1,1 @@
		+123

		$ hg diff --nodates -r tip
Martin Geisler tests: remove unneeded -d flags...	r12156	diff -r 3903775176ed b
Pradeepkumar Gayam tests: unify test-diffdir	r11921	--- /dev/null
		+++ b/b
		@@ -0,0 +1,1 @@
		+123

		$ echo foo > a
		$ hg diff --nodates
Martin Geisler tests: remove unneeded -d flags...	r12156	diff -r 3903775176ed a
Pradeepkumar Gayam tests: unify test-diffdir	r11921	--- a/a
		+++ b/a
		@@ -0,0 +1,1 @@
		+foo
Martin Geisler tests: remove unneeded -d flags...	r12156	diff -r 3903775176ed b
Pradeepkumar Gayam tests: unify test-diffdir	r11921	--- /dev/null
		+++ b/b
		@@ -0,0 +1,1 @@
		+123

		$ hg diff -r ""
Matt Mackall revsets: make revpair revsets-aware...	r12617	hg: parse error: empty query
Matt Mackall tests: add exit codes to unified tests	r12316	[255]
Pradeepkumar Gayam tests: unify test-diffdir	r11921	$ hg diff -r tip -r ""
Matt Mackall revsets: make revpair revsets-aware...	r12617	hg: parse error: empty query
Matt Mackall tests: add exit codes to unified tests	r12316	[255]