upstream/mercurial-mirror Files · tests/test-pull-permission.t

localrepo: make journal.dirstate contain in-memory changes before transaction...

localrepo: make journal.dirstate contain in-memory changes before transaction Before this patch, in-memory dirstate changes aren't written out at opening transaction, even though 'journal.dirstate' is created directly from '.hg/dirstate'. Therefore, subsequent 'hg rollback' uses incomplete 'undo.dirstate' to restore dirstate, if dirstate is changed and isn't written out before opening transaction. In cases below, the condition "dirstate is changed and isn't written out before opening transaction" isn't satisfied and this problem doesn't appear: - "wlock scope" and "transaction scope" are almost equivalent e.g. 'commit --amend', 'import' and so on - dirstate changes are written out before opening transaction e.g. 'rebase' (via 'dirstateguard') and 'commit -A' (by separated wlock scopes) On the other hand, 'backout' may satisfy the condition above. To make 'journal.dirstate' contain in-memory changes before opening transaction, this patch explicitly invokes 'dirstate.write()' in 'localrepository.transaction()'. 'dirstate.write()' is placed before not "writing journal files out" but "invoking pretxnopen hooks" for visibility of dirstate changes to external hook processes. BTW, in the test script, 'touch -t 200001010000' and 'hg status' are invoked to make file 'c' surely clean in dirstate, because "clean but unsure" files indirectly cause 'dirstate.write()' at 'repo.status()' in 'repo.commit()' (see for detail) and prevents from certainly reproducing the issue.

Matt Mackall - - Load All Authors

File last commit:

r22047:8fb6844a default


                r25878:800e090e

stable

Download file

             test-pull-permission.t
        
                    32 lines
            
             | 625 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-pull-permission.t
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Matt Mackall
    
tests: change some #ifs to #requires

              r22047
            
      #require unix-permissions no-root

        Mads Kiilerich
    
tests: add missing 'hghave unix-permissions'

              r15516
            
        Martin Geisler
    
tests: remove redundant mkdir...

              r13956
            
        $ hg init a

        Adrian Buehlmann
    
combine tests

              r12279
            
        $ cd a

        $ echo foo > b

        $ hg add b

        $ hg ci -m "b"

        $ chmod -w .hg/store

        $ cd ..

        $ hg clone a b

        requesting all changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ chmod +w a/.hg/store # let test clean up

        $ cd b

        $ hg verify

        checking changesets

        checking manifests

        crosschecking files in changesets and manifests

        checking files

        1 files, 1 changesets, 1 total revisions

        Mads Kiilerich
    
tests: add missing trailing 'cd ..'...

              r16913
            
        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Matt Mackall tests: change some #ifs to #requires	r22047	#require unix-permissions no-root
Mads Kiilerich tests: add missing 'hghave unix-permissions'	r15516
Martin Geisler tests: remove redundant mkdir...	r13956	$ hg init a
Adrian Buehlmann combine tests	r12279	$ cd a
		$ echo foo > b
		$ hg add b
		$ hg ci -m "b"

		$ chmod -w .hg/store

		$ cd ..

		$ hg clone a b
		requesting all changes
		adding changesets
		adding manifests
		adding file changes
		added 1 changesets with 1 changes to 1 files
		updating to branch default
		1 files updated, 0 files merged, 0 files removed, 0 files unresolved

		$ chmod +w a/.hg/store # let test clean up

		$ cd b
		$ hg verify
		checking changesets
		checking manifests
		crosschecking files in changesets and manifests
		checking files
		1 files, 1 changesets, 1 total revisions

Mads Kiilerich tests: add missing trailing 'cd ..'...	r16913	$ cd ..