##// END OF EJS Templates
bisect: avoid adding irrelevant revisions to bisect state...
bisect: avoid adding irrelevant revisions to bisect state When adding new revisions to the bisect state, it only makes sense to add information about revisions that are under consideration (i.e., those that are topologically between the known good and bad revisions). However, if the user passes in a revset (e.g., '!merge()' to exclude merge commits), hg will resolve the revset first and add all matching revisions to the bisect state (which in this case would likely be the majority of revisions in the repo). To avoid this, revisions should only be added to the bisect state if they are between the good and bad revisions (and therefore relevant to the bisection). -- Here are the results of some performance tests using the `mozilla-central` repo (since it is one of the largest freely-available hg repositories in the wild). These tests compare the performance of a locally-built `hg` before and after application of this series. Note that `--noupdate` is passed to avoid including update time (which should not vary across cases). Setup (run between each test): $ hg bisect --reset $ hg bisect --noupdate --bad 56c3ad4bde5c70714b784ccf15d099e0df0f5bde $ hg bisect --noupdate --good 57426696adaf08298af3027fa77486fee0633b13 Test using a revset that returns a very large number of revisions: $ time hg bisect --noupdate --skip '!merge()' > /dev/null Before: real 0m9.398s user 0m9.233s sys 0m0.120s After: real 0m1.513s user 0m1.425s sys 0m0.052s Test using a revset that is expensive to compute: $ time hg bisect --noupdate --skip 'desc("Bug")' > /dev/null Before: real 0m49.853s user 0m49.580s sys 0m0.243s After: real 0m4.120s user 0m4.036s sys 0m0.048s

File last commit:

r49801:642e31cb default
r50337:81623652 default
Show More
test-simplekeyvaluefile.py
98 lines | 3.0 KiB | text/x-python | PythonLexer
/ tests / test-simplekeyvaluefile.py
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553 import unittest
import silenttestrunner
from mercurial import (
error,
scmutil,
)
Augie Fackler
formatting: blacken the codebase...
r43346
Gregory Szorc
py3: use class X: instead of class X(object):...
r49801 class mockfile:
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553 def __init__(self, name, fs):
self.name = name
self.fs = fs
def __enter__(self):
return self
def __exit__(self, *args, **kwargs):
pass
def write(self, text):
self.fs.contents[self.name] = text
def read(self):
return self.fs.contents[self.name]
Augie Fackler
formatting: blacken the codebase...
r43346
Gregory Szorc
py3: use class X: instead of class X(object):...
r49801 class mockvfs:
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553 def __init__(self):
self.contents = {}
def read(self, path):
return mockfile(path, self).read()
def readlines(self, path):
Kostia Balytskyi
scmutil: add simplekeyvaluefile reading test...
r32269 # lines need to contain the trailing '\n' to mock the real readlines
return [l for l in mockfile(path, self).read().splitlines(True)]
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553
def __call__(self, path, mode, atomictemp):
return mockfile(path, self)
Augie Fackler
formatting: blacken the codebase...
r43346
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553 class testsimplekeyvaluefile(unittest.TestCase):
def setUp(self):
self.vfs = mockvfs()
Kostia Balytskyi
scmutil: add simplekeyvaluefile reading test...
r32269 def testbasicwritingiandreading(self):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 dw = {b'key1': b'value1', b'Key2': b'value2'}
scmutil.simplekeyvaluefile(self.vfs, b'kvfile').write(dw)
Augie Fackler
formatting: blacken the codebase...
r43346 self.assertEqual(
sorted(self.vfs.read(b'kvfile').split(b'\n')),
[b'', b'Key2=value2', b'key1=value1'],
)
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 dr = scmutil.simplekeyvaluefile(self.vfs, b'kvfile').read()
Kostia Balytskyi
scmutil: add simplekeyvaluefile reading test...
r32269 self.assertEqual(dr, dw)
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553
Augie Fackler
cleanup: polyfill assertRaisesRegex so we can avoid assertRaisesRegexp...
r37733 if not getattr(unittest.TestCase, 'assertRaisesRegex', False):
# Python 3.7 deprecates the regex*p* version, but 2.7 lacks
# the regex version.
Augie Fackler
formatting: blacken the codebase...
r43346 assertRaisesRegex = ( # camelcase-required
unittest.TestCase.assertRaisesRegexp
)
Augie Fackler
cleanup: polyfill assertRaisesRegex so we can avoid assertRaisesRegexp...
r37733
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553 def testinvalidkeys(self):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 d = {b'0key1': b'value1', b'Key2': b'value2'}
Augie Fackler
formatting: blacken the codebase...
r43346 with self.assertRaisesRegex(
error.ProgrammingError, 'keys must start with a letter.*'
):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 scmutil.simplekeyvaluefile(self.vfs, b'kvfile').write(d)
Gregory Szorc
tests: use context manager form of assertRaises...
r32279
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 d = {b'key1@': b'value1', b'Key2': b'value2'}
Augie Fackler
cleanup: polyfill assertRaisesRegex so we can avoid assertRaisesRegexp...
r37733 with self.assertRaisesRegex(error.ProgrammingError, 'invalid key.*'):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 scmutil.simplekeyvaluefile(self.vfs, b'kvfile').write(d)
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553
def testinvalidvalues(self):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 d = {b'key1': b'value1', b'Key2': b'value2\n'}
Augie Fackler
formatting: blacken the codebase...
r43346 with self.assertRaisesRegex(error.ProgrammingError, 'invalid val.*'):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 scmutil.simplekeyvaluefile(self.vfs, b'kvfile').write(d)
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553
def testcorruptedfile(self):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 self.vfs.contents[b'badfile'] = b'ababagalamaga\n'
Augie Fackler
formatting: blacken the codebase...
r43346 with self.assertRaisesRegex(
error.CorruptedState, 'dictionary.*element.*'
):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 scmutil.simplekeyvaluefile(self.vfs, b'badfile').read()
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553
Kostia Balytskyi
scmutil: make simplekeyvaluefile able to have a non-key-value first line...
r32270 def testfirstline(self):
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 dw = {b'key1': b'value1'}
scmutil.simplekeyvaluefile(self.vfs, b'fl').write(dw, firstline=b'1.0')
self.assertEqual(self.vfs.read(b'fl'), b'1.0\nkey1=value1\n')
Augie Fackler
formatting: blacken the codebase...
r43346 dr = scmutil.simplekeyvaluefile(self.vfs, b'fl').read(
firstlinenonkeyval=True
)
Augie Fackler
tests: port test-simplekeyvaluefile.py to Python 3...
r37958 self.assertEqual(dr, {b'__firstline': b'1.0', b'key1': b'value1'})
Kostia Balytskyi
scmutil: make simplekeyvaluefile able to have a non-key-value first line...
r32270
Augie Fackler
formatting: blacken the codebase...
r43346
Kostia Balytskyi
scmutil: add a simple key-value file helper...
r31553 if __name__ == "__main__":
silenttestrunner.main(__name__)