upstream/mercurial-mirror Files · hgext/remotefilelog/shallowverifier.py

lock: pass "success" boolean to _afterlock callbacks...

lock: pass "success" boolean to _afterlock callbacks This lets the callback decide if it should actually run or not. I suspect that most callbacks (and hooks) *should not* run in this scenario, but I'm trying to not break any existing behavior. `persistmanifestcache`, however, seems actively dangerous to run: we just encountered an exception and the repo is in an unknown state (hopefully a consistent one due to transactions, but this is not 100% guaranteed), and the data we cache may be based on this unknown state. This was observed by our users since we wrap some of the functions that persistmanifestcache calls and it expects that the repo object is in a certain state that we'd set up earlier. If the user hits ctrl-c before we establish that state, we end up crashing there. I'm going to make that extension resilient to this issue, but figured it might be a common issue and should be handled here as well instead of just working around the issue. Differential Revision: https://phab.mercurial-scm.org/D7459

Augie Fackler - - Load All Authors

File last commit:

r43347:687b865b default


                r44217:888bd39e

default

Download file

             shallowverifier.py
        
                    19 lines
            
             | 625 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / hgext / remotefilelog / shallowverifier.py
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Augie Fackler
    
remotefilelog: import pruned-down remotefilelog extension from hg-experimental...

              r40530
            
      # shallowverifier.py - shallow repository verifier

      #

      # Copyright 2015 Facebook, Inc.

      #

      # This software may be used and distributed according to the terms of the

      # GNU General Public License version 2 or any later version.

      from __future__ import absolute_import

      from mercurial.i18n import _

      from mercurial import verify

        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
        Augie Fackler
    
remotefilelog: import pruned-down remotefilelog extension from hg-experimental...

              r40530
            
      class shallowverifier(verify.verifier):

          def _verifyfiles(self, filenodes, filelinkrevs):

              """Skips files verification since repo's not guaranteed to have them"""

              self.repo.ui.status(

        Augie Fackler
    
formatting: byteify all mercurial/ and hgext/ string literals...

              r43347
            
                  _(b"skipping filelog check since remotefilelog is used\n")

        Augie Fackler
    
formatting: blacken the codebase...

              r43346
            
              )

        Augie Fackler
    
remotefilelog: import pruned-down remotefilelog extension from hg-experimental...

              r40530
            
              return 0, 0

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Augie Fackler remotefilelog: import pruned-down remotefilelog extension from hg-experimental...	r40530	# shallowverifier.py - shallow repository verifier
		#
		# Copyright 2015 Facebook, Inc.
		#
		# This software may be used and distributed according to the terms of the
		# GNU General Public License version 2 or any later version.
		from __future__ import absolute_import

		from mercurial.i18n import _
		from mercurial import verify

Augie Fackler formatting: blacken the codebase...	r43346
Augie Fackler remotefilelog: import pruned-down remotefilelog extension from hg-experimental...	r40530	class shallowverifier(verify.verifier):
		def _verifyfiles(self, filenodes, filelinkrevs):
		"""Skips files verification since repo's not guaranteed to have them"""
		self.repo.ui.status(
Augie Fackler formatting: byteify all mercurial/ and hgext/ string literals...	r43347	_(b"skipping filelog check since remotefilelog is used\n")
Augie Fackler formatting: blacken the codebase...	r43346	)
Augie Fackler remotefilelog: import pruned-down remotefilelog extension from hg-experimental...	r40530	return 0, 0