upstream/mercurial-mirror Files · rust/hg-core/src/exit_codes.rs

hgweb: skip logging ConnectionAbortedError...

hgweb: skip logging ConnectionAbortedError Not stacktracing on `ConnectionResetError` was added in (though it was spelled differently for py2 support), but for some reason Windows occasionally triggers a `ConnectionAbortedError` here across various *.t files (notably `test-archive.t` and `test-lfs-serve-access.t`, but there are others). The payload that fails to send seems to be the html that describes the error to the client, so I suspect some code is seeing the error status code and closing the connection before the server gets to write this html. So don't log it, for test stability- nothing we can do anyway. FWIW, the CPython implementation of wsgihander specifically ignores these two errors, plus `BrokenPipeError`, with a comment that "we expect the client to close the connection abruptly from time to time"[1]. The `BrokenPipeError` is swallowed a level up in `do_write()`, and avoids writing the response following this stacktrace. I'm puzzled why a response is being written after these connection errors are detected- the CPython code referenced doesn't, and the connection is now broken at this point. Perhaps these errors should both be handled with the `BrokenPipeError` after the freeze. (The refactoring away from py2 compat may not be desireable in the freeze, but this is much easier to read, and obviously correct given the referenced CPython code.) I suspect this is what was attempting to fix, but it wasn't specific about the sporadic errors it was seeing. [1] https://github.com/python/cpython/blob/b2eaa75b176e07730215d76d8dce4d63fb493391/Lib/wsgiref/handlers.py#L139

Raphaël Gomès - - Load All Authors

File last commit:

r50383:7c93e38a default


                r53050:891f6d56

stable

Download file

             exit_codes.rs
        
                    26 lines
            
             | 762 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / exit_codes.rs
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Pulkit Goyal
    
rhg: add exit code to HgError::Abort()...

              r48199
            
      pub type ExitCode = i32;

      /// Successful exit

      pub const OK: ExitCode = 0;

      /// Generic abort

      pub const ABORT: ExitCode = 255;

      // Abort when there is a config related error

      pub const CONFIG_ERROR_ABORT: ExitCode = 30;

        Raphaël Gomès
    
rhg-status: add support for narrow clones

              r50383
            
      /// Indicates that the operation might work if retried in a different state.

      /// Examples: Unresolved merge conflicts, unfinished operations

      pub const STATE_ERROR: ExitCode = 20;

        Pulkit Goyal
    
rhg: add exit code to HgError::Abort()...

              r48199
            
      // Abort when there is an error while parsing config

      pub const CONFIG_PARSE_ERROR_ABORT: ExitCode = 10;

      /// Generic something completed but did not succeed

      pub const UNSUCCESSFUL: ExitCode = 1;

      /// Command or feature not implemented by rhg

      pub const UNIMPLEMENTED: ExitCode = 252;

        Raphaël Gomès
    
rhg: use `Command::exec` instead of `Command::status`...

              r50043
            
      /// The fallback path is not valid

      pub const INVALID_FALLBACK: ExitCode = 253;

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Pulkit Goyal rhg: add exit code to HgError::Abort()...	r48199	pub type ExitCode = i32;

		/// Successful exit
		pub const OK: ExitCode = 0;

		/// Generic abort
		pub const ABORT: ExitCode = 255;

		// Abort when there is a config related error
		pub const CONFIG_ERROR_ABORT: ExitCode = 30;

Raphaël Gomès rhg-status: add support for narrow clones	r50383	/// Indicates that the operation might work if retried in a different state.
		/// Examples: Unresolved merge conflicts, unfinished operations
		pub const STATE_ERROR: ExitCode = 20;

Pulkit Goyal rhg: add exit code to HgError::Abort()...	r48199	// Abort when there is an error while parsing config
		pub const CONFIG_PARSE_ERROR_ABORT: ExitCode = 10;

		/// Generic something completed but did not succeed
		pub const UNSUCCESSFUL: ExitCode = 1;

		/// Command or feature not implemented by rhg
		pub const UNIMPLEMENTED: ExitCode = 252;
Raphaël Gomès rhg: use `Command::exec` instead of `Command::status`...	r50043
		/// The fallback path is not valid
		pub const INVALID_FALLBACK: ExitCode = 253;