upstream/mercurial-mirror Files · rust/hg-core/src/operations/mod.rs

match: convert O(n) to O(log n) in exactmatcher.visitchildrenset...

match: convert O(n) to O(log n) in exactmatcher.visitchildrenset When using narrow, during rebase this is called (at least) once per directory in the set of files in the commit being rebased. Every time it's called, we did the set arithmetic (now extracted and cached), which was probably pretty cheap but not necessary to repeat each time, looped over every item in the matcher and kept things that started with the directory we were querying. With very large narrowspecs, and a commit that touched a file in a large number of directories, this was slow. In a pathological repo, the rebase of a single commit (that touched over 17k files, I believe in approximately as many directories) with a narrowspec that had >32k entries took 8,246s of profiled time, with 5,007s of that spent in visitchildrenset (transitively). With this change, the time spent in visitchildrenset is less than 34s (which is where my profile cut off). Most of the remaining time was network access due to our custom remotefilelog-based setup not properly prefetching. Differential Revision: https://phab.mercurial-scm.org/D10294

Simon Sapin - - Load All Authors

File last commit:

r47478:b1f2c2b3 default


                r47634:8bca353b

default

Download file

             mod.rs
        
                    12 lines
            
             | 468 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-core / src / operations / mod.rs
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Antoine Cezar
    
hg-core: remove the `Operation` trait...

              r45917
            
      //! A distinction is made between operations and commands.

      //! An operation is what can be done whereas a command is what is exposed by

      //! the cli. A single command can use several operations to achieve its goal.

        Antoine Cezar
    
hg-core: add a `CatRev` operation...

              r46112
            
      mod cat;

        Antoine Cezar
    
hg-core: define a `DebugData` `Operation`...

              r46098
            
      mod debugdata;

        Raphaël Gomès
    
hg-core: define a `dirstate_status` `Operation`...

              r45673
            
      mod dirstate_status;

        Antoine Cezar
    
hg-core: define a `ListTrackedFiles` `Operation`...

              r45918
            
      mod list_tracked_files;

        Simon Sapin
    
rhg: `cat` command: print error messages for missing files...

              r47478
            
      pub use cat::{cat, CatOutput};

        Simon Sapin
    
rust: remove three enums that were identical to `RevlogError`...

              r47166
            
      pub use debugdata::{debug_data, DebugDataKind};

        Simon Sapin
    
rust: Remove DirstateParseError and ListDirstateTrackedFilesError...

              r47169
            
      pub use list_tracked_files::Dirstate;

        Simon Sapin
    
rust: remove three enums that were identical to `RevlogError`...

              r47166
            
      pub use list_tracked_files::{list_rev_tracked_files, FilesForRev};

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Antoine Cezar hg-core: remove the `Operation` trait...	r45917	//! A distinction is made between operations and commands.
		//! An operation is what can be done whereas a command is what is exposed by
		//! the cli. A single command can use several operations to achieve its goal.

Antoine Cezar hg-core: add a `CatRev` operation...	r46112	mod cat;
Antoine Cezar hg-core: define a `DebugData` `Operation`...	r46098	mod debugdata;
Raphaël Gomès hg-core: define a `dirstate_status` `Operation`...	r45673	mod dirstate_status;
Antoine Cezar hg-core: define a `ListTrackedFiles` `Operation`...	r45918	mod list_tracked_files;
Simon Sapin rhg: `cat` command: print error messages for missing files...	r47478	pub use cat::{cat, CatOutput};
Simon Sapin rust: remove three enums that were identical to `RevlogError`...	r47166	pub use debugdata::{debug_data, DebugDataKind};
Simon Sapin rust: Remove DirstateParseError and ListDirstateTrackedFilesError...	r47169	pub use list_tracked_files::Dirstate;
Simon Sapin rust: remove three enums that were identical to `RevlogError`...	r47166	pub use list_tracked_files::{list_rev_tracked_files, FilesForRev};