##// END OF EJS Templates
upstream » mercurial-mirror
RSS

Clone from https://www.mercurial-scm.org/repo/hg-all

posix: always seek to EOF when opening a file in append mode...
posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.
Matt Mackall - - Load All Authors

File last commit:

r5514:c29efd27 default
r42778:97ada9b8 5.0.2 stable
Show More
CONTRIBUTORS
41 lines | 1.6 KiB | text/plain | TextLexer
/ CONTRIBUTORS
History | Source | Raw |Copy content |Copy permalink
Matt Mackall
Add note to CONTRIBUTORS file
 r5514 [This file is here for historical purposes, all recent contributors
should appear in the changelog directly]
Andrea Arcangeli <andrea at suse.de>
mpm@selenic.com
Add a CONTRIBUTORS file...
 r519 Thomas Arendsen Hein <thomas at intevation.de>
Goffredo Baroncelli <kreijack at libero.it>
Thomas Arendsen Hein
Added new code contributors, fixed Vincent's name, added hint on encoding.
 r756 Muli Ben-Yehuda <mulix at mulix.org>
Mikael Berthe <mikael at lilotux.net>
Matt Mackall
Add Benoit to CONTRIBUTORS
 r1450 Benoit Boissinot <bboissin at gmail.com>
Brendan Cully
Add self to contributors
 r2947 Brendan Cully <brendan at kublai.com>
mpm@selenic.com
Add a CONTRIBUTORS file...
 r519 Vincent Danjean <vdanjean.ml at free.fr>
Jake Edge <jake at edge2.net>
Michael Fetterman <michael.fetterman at intel.com>
Edouard Gomez <ed.gomez at free.fr>
mpm@selenic.com
CONTRIBUTORS update
 r1231 Eric Hopper <hopper at omnifarious.org>
Thomas Arendsen Hein
Added new code contributors, fixed Vincent's name, added hint on encoding.
 r756 Alecs King <alecsk at gmail.com>
Thomas Arendsen Hein
Updated CONTRIBUTORS.
 r1310 Volker Kleinfeld <Volker.Kleinfeld at gmx.de>
mpm@selenic.com
Add a CONTRIBUTORS file...
 r519 Vadim Lebedev <vadim at mbdsys.com>
Christopher Li <hg at chrisli.org>
Chris Mason <mason at suse.com>
Colin McMillen
Add self to CONTRIBUTORS
 r2162 Colin McMillen <mcmillen at cs.cmu.edu>
Thomas Arendsen Hein
Updated list of contributors.
 r1080 Wojciech Milkowski <wmilkowski at interia.pl>
Thomas Arendsen Hein
Added new code contributors, fixed Vincent's name, added hint on encoding.
 r756 Chad Netzer <chad.netzer at gmail.com>
mpm@selenic.com
Add a CONTRIBUTORS file...
 r519 Bryan O'Sullivan <bos at serpentine.com>
Thomas Arendsen Hein
Added new code contributors, fixed Vincent's name, added hint on encoding.
 r756 Vicent Seguí Pascual <vseguip at gmail.com>
Sean Perry <shaleh at speakeasy.net>
mpm@selenic.com
Update CONTRIBUTORS...
 r594 Nguyen Anh Quynh <aquynh at gmail.com>
Thomas Arendsen Hein
Updated CONTRIBUTORS.
 r1310 Ollivier Robert <roberto at keltia.freenix.fr>
Alexander Schremmer <alex AT alexanderweb DOT de>
Added my name to the contributors list.
 r2120 Alexander Schremmer <alex at alexanderweb.de>
mpm@selenic.com
Add a CONTRIBUTORS file...
 r519 Arun Sharma <arun at sharma-home.net>
mpm@selenic.com
CONTRIBUTORS update
 r1231 Josef "Jeff" Sipek <jeffpc at optonline.net>
Thomas Arendsen Hein
Updated CONTRIBUTORS.
 r1310 Kevin Smith <yarcs at qualitycode.com>
mpm@selenic.com
CONTRIBUTORS update
 r1231 TK Soh <teekaysoh at yahoo.com>
mpm@selenic.com
Add a CONTRIBUTORS file...
 r519 Radoslaw Szkodzinski <astralstorm at gorzow.mm.pl>
Thomas Arendsen Hein
Added Samuel Tardieu to contributors list.
 r851 Samuel Tardieu <sam at rfc1149.net>
mpm@selenic.com
Add a CONTRIBUTORS file...
 r519 K Thananchayan <thananck at yahoo.com>
Andrew Thompson <andrewkt at aktzero.com>
Michael S. Tsirkin <mst at mellanox.co.il>
Rafael Villar Burke <pachi at mmn-arquitectos.com>
Thomas Arendsen Hein
Added Tristan Wibberley to contributors.
 r855 Tristan Wibberley <tristan at wibberley.org>
Thomas Arendsen Hein
Added new code contributors, fixed Vincent's name, added hint on encoding.
 r756 Mark Williamson <mark.williamson at cl.cam.ac.uk>